From: Bo Shen <voice.shen@atmel.com>
To: Mark Brown <broonie@kernel.org>
Cc: nicolas.ferre@atmel.com,
Boris BREZILLON <b.brezillon@overkiz.com>,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>, Rob Landley <rob@landley.net>,
devicetree@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 7/8] ASoC: atmel: document clock properties of the wm8904 driver
Date: Fri, 21 Mar 2014 10:48:56 +0800 [thread overview]
Message-ID: <532BA898.90604@atmel.com> (raw)
In-Reply-To: <20140320134744.GF11706@sirena.org.uk>
Hi Mark Brown,
On 03/20/2014 09:47 PM, Mark Brown wrote:
> On Thu, Mar 20, 2014 at 10:37:53AM +0800, Bo Shen wrote:
>
>> For this, in my mind, I think we need add following parameters in DT.
>> 1. sysclk_src_from_fll --> we need do nothing.
>
> No, how would this work? If nothing else the FLL needs configuration.
Only configure it in machine driver. Then no DT operation.
>> 2. sysclk_src_from_mclk
>> 2.1 use_external_xtal --> we need clock_frequency
>> 2.2 !use_external_xtal --> we need retrieve clock and clock_frequency.
>
> No, this is all handled in the clock binding. If there's a fixed rate
> clock the device tree should have a fixed rate clock provided.
>
>> Does this acceptable? Or any other better suggestion for this?
>
> Just have the device tree describe the hardware and provide a way of
> specifying an optional MCLK.
>
I will implement an RFC patch, please help review it. Thanks.
Best Regards,
Bo Shen
WARNING: multiple messages have this Message-ID (diff)
From: Bo Shen <voice.shen@atmel.com>
To: Mark Brown <broonie@kernel.org>
Cc: <nicolas.ferre@atmel.com>,
Boris BREZILLON <b.brezillon@overkiz.com>,
"Rob Herring" <robh+dt@kernel.org>,
Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
"Kumar Gala" <galak@codeaurora.org>,
Rob Landley <rob@landley.net>, <devicetree@vger.kernel.org>,
<linux-doc@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 7/8] ASoC: atmel: document clock properties of the wm8904 driver
Date: Fri, 21 Mar 2014 10:48:56 +0800 [thread overview]
Message-ID: <532BA898.90604@atmel.com> (raw)
In-Reply-To: <20140320134744.GF11706@sirena.org.uk>
Hi Mark Brown,
On 03/20/2014 09:47 PM, Mark Brown wrote:
> On Thu, Mar 20, 2014 at 10:37:53AM +0800, Bo Shen wrote:
>
>> For this, in my mind, I think we need add following parameters in DT.
>> 1. sysclk_src_from_fll --> we need do nothing.
>
> No, how would this work? If nothing else the FLL needs configuration.
Only configure it in machine driver. Then no DT operation.
>> 2. sysclk_src_from_mclk
>> 2.1 use_external_xtal --> we need clock_frequency
>> 2.2 !use_external_xtal --> we need retrieve clock and clock_frequency.
>
> No, this is all handled in the clock binding. If there's a fixed rate
> clock the device tree should have a fixed rate clock provided.
>
>> Does this acceptable? Or any other better suggestion for this?
>
> Just have the device tree describe the hardware and provide a way of
> specifying an optional MCLK.
>
I will implement an RFC patch, please help review it. Thanks.
Best Regards,
Bo Shen
next prev parent reply other threads:[~2014-03-21 2:48 UTC|newest]
Thread overview: 73+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-17 9:45 [PATCH 0/8] ARM: at91: sama5d3: enable sound support Bo Shen
2014-03-17 9:45 ` Bo Shen
2014-03-17 9:45 ` Bo Shen
2014-03-17 9:45 ` [PATCH 1/8] ARM: at91: sama5d3: add DMA property for SSC devices Bo Shen
2014-03-17 9:45 ` Bo Shen
2014-04-18 20:47 ` Nicolas Ferre
2014-04-18 20:47 ` Nicolas Ferre
2014-04-18 20:47 ` Nicolas Ferre
2014-03-17 9:45 ` [PATCH 2/8] ARM: at91: sama5d3: disable sound by default Bo Shen
2014-03-17 9:45 ` Bo Shen
2014-03-17 9:45 ` Bo Shen
2014-04-18 20:49 ` Nicolas Ferre
2014-04-18 20:49 ` Nicolas Ferre
2014-04-18 20:49 ` Nicolas Ferre
2014-03-17 9:45 ` [PATCH 3/8] ARM: at91: sama5d3: correct the sound compatible string Bo Shen
2014-03-17 9:45 ` Bo Shen
2014-03-17 9:45 ` Bo Shen
2014-04-18 20:49 ` Nicolas Ferre
2014-04-18 20:49 ` Nicolas Ferre
2014-04-18 20:49 ` Nicolas Ferre
2014-03-17 9:45 ` [PATCH 4/8] ARM: at91: sama5d3: add the missing property Bo Shen
2014-03-17 9:45 ` Bo Shen
2014-04-18 20:50 ` Nicolas Ferre
2014-04-18 20:50 ` Nicolas Ferre
2014-04-18 20:50 ` Nicolas Ferre
2014-03-17 9:45 ` [PATCH 5/8] ARM: at91: sama5d3: clock for ssc from rk pin Bo Shen
2014-03-17 9:45 ` Bo Shen
2014-04-18 20:50 ` Nicolas Ferre
2014-04-18 20:50 ` Nicolas Ferre
2014-04-18 20:50 ` Nicolas Ferre
2014-03-17 9:45 ` [PATCH 6/8] ASoC: atmel: support CCF based clks Bo Shen
2014-03-17 9:45 ` Bo Shen
2014-03-17 9:55 ` Bo Shen
2014-03-17 9:55 ` Bo Shen
2014-03-17 10:31 ` Boris BREZILLON
2014-03-17 9:45 ` [PATCH 7/8] ASoC: atmel: document clock properties of the wm8904 driver Bo Shen
2014-03-17 9:54 ` Bo Shen
2014-03-17 9:54 ` Bo Shen
2014-03-17 10:02 ` Mark Rutland
[not found] ` <20140317100219.GB8070-NuALmloUBlrZROr8t4l/smS4ubULX0JqMm0uRHvK7Nw@public.gmane.org>
2014-03-17 10:18 ` boris brezillon
2014-03-17 10:18 ` boris brezillon
2014-03-17 10:48 ` Mark Rutland
2014-03-17 11:24 ` Boris BREZILLON
2014-03-17 11:30 ` Mark Rutland
2014-03-17 11:55 ` Mark Brown
2014-03-17 13:44 ` Boris BREZILLON
2014-03-17 15:28 ` Mark Brown
2014-03-19 5:57 ` Bo Shen
2014-03-19 5:57 ` Bo Shen
2014-03-19 10:28 ` Mark Brown
2014-03-19 10:28 ` Mark Brown
[not found] ` <20140319102800.GW11706-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2014-03-20 2:37 ` Bo Shen
2014-03-20 2:37 ` Bo Shen
2014-03-20 13:47 ` Mark Brown
2014-03-20 13:47 ` Mark Brown
2014-03-21 2:48 ` Bo Shen [this message]
2014-03-21 2:48 ` Bo Shen
2014-03-17 9:45 ` [PATCH 8/8] ARM: at91/dt: add clock properties to the wm8904 codec node Bo Shen
2014-03-17 9:45 ` Bo Shen
2014-03-17 9:55 ` Bo Shen
2014-03-17 9:55 ` Bo Shen
2014-03-17 9:55 ` Bo Shen
[not found] ` <1395049541-28128-1-git-send-email-voice.shen-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
2014-04-18 20:35 ` [PATCH 0/8] ARM: at91: sama5d3: enable sound support Nicolas Ferre
2014-04-18 20:35 ` Nicolas Ferre
2014-04-18 20:35 ` Nicolas Ferre
2014-04-18 20:38 ` Mark Brown
2014-04-18 20:38 ` Mark Brown
2014-04-18 20:38 ` Mark Brown
2014-04-18 22:06 ` Boris BREZILLON
2014-04-18 22:06 ` Boris BREZILLON
2014-04-18 22:11 ` Nicolas Ferre
2014-04-18 22:11 ` Nicolas Ferre
2014-04-18 22:11 ` Nicolas Ferre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=532BA898.90604@atmel.com \
--to=voice.shen@atmel.com \
--cc=b.brezillon@overkiz.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=nicolas.ferre@atmel.com \
--cc=pawel.moll@arm.com \
--cc=rob@landley.net \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.