* [PATCH v2] MIPS: Fix syscall tracing interface
@ 2014-03-17 11:14 Lars Persson
2014-03-17 14:41 ` Markos Chandras
0 siblings, 1 reply; 3+ messages in thread
From: Lars Persson @ 2014-03-17 11:14 UTC (permalink / raw)
To: linux-mips; +Cc: Lars Persson
Fix pointer computation for stack-based arguments.
Signed-off-by: Lars Persson <larper@axis.com>
---
arch/mips/include/asm/syscall.h | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/mips/include/asm/syscall.h b/arch/mips/include/asm/syscall.h
index c71e40a..6c488c8 100644
--- a/arch/mips/include/asm/syscall.h
+++ b/arch/mips/include/asm/syscall.h
@@ -51,14 +51,14 @@ static inline unsigned long mips_get_syscall_arg(unsigned long *arg,
#ifdef CONFIG_32BIT
case 4: case 5: case 6: case 7:
- return get_user(*arg, (int *)usp + 4 * n);
+ return get_user(*arg, (int *)usp + n);
#endif
#ifdef CONFIG_64BIT
case 4: case 5: case 6: case 7:
#ifdef CONFIG_MIPS32_O32
if (test_thread_flag(TIF_32BIT_REGS))
- return get_user(*arg, (int *)usp + 4 * n);
+ return get_user(*arg, (int *)usp + n);
else
#endif
*arg = regs->regs[4 + n];
--
1.7.2.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] MIPS: Fix syscall tracing interface
@ 2014-03-17 14:41 ` Markos Chandras
0 siblings, 0 replies; 3+ messages in thread
From: Markos Chandras @ 2014-03-17 14:41 UTC (permalink / raw)
To: Lars Persson, linux-mips; +Cc: Lars Persson
Hi Lars,
On 03/17/2014 11:14 AM, Lars Persson wrote:
> Fix pointer computation for stack-based arguments.
>
> Signed-off-by: Lars Persson <larper@axis.com>
> ---
> arch/mips/include/asm/syscall.h | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/mips/include/asm/syscall.h b/arch/mips/include/asm/syscall.h
> index c71e40a..6c488c8 100644
> --- a/arch/mips/include/asm/syscall.h
> +++ b/arch/mips/include/asm/syscall.h
> @@ -51,14 +51,14 @@ static inline unsigned long mips_get_syscall_arg(unsigned long *arg,
>
> #ifdef CONFIG_32BIT
> case 4: case 5: case 6: case 7:
> - return get_user(*arg, (int *)usp + 4 * n);
> + return get_user(*arg, (int *)usp + n);
> #endif
>
> #ifdef CONFIG_64BIT
> case 4: case 5: case 6: case 7:
> #ifdef CONFIG_MIPS32_O32
> if (test_thread_flag(TIF_32BIT_REGS))
> - return get_user(*arg, (int *)usp + 4 * n);
> + return get_user(*arg, (int *)usp + n);
> else
> #endif
> *arg = regs->regs[4 + n];
>
Thanks for the v2.
It looks good to me but I haven't tested it.
Reviewed-by: Markos Chandras <markos.chandras@imgtec.com>
--
markos
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] MIPS: Fix syscall tracing interface
@ 2014-03-17 14:41 ` Markos Chandras
0 siblings, 0 replies; 3+ messages in thread
From: Markos Chandras @ 2014-03-17 14:41 UTC (permalink / raw)
To: Lars Persson, linux-mips; +Cc: Lars Persson
Hi Lars,
On 03/17/2014 11:14 AM, Lars Persson wrote:
> Fix pointer computation for stack-based arguments.
>
> Signed-off-by: Lars Persson <larper@axis.com>
> ---
> arch/mips/include/asm/syscall.h | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/mips/include/asm/syscall.h b/arch/mips/include/asm/syscall.h
> index c71e40a..6c488c8 100644
> --- a/arch/mips/include/asm/syscall.h
> +++ b/arch/mips/include/asm/syscall.h
> @@ -51,14 +51,14 @@ static inline unsigned long mips_get_syscall_arg(unsigned long *arg,
>
> #ifdef CONFIG_32BIT
> case 4: case 5: case 6: case 7:
> - return get_user(*arg, (int *)usp + 4 * n);
> + return get_user(*arg, (int *)usp + n);
> #endif
>
> #ifdef CONFIG_64BIT
> case 4: case 5: case 6: case 7:
> #ifdef CONFIG_MIPS32_O32
> if (test_thread_flag(TIF_32BIT_REGS))
> - return get_user(*arg, (int *)usp + 4 * n);
> + return get_user(*arg, (int *)usp + n);
> else
> #endif
> *arg = regs->regs[4 + n];
>
Thanks for the v2.
It looks good to me but I haven't tested it.
Reviewed-by: Markos Chandras <markos.chandras@imgtec.com>
--
markos
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-03-17 14:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-03-17 11:14 [PATCH v2] MIPS: Fix syscall tracing interface Lars Persson
2014-03-17 14:41 ` Markos Chandras
2014-03-17 14:41 ` Markos Chandras
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.