Re: [PATCH 2/2] x86/MTRR: optionally print boot time state

[Julien Grall <julien.grall@linaro.org>]

Hi Jan,

On 03/10/2014 11:08 AM, Jan Beulich wrote:
> +static bool_t __initdata mtrr_show;
> +boolean_param("mtrr.show", mtrr_show);
> +
> +static const char *__init mtrr_attrib_to_str(mtrr_type x)
> +{
> +	static const char __initconst strings[MTRR_NUM_TYPES][16] =
> +	{
> +		[0 ... MTRR_NUM_TYPES - 1] = "?",
> +		[MTRR_TYPE_UNCACHABLE]     = "uncachable",
> +		[MTRR_TYPE_WRCOMB]         = "write-combining",
> +		[MTRR_TYPE_WRTHROUGH]      = "write-through",
> +		[MTRR_TYPE_WRPROT]         = "write-protect",
> +		[MTRR_TYPE_WRBACK]         = "write-back",
> +	};

This patch is breaking compilation with clang 3.0:

generic.c:95:32: error: initializer overrides prior initialization of this subobject [-Werror,-Winitializer-overrides]
                [MTRR_TYPE_UNCACHABLE]     = "uncachable",
                                             ^~~~~~~~~~~~
generic.c:94:32: note: previous initialization is here
                [0 ... MTRR_NUM_TYPES - 1] = "?",
                                             ^~~

Do you mind if I send a patch to replace by something like:
	[2] = "?"
        [3] = "?"

Regards,

-- 
Julien Grall