All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Henderson <rth@twiddle.net>
To: Stefan Weil <sw@weilnetz.de>, qemu-trivial@nongnu.org
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] util: Add 'static' attribute to function implementation
Date: Mon, 17 Mar 2014 09:49:32 -0700	[thread overview]
Message-ID: <5327279C.9030908@twiddle.net> (raw)
In-Reply-To: <5325F07C.80004@weilnetz.de>

On 03/16/2014 11:42 AM, Stefan Weil wrote:
> We have a similar situation with other attributes, too. Smatch also
> complains about missing QEMU_NORETURN in our implementation code (we add
> it only in header files for global functions). Do you think it would be
> good to make header and implementation match there, too?

Not without changing our CODING_STYLE.

I'm not really fond of

void attributes some_function(arg, arg, arg)

since its quite easy to wind up with too long lines.  It's one of the things I
really like about the gnu style

void attributes
some_function(arg, arg, arg)

layout.  (In addition to being an old codger who really liked to be able to do
"grep ^some_function *.c" to find the implementation.)


r~


WARNING: multiple messages have this Message-ID (diff)
From: Richard Henderson <rth@twiddle.net>
To: Stefan Weil <sw@weilnetz.de>, qemu-trivial@nongnu.org
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] util: Add 'static' attribute to function implementation
Date: Mon, 17 Mar 2014 09:49:32 -0700	[thread overview]
Message-ID: <5327279C.9030908@twiddle.net> (raw)
In-Reply-To: <5325F07C.80004@weilnetz.de>

On 03/16/2014 11:42 AM, Stefan Weil wrote:
> We have a similar situation with other attributes, too. Smatch also
> complains about missing QEMU_NORETURN in our implementation code (we add
> it only in header files for global functions). Do you think it would be
> good to make header and implementation match there, too?

Not without changing our CODING_STYLE.

I'm not really fond of

void attributes some_function(arg, arg, arg)

since its quite easy to wind up with too long lines.  It's one of the things I
really like about the gnu style

void attributes
some_function(arg, arg, arg)

layout.  (In addition to being an old codger who really liked to be able to do
"grep ^some_function *.c" to find the implementation.)


r~

  reply	other threads:[~2014-03-17 16:49 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-16 18:02 [Qemu-trivial] [PATCH] util: Add 'static' attribute to function implementation Stefan Weil
2014-03-16 18:02 ` [Qemu-devel] " Stefan Weil
2014-03-16 18:06 ` [Qemu-trivial] " Richard Henderson
2014-03-16 18:06   ` Richard Henderson
2014-03-16 18:42   ` [Qemu-trivial] " Stefan Weil
2014-03-16 18:42     ` Stefan Weil
2014-03-17 16:49     ` Richard Henderson [this message]
2014-03-17 16:49       ` Richard Henderson
2014-03-17 14:46 ` [Qemu-trivial] " Michael Tokarev
2014-03-17 14:46   ` [Qemu-devel] " Michael Tokarev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5327279C.9030908@twiddle.net \
    --to=rth@twiddle.net \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=sw@weilnetz.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.