All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Joel Peláez Jorge" <joelpelaez@gmail.com>
To: linux-kernel@vger.kernel.org
Subject: [PATCH] staging: slicoss: Fix prefer ether_addr_copy over memcpy
Date: Mon, 17 Mar 2014 19:32:18 -0600	[thread overview]
Message-ID: <5327A222.3020704@gmail.com> (raw)

This patch fixes the following checkpatch.pl issues caused by the new 
function: ether_addr_copy

Signed-off-by: Joel Pelaez Jorge <joelpelaez@gmail.com>
---
diff --git a/drivers/staging/slicoss/slicoss.c 
b/drivers/staging/slicoss/slicoss.c
index 12aafe3..4ff39aa 100644
--- a/drivers/staging/slicoss/slicoss.c
+++ b/drivers/staging/slicoss/slicoss.c
@@ -2313,7 +2313,7 @@ static int slic_mcast_add_list(struct adapter 
*adapter, char *address)
      if (mcaddr == NULL)
          return 1;

-    memcpy(mcaddr->address, address, ETH_ALEN);
+    ether_addr_copy(mcaddr->address, address);

      mcaddr->next = adapter->mcastaddrs;
      adapter->mcastaddrs = mcaddr;

             reply	other threads:[~2014-03-18  1:32 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-18  1:32 Joel Peláez Jorge [this message]
  -- strict thread matches above, loose matches on Subject: below --
2014-03-18  3:17 [PATCH] staging: slicoss: Fix prefer ether_addr_copy over memcpy Joel Pelaez Jorge
2014-03-18  3:38 ` Jingoo Han
2014-03-18  3:48   ` Joe Perches
2014-03-18 20:06 ` Greg Kroah-Hartman
2014-03-18  5:04 Joel Pelaez Jorge
2014-03-18  5:49 ` Jingoo Han
2014-03-18 23:08   ` Joel Pelaez Jorge

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5327A222.3020704@gmail.com \
    --to=joelpelaez@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.