From: Joel Pelaez Jorge <joelpelaez@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Joe Perches <joe@perches.com>,
Rashika Kheria <rashika.kheria@gmail.com>,
Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
Cc: linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org,
Jingoo Han <jg1.han@samsung.com>,
Wei Yongjun <yongjun_wei@trendmicro.com.cn>,
Dan Carpenter <dan.carpenter@oracle.com>
Subject: [PATCH] staging: slicoss: Fix prefer ether_addr_copy over memcpy
Date: Mon, 17 Mar 2014 23:04:06 -0600 [thread overview]
Message-ID: <5327D3C6.70400@gmail.com> (raw)
This patch fixes the following checkpatch.pl issues caused by the new
function: ether_addr_copy
Signed-off-by: Joel Pelaez Jorge <joelpelaez@gmail.com>
---
drivers/staging/slicoss/slicoss.c | 20 ++++++++++----------
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/drivers/staging/slicoss/slicoss.c
b/drivers/staging/slicoss/slicoss.c
index 12aafe3..0e0e374 100644
--- a/drivers/staging/slicoss/slicoss.c
+++ b/drivers/staging/slicoss/slicoss.c
@@ -581,15 +581,15 @@ static void slic_adapter_set_hwaddr(struct adapter
*adapter)
struct sliccard *card = adapter->card;
if ((adapter->card) && (card->config_set)) {
- memcpy(adapter->macaddr,
- card->config.MacInfo[adapter->functionnumber].macaddrA,
- sizeof(struct slic_config_mac));
+ ether_addr_copy(adapter->macaddr,
+ card->config.MacInfo[adapter->functionnumber]
+ .macaddrA);
if (is_zero_ether_addr(adapter->currmacaddr))
- memcpy(adapter->currmacaddr, adapter->macaddr,
- ETH_ALEN);
+ ether_addr_copy(adapter->currmacaddr,
+ adapter->macaddr);
if (adapter->netdev)
- memcpy(adapter->netdev->dev_addr, adapter->currmacaddr,
- ETH_ALEN);
+ ether_addr_copy(adapter->netdev->dev_addr,
+ adapter->currmacaddr);
}
}
@@ -810,8 +810,8 @@ static int slic_mac_set_address(struct net_device
*dev, void *ptr)
if (!is_valid_ether_addr(addr->sa_data))
return -EINVAL;
- memcpy(dev->dev_addr, addr->sa_data, dev->addr_len);
- memcpy(adapter->currmacaddr, addr->sa_data, dev->addr_len);
+ ether_addr_copy(dev->dev_addr, addr->sa_data);
+ ether_addr_copy(adapter->currmacaddr, addr->sa_data);
slic_config_set(adapter, true);
return 0;
@@ -2313,7 +2313,7 @@ static int slic_mcast_add_list(struct adapter
*adapter, char *address)
if (mcaddr == NULL)
return 1;
- memcpy(mcaddr->address, address, ETH_ALEN);
+ ether_addr_copy(mcaddr->address, address);
mcaddr->next = adapter->mcastaddrs;
adapter->mcastaddrs = mcaddr;
--
1.7.10.4
next reply other threads:[~2014-03-18 5:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-18 5:04 Joel Pelaez Jorge [this message]
2014-03-18 5:49 ` [PATCH] staging: slicoss: Fix prefer ether_addr_copy over memcpy Jingoo Han
2014-03-18 23:08 ` Joel Pelaez Jorge
-- strict thread matches above, loose matches on Subject: below --
2014-03-18 3:17 Joel Pelaez Jorge
2014-03-18 3:38 ` Jingoo Han
2014-03-18 3:48 ` Joe Perches
2014-03-18 20:06 ` Greg Kroah-Hartman
2014-03-18 1:32 Joel Peláez Jorge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5327D3C6.70400@gmail.com \
--to=joelpelaez@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=jg1.han@samsung.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peter.p.waskiewicz.jr@intel.com \
--cc=rashika.kheria@gmail.com \
--cc=yongjun_wei@trendmicro.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.