From: Paolo Bonzini <pbonzini@redhat.com>
To: Cornelia Huck <cornelia.huck@de.ibm.com>,
kvm@vger.kernel.org, linux-s390@vger.kernel.org,
qemu-devel@nongnu.org
Cc: borntraeger@de.ibm.com, agraf@suse.de, gleb@kernel.org
Subject: Re: [PATCH v2 5/5] s390x/virtio-ccw: Wire up irq routing and irqfds.
Date: Tue, 18 Mar 2014 17:13:04 +0100 [thread overview]
Message-ID: <53287090.10105@redhat.com> (raw)
In-Reply-To: <1395079921-29325-6-git-send-email-cornelia.huck@de.ibm.com>
Il 17/03/2014 19:12, Cornelia Huck ha scritto:
> if (!qemu_opt_get_bool(qemu_get_machine_opts(), "kernel_irqchip", true) ||
> - !kvm_check_extension(s, KVM_CAP_IRQCHIP)) {
> + (!kvm_check_extension(s, KVM_CAP_IRQCHIP) &&
> + kvm_enable_cap_vm(s, KVM_CAP_S390_IRQCHIP))) {
Please add a "< 0" here for clarity.
Paolo
WARNING: multiple messages have this Message-ID (diff)
From: Paolo Bonzini <pbonzini@redhat.com>
To: Cornelia Huck <cornelia.huck@de.ibm.com>,
kvm@vger.kernel.org, linux-s390@vger.kernel.org,
qemu-devel@nongnu.org
Cc: gleb@kernel.org, borntraeger@de.ibm.com, agraf@suse.de
Subject: Re: [Qemu-devel] [PATCH v2 5/5] s390x/virtio-ccw: Wire up irq routing and irqfds.
Date: Tue, 18 Mar 2014 17:13:04 +0100 [thread overview]
Message-ID: <53287090.10105@redhat.com> (raw)
In-Reply-To: <1395079921-29325-6-git-send-email-cornelia.huck@de.ibm.com>
Il 17/03/2014 19:12, Cornelia Huck ha scritto:
> if (!qemu_opt_get_bool(qemu_get_machine_opts(), "kernel_irqchip", true) ||
> - !kvm_check_extension(s, KVM_CAP_IRQCHIP)) {
> + (!kvm_check_extension(s, KVM_CAP_IRQCHIP) &&
> + kvm_enable_cap_vm(s, KVM_CAP_S390_IRQCHIP))) {
Please add a "< 0" here for clarity.
Paolo
next prev parent reply other threads:[~2014-03-18 16:13 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-17 18:11 [PATCH v2 0/5] qemu: irqfds for s390x Cornelia Huck
2014-03-17 18:11 ` [Qemu-devel] " Cornelia Huck
2014-03-17 18:11 ` [PATCH v2 1/5] linux-headers: add new interfaces Cornelia Huck
2014-03-17 18:11 ` [Qemu-devel] " Cornelia Huck
2014-03-17 18:24 ` Peter Maydell
2014-03-17 18:24 ` Peter Maydell
2014-03-18 7:26 ` Cornelia Huck
2014-03-18 7:26 ` Cornelia Huck
2014-03-17 18:11 ` [PATCH v2 2/5] kvm: add kvm_enable_cap_{vm,vcpu} Cornelia Huck
2014-03-17 18:11 ` [Qemu-devel] " Cornelia Huck
2014-03-18 16:08 ` Paolo Bonzini
2014-03-18 16:08 ` [Qemu-devel] " Paolo Bonzini
2014-03-17 18:11 ` [PATCH v2 3/5] s390x: Add I/O adapter registration Cornelia Huck
2014-03-17 18:11 ` [Qemu-devel] " Cornelia Huck
2014-03-18 16:10 ` Paolo Bonzini
2014-03-18 16:10 ` [Qemu-devel] " Paolo Bonzini
2014-03-18 17:13 ` Cornelia Huck
2014-03-18 17:13 ` [Qemu-devel] " Cornelia Huck
2014-03-17 18:12 ` [PATCH v2 4/5] s390x/virtio-ccw: reference-counted indicators Cornelia Huck
2014-03-17 18:12 ` [Qemu-devel] " Cornelia Huck
2014-03-17 18:12 ` [PATCH v2 5/5] s390x/virtio-ccw: Wire up irq routing and irqfds Cornelia Huck
2014-03-17 18:12 ` [Qemu-devel] " Cornelia Huck
2014-03-18 16:13 ` Paolo Bonzini [this message]
2014-03-18 16:13 ` Paolo Bonzini
2014-03-18 17:14 ` Cornelia Huck
2014-03-18 17:14 ` [Qemu-devel] " Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53287090.10105@redhat.com \
--to=pbonzini@redhat.com \
--cc=agraf@suse.de \
--cc=borntraeger@de.ibm.com \
--cc=cornelia.huck@de.ibm.com \
--cc=gleb@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.