From: Nicolas Ferre <nicolas.ferre@atmel.com>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] Video: atmel: avoid the id of fix screen info is overwritten
Date: Wed, 19 Mar 2014 09:50:38 +0000 [thread overview]
Message-ID: <5329686E.4070202@atmel.com> (raw)
In-Reply-To: <1395215275-14345-1-git-send-email-voice.shen@atmel.com>
On 19/03/2014 08:47, Bo Shen :
> Correct passing parameter sequence, which will avoid the id of
> fix screen info is overwritten.
>
> Signed-off-by: Bo Shen <voice.shen@atmel.com>
Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
Thanks.
> ---
> drivers/video/atmel_lcdfb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/video/atmel_lcdfb.c b/drivers/video/atmel_lcdfb.c
> index cd96162..695f28a 100644
> --- a/drivers/video/atmel_lcdfb.c
> +++ b/drivers/video/atmel_lcdfb.c
> @@ -1190,12 +1190,12 @@ static int __init atmel_lcdfb_probe(struct platform_device *pdev)
> if (!sinfo->config)
> goto free_info;
>
> - strcpy(info->fix.id, sinfo->pdev->name);
> info->flags = ATMEL_LCDFB_FBINFO_DEFAULT;
> info->pseudo_palette = sinfo->pseudo_palette;
> info->fbops = &atmel_lcdfb_ops;
>
> info->fix = atmel_lcdfb_fix;
> + strcpy(info->fix.id, sinfo->pdev->name);
>
> /* Enable LCDC Clocks */
> sinfo->bus_clk = clk_get(dev, "hclk");
>
--
Nicolas Ferre
WARNING: multiple messages have this Message-ID (diff)
From: nicolas.ferre@atmel.com (Nicolas Ferre)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] Video: atmel: avoid the id of fix screen info is overwritten
Date: Wed, 19 Mar 2014 10:50:38 +0100 [thread overview]
Message-ID: <5329686E.4070202@atmel.com> (raw)
In-Reply-To: <1395215275-14345-1-git-send-email-voice.shen@atmel.com>
On 19/03/2014 08:47, Bo Shen :
> Correct passing parameter sequence, which will avoid the id of
> fix screen info is overwritten.
>
> Signed-off-by: Bo Shen <voice.shen@atmel.com>
Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
Thanks.
> ---
> drivers/video/atmel_lcdfb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/video/atmel_lcdfb.c b/drivers/video/atmel_lcdfb.c
> index cd96162..695f28a 100644
> --- a/drivers/video/atmel_lcdfb.c
> +++ b/drivers/video/atmel_lcdfb.c
> @@ -1190,12 +1190,12 @@ static int __init atmel_lcdfb_probe(struct platform_device *pdev)
> if (!sinfo->config)
> goto free_info;
>
> - strcpy(info->fix.id, sinfo->pdev->name);
> info->flags = ATMEL_LCDFB_FBINFO_DEFAULT;
> info->pseudo_palette = sinfo->pseudo_palette;
> info->fbops = &atmel_lcdfb_ops;
>
> info->fix = atmel_lcdfb_fix;
> + strcpy(info->fix.id, sinfo->pdev->name);
>
> /* Enable LCDC Clocks */
> sinfo->bus_clk = clk_get(dev, "hclk");
>
--
Nicolas Ferre
WARNING: multiple messages have this Message-ID (diff)
From: Nicolas Ferre <nicolas.ferre@atmel.com>
To: Bo Shen <voice.shen@atmel.com>, <linux-fbdev@vger.kernel.org>,
"Tomi Valkeinen" <tomi.valkeinen@ti.com>
Cc: <linux-arm-kernel@lists.infradead.org>,
Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Video: atmel: avoid the id of fix screen info is overwritten
Date: Wed, 19 Mar 2014 10:50:38 +0100 [thread overview]
Message-ID: <5329686E.4070202@atmel.com> (raw)
In-Reply-To: <1395215275-14345-1-git-send-email-voice.shen@atmel.com>
On 19/03/2014 08:47, Bo Shen :
> Correct passing parameter sequence, which will avoid the id of
> fix screen info is overwritten.
>
> Signed-off-by: Bo Shen <voice.shen@atmel.com>
Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
Thanks.
> ---
> drivers/video/atmel_lcdfb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/video/atmel_lcdfb.c b/drivers/video/atmel_lcdfb.c
> index cd96162..695f28a 100644
> --- a/drivers/video/atmel_lcdfb.c
> +++ b/drivers/video/atmel_lcdfb.c
> @@ -1190,12 +1190,12 @@ static int __init atmel_lcdfb_probe(struct platform_device *pdev)
> if (!sinfo->config)
> goto free_info;
>
> - strcpy(info->fix.id, sinfo->pdev->name);
> info->flags = ATMEL_LCDFB_FBINFO_DEFAULT;
> info->pseudo_palette = sinfo->pseudo_palette;
> info->fbops = &atmel_lcdfb_ops;
>
> info->fix = atmel_lcdfb_fix;
> + strcpy(info->fix.id, sinfo->pdev->name);
>
> /* Enable LCDC Clocks */
> sinfo->bus_clk = clk_get(dev, "hclk");
>
--
Nicolas Ferre
next prev parent reply other threads:[~2014-03-19 9:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-19 7:47 [PATCH] Video: atmel: avoid the id of fix screen info is overwritten Bo Shen
2014-03-19 7:47 ` Bo Shen
2014-03-19 7:47 ` Bo Shen
2014-03-19 9:50 ` Nicolas Ferre [this message]
2014-03-19 9:50 ` Nicolas Ferre
2014-03-19 9:50 ` Nicolas Ferre
2014-03-19 11:04 ` Tomi Valkeinen
2014-03-19 11:04 ` Tomi Valkeinen
2014-03-19 11:04 ` Tomi Valkeinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5329686E.4070202@atmel.com \
--to=nicolas.ferre@atmel.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.