From: Ben Dooks <ben.dooks@codethink.co.uk>
To: linux-sh@vger.kernel.org
Subject: Re: [RFC 4/6] ARM: shmobile: r8a7790: call sh_pm_runtime_init()
Date: Wed, 19 Mar 2014 16:15:20 +0000 [thread overview]
Message-ID: <5329C298.6050002@codethink.co.uk> (raw)
In-Reply-To: <1395054917-27390-5-git-send-email-ben.dooks@codethink.co.uk>
On 19/03/14 17:10, Geert Uytterhoeven wrote:
> Hi Ben,
>
> On Mon, Mar 17, 2014 at 12:15 PM, Ben Dooks <ben.dooks@codethink.co.uk> wrote:
>> Ensure pm_runtime is initialised.
>>
>> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
>> ---
>> arch/arm/mach-shmobile/setup-r8a7790.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/arm/mach-shmobile/setup-r8a7790.c b/arch/arm/mach-shmobile/setup-r8a7790.c
>> index c4616f0..8424cb4 100644
>> --- a/arch/arm/mach-shmobile/setup-r8a7790.c
>> +++ b/arch/arm/mach-shmobile/setup-r8a7790.c
>> @@ -305,6 +305,7 @@ void __init r8a7790_add_dt_devices(void)
>>
>> void __init r8a7790_add_standard_devices(void)
>> {
>> + sh_pm_runtime_init();
>> r8a7790_add_dt_devices();
>> r8a7790_register_irqc(0);
>> r8a7790_register_thermal();
>
> Are you sure this is the right function?
> r8a7790_add_standard_devices() is only called from board-lager.c,
> not from board-lager-reference.c.
>
> I'd expect it to be added to r8a7790_add_dt_devices().
Thanks, I only put this out as an RFC, not had time to do a full
test yet.
--
Ben Dooks http://www.codethink.co.uk/
Senior Engineer Codethink - Providing Genius
next prev parent reply other threads:[~2014-03-19 16:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-17 11:15 [RFC 4/6] ARM: shmobile: r8a7790: call sh_pm_runtime_init() Ben Dooks
2014-03-19 16:10 ` Geert Uytterhoeven
2014-03-19 16:15 ` Ben Dooks [this message]
2014-03-19 16:16 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5329C298.6050002@codethink.co.uk \
--to=ben.dooks@codethink.co.uk \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.