All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Eric Paris <eparis@redhat.com>, linux-audit@redhat.com
Cc: linux-sh@vger.kernel.org
Subject: Re: [PATCH 1/4] SH: define syscall_get_arch() for superh
Date: Thu, 20 Mar 2014 03:01:44 +0300	[thread overview]
Message-ID: <532A2FE8.7020502@cogentembedded.com> (raw)
In-Reply-To: <1395266643-3139-1-git-send-email-eparis@redhat.com>

Hello.

On 03/20/2014 01:04 AM, Eric Paris wrote:

> This patch defines syscall_get_arch() for the superh platform.  It does
> so in both syscall_32.h and syscall_64.h.  I'm not certain if the
> implementation in syscall_64.h couldn't just be used in syscall.h as I
> can't really track the setting of CONFIG_64BIT...

> This way is safe, but we might be able to combine these if a superh
> person were able to review...

> Signed-off-by: Eric Paris <eparis@redhat.com>
> Cc: linux-sh@vger.kernel.org
> ---
>   arch/sh/include/asm/syscall_32.h | 10 ++++++++++
>   arch/sh/include/asm/syscall_64.h | 14 ++++++++++++++
>   2 files changed, 24 insertions(+)

> diff --git a/arch/sh/include/asm/syscall_32.h b/arch/sh/include/asm/syscall_32.h
> index 7d80df4..460e9c6 100644
> --- a/arch/sh/include/asm/syscall_32.h
> +++ b/arch/sh/include/asm/syscall_32.h
[...]
> @@ -93,4 +94,13 @@ static inline void syscall_set_arguments(struct task_struct *task,
>   	}
>   }
>
> +static inline int syscall_get_arch(void)
> +{
> +	int arch = EM_SH;
> +
> +#ifdef CONFIG_CPU_LITTLE_ENDIAN
> +		arch |= __AUDIT_ARCH_LE;

    Er, why the indentation jumped to the right suddenly?

> +#endif
> +	return arch;
> +}
>   #endif /* __ASM_SH_SYSCALL_32_H */

WBR, Sergei


WARNING: multiple messages have this Message-ID (diff)
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Eric Paris <eparis@redhat.com>, linux-audit@redhat.com
Cc: linux-sh@vger.kernel.org
Subject: Re: [PATCH 1/4] SH: define syscall_get_arch() for superh
Date: Wed, 19 Mar 2014 23:01:51 +0000	[thread overview]
Message-ID: <532A2FE8.7020502@cogentembedded.com> (raw)
In-Reply-To: <1395266643-3139-1-git-send-email-eparis@redhat.com>

Hello.

On 03/20/2014 01:04 AM, Eric Paris wrote:

> This patch defines syscall_get_arch() for the superh platform.  It does
> so in both syscall_32.h and syscall_64.h.  I'm not certain if the
> implementation in syscall_64.h couldn't just be used in syscall.h as I
> can't really track the setting of CONFIG_64BIT...

> This way is safe, but we might be able to combine these if a superh
> person were able to review...

> Signed-off-by: Eric Paris <eparis@redhat.com>
> Cc: linux-sh@vger.kernel.org
> ---
>   arch/sh/include/asm/syscall_32.h | 10 ++++++++++
>   arch/sh/include/asm/syscall_64.h | 14 ++++++++++++++
>   2 files changed, 24 insertions(+)

> diff --git a/arch/sh/include/asm/syscall_32.h b/arch/sh/include/asm/syscall_32.h
> index 7d80df4..460e9c6 100644
> --- a/arch/sh/include/asm/syscall_32.h
> +++ b/arch/sh/include/asm/syscall_32.h
[...]
> @@ -93,4 +94,13 @@ static inline void syscall_set_arguments(struct task_struct *task,
>   	}
>   }
>
> +static inline int syscall_get_arch(void)
> +{
> +	int arch = EM_SH;
> +
> +#ifdef CONFIG_CPU_LITTLE_ENDIAN
> +		arch |= __AUDIT_ARCH_LE;

    Er, why the indentation jumped to the right suddenly?

> +#endif
> +	return arch;
> +}
>   #endif /* __ASM_SH_SYSCALL_32_H */

WBR, Sergei


  parent reply	other threads:[~2014-03-20  0:01 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-19 22:04 [PATCH 1/4] SH: define syscall_get_arch() for superh Eric Paris
2014-03-19 22:04 ` Eric Paris
2014-03-19 22:04 ` [PATCH 2/4] UM: implement syscall_get_arch() Eric Paris
2014-03-19 22:04   ` [uml-devel] " Eric Paris
2014-03-21 19:08   ` Richard Guy Briggs
2014-03-21 19:08     ` [uml-devel] " Richard Guy Briggs
2014-03-21 19:22     ` Richard Guy Briggs
2014-03-21 19:22       ` [uml-devel] " Richard Guy Briggs
2014-03-24  1:03     ` Eric Paris
2014-03-24  1:03       ` [uml-devel] " Eric Paris
2014-03-21 19:24   ` Richard Guy Briggs
2014-03-21 19:24     ` [uml-devel] " Richard Guy Briggs
2014-03-19 22:04 ` [PATCH 3/4] ARCH: AUDIT: implement syscall_get_arch for all arches Eric Paris
2014-03-19 22:04   ` Eric Paris
2014-03-19 22:04   ` Eric Paris
2014-03-19 22:19   ` Matt Turner
2014-03-19 22:19     ` Matt Turner
2014-03-19 22:19     ` Matt Turner
2014-03-19 23:02     ` Eric Paris
2014-03-19 23:02       ` Eric Paris
2014-03-19 23:02       ` Eric Paris
2014-03-21 19:13   ` Richard Guy Briggs
2014-03-21 19:13     ` Richard Guy Briggs
2014-03-21 19:13     ` Richard Guy Briggs
2014-04-22  3:09   ` Stephen Rothwell
2014-04-22  3:09     ` Stephen Rothwell
2014-04-22  3:09     ` Stephen Rothwell
2014-04-22  3:09     ` Stephen Rothwell
2014-03-19 22:04 ` [PATCH 4/4] ARCH: AUDIT: audit_syscall_entry() should not require the arch Eric Paris
2014-03-19 22:04   ` Eric Paris
2014-03-19 22:04   ` Eric Paris
2014-03-19 22:04   ` Eric Paris
2014-03-21 19:18   ` Richard Guy Briggs
2014-03-21 19:18     ` Richard Guy Briggs
2014-03-21 19:18     ` Richard Guy Briggs
2014-03-21 19:18     ` Richard Guy Briggs
2014-03-19 23:01 ` Sergei Shtylyov [this message]
2014-03-20  0:01   ` [PATCH 1/4] SH: define syscall_get_arch() for superh Sergei Shtylyov
2014-03-19 23:15   ` Eric Paris
2014-03-19 23:15     ` Eric Paris
2014-03-21 18:59 ` Richard Guy Briggs
2014-03-21 18:59   ` Richard Guy Briggs

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=532A2FE8.7020502@cogentembedded.com \
    --to=sergei.shtylyov@cogentembedded.com \
    --cc=eparis@redhat.com \
    --cc=linux-audit@redhat.com \
    --cc=linux-sh@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.