All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ben Dooks <ben.dooks@codethink.co.uk>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: Arnd Bergmann <arnd@arndb.de>,
	linux-sh@vger.kernel.org,
	"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Magnus Damm <damm@opensource.se>, Ben Dooks <ben-linux@fluff.org>,
	Bjorn Helgaas <bhelgaas@google.com>,
	Simon Horman <horms+renesas@verge.net.au>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: DMABOUNCE in pci-rcar
Date: Thu, 20 Mar 2014 16:36:52 +0100	[thread overview]
Message-ID: <532B0B14.7040600@codethink.co.uk> (raw)
In-Reply-To: <20140320152640.GW7528@n2100.arm.linux.org.uk>

On 20/03/14 16:26, Russell King - ARM Linux wrote:
> On Thu, Mar 20, 2014 at 04:04:36PM +0100, Ben Dooks wrote:
>> On 26/02/14 20:57, Arnd Bergmann wrote:
>>> On Wednesday 26 February 2014 12:48:17 Bjorn Helgaas wrote:
>>>> On Mon, Feb 24, 2014 at 4:00 AM, Arnd Bergmann <arnd@arndb.de> wrote:
>>>>> Hi Magnus,
>>>>>
>>>>> I noticed during randconfig testing that you enabled DMABOUNCE for the
>>>>> pci-rcar-gen2 driver as posted in this patch https://lkml.org/lkml/2014/2/5/30
>>>>>
>>>>> I didn't see the original post unfortunately, but I fear we have to
>>>>> revert it and come up with a better solution, ...
>>>>
>>>> Sounds like I should drop the following patches from my pci/host-rcar
>>>> branch for now?
>>>>
>>>>     PCI: rcar: Add DMABOUNCE support
>>>>     PCI: rcar: Enable BOUNCE in case of HIGHMEM
>>>>     PCI: rcar: Make the Kconfig dependencies more generic
>>>
>>> Sounds good to me. The last patch is actually fine, but you'll have to
>>> fix the context to apply it without the other two.
>>
>> As a note, if we now boot a Lager with DT on 3.14-rc3 series the USB
>> controllers no longer work with full 2GiB RAM enabled in the device
>> tree.
>>
>> Could we work around this by having 1GiB of memory defined in the
>> 32bit memory and then add the rest of the 3GiB from the >32bit
>> area via LPAE? Will the kernel ever try to allocate DMA memory from
>> anything >32bit?
>
> Ignore highmem.  What is the actual hardware restriction concerning memory
> it can access?

If the window is set to 2GiB it can only access 2GiB aligned to 2GiB
boundary, however DRAM spans a 2GiB boundary (being at 1-3GiB)


-- 
Ben Dooks				http://www.codethink.co.uk/
Senior Engineer				Codethink - Providing Genius

WARNING: multiple messages have this Message-ID (diff)
From: Ben Dooks <ben.dooks@codethink.co.uk>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: DMABOUNCE in pci-rcar
Date: Thu, 20 Mar 2014 15:36:52 +0000	[thread overview]
Message-ID: <532B0B14.7040600@codethink.co.uk> (raw)
In-Reply-To: <20140320152640.GW7528@n2100.arm.linux.org.uk>

On 20/03/14 16:26, Russell King - ARM Linux wrote:
> On Thu, Mar 20, 2014 at 04:04:36PM +0100, Ben Dooks wrote:
>> On 26/02/14 20:57, Arnd Bergmann wrote:
>>> On Wednesday 26 February 2014 12:48:17 Bjorn Helgaas wrote:
>>>> On Mon, Feb 24, 2014 at 4:00 AM, Arnd Bergmann <arnd@arndb.de> wrote:
>>>>> Hi Magnus,
>>>>>
>>>>> I noticed during randconfig testing that you enabled DMABOUNCE for the
>>>>> pci-rcar-gen2 driver as posted in this patch https://lkml.org/lkml/2014/2/5/30
>>>>>
>>>>> I didn't see the original post unfortunately, but I fear we have to
>>>>> revert it and come up with a better solution, ...
>>>>
>>>> Sounds like I should drop the following patches from my pci/host-rcar
>>>> branch for now?
>>>>
>>>>     PCI: rcar: Add DMABOUNCE support
>>>>     PCI: rcar: Enable BOUNCE in case of HIGHMEM
>>>>     PCI: rcar: Make the Kconfig dependencies more generic
>>>
>>> Sounds good to me. The last patch is actually fine, but you'll have to
>>> fix the context to apply it without the other two.
>>
>> As a note, if we now boot a Lager with DT on 3.14-rc3 series the USB
>> controllers no longer work with full 2GiB RAM enabled in the device
>> tree.
>>
>> Could we work around this by having 1GiB of memory defined in the
>> 32bit memory and then add the rest of the 3GiB from the >32bit
>> area via LPAE? Will the kernel ever try to allocate DMA memory from
>> anything >32bit?
>
> Ignore highmem.  What is the actual hardware restriction concerning memory
> it can access?

If the window is set to 2GiB it can only access 2GiB aligned to 2GiB
boundary, however DRAM spans a 2GiB boundary (being at 1-3GiB)


-- 
Ben Dooks				http://www.codethink.co.uk/
Senior Engineer				Codethink - Providing Genius

WARNING: multiple messages have this Message-ID (diff)
From: ben.dooks@codethink.co.uk (Ben Dooks)
To: linux-arm-kernel@lists.infradead.org
Subject: DMABOUNCE in pci-rcar
Date: Thu, 20 Mar 2014 16:36:52 +0100	[thread overview]
Message-ID: <532B0B14.7040600@codethink.co.uk> (raw)
In-Reply-To: <20140320152640.GW7528@n2100.arm.linux.org.uk>

On 20/03/14 16:26, Russell King - ARM Linux wrote:
> On Thu, Mar 20, 2014 at 04:04:36PM +0100, Ben Dooks wrote:
>> On 26/02/14 20:57, Arnd Bergmann wrote:
>>> On Wednesday 26 February 2014 12:48:17 Bjorn Helgaas wrote:
>>>> On Mon, Feb 24, 2014 at 4:00 AM, Arnd Bergmann <arnd@arndb.de> wrote:
>>>>> Hi Magnus,
>>>>>
>>>>> I noticed during randconfig testing that you enabled DMABOUNCE for the
>>>>> pci-rcar-gen2 driver as posted in this patch https://lkml.org/lkml/2014/2/5/30
>>>>>
>>>>> I didn't see the original post unfortunately, but I fear we have to
>>>>> revert it and come up with a better solution, ...
>>>>
>>>> Sounds like I should drop the following patches from my pci/host-rcar
>>>> branch for now?
>>>>
>>>>     PCI: rcar: Add DMABOUNCE support
>>>>     PCI: rcar: Enable BOUNCE in case of HIGHMEM
>>>>     PCI: rcar: Make the Kconfig dependencies more generic
>>>
>>> Sounds good to me. The last patch is actually fine, but you'll have to
>>> fix the context to apply it without the other two.
>>
>> As a note, if we now boot a Lager with DT on 3.14-rc3 series the USB
>> controllers no longer work with full 2GiB RAM enabled in the device
>> tree.
>>
>> Could we work around this by having 1GiB of memory defined in the
>> 32bit memory and then add the rest of the 3GiB from the >32bit
>> area via LPAE? Will the kernel ever try to allocate DMA memory from
>> anything >32bit?
>
> Ignore highmem.  What is the actual hardware restriction concerning memory
> it can access?

If the window is set to 2GiB it can only access 2GiB aligned to 2GiB
boundary, however DRAM spans a 2GiB boundary (being at 1-3GiB)


-- 
Ben Dooks				http://www.codethink.co.uk/
Senior Engineer				Codethink - Providing Genius

  reply	other threads:[~2014-03-20 15:36 UTC|newest]

Thread overview: 72+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-24 11:00 DMABOUNCE in pci-rcar Arnd Bergmann
2014-02-24 11:00 ` Arnd Bergmann
2014-02-24 11:00 ` Arnd Bergmann
2014-02-24 23:49 ` Magnus Damm
2014-02-24 23:49   ` Magnus Damm
2014-02-24 23:49   ` Magnus Damm
2014-02-25  0:17   ` Russell King - ARM Linux
2014-02-25  0:17     ` Russell King - ARM Linux
2014-02-25  0:17     ` Russell King - ARM Linux
2014-02-25  2:00     ` Magnus Damm
2014-02-25  2:00       ` Magnus Damm
2014-02-25  2:00       ` Magnus Damm
2014-02-25 15:44       ` Arnd Bergmann
2014-02-25 15:44         ` Arnd Bergmann
2014-02-25 15:44         ` Arnd Bergmann
2014-02-25 12:15   ` Arnd Bergmann
2014-02-25 12:15     ` Arnd Bergmann
2014-02-25 12:15     ` Arnd Bergmann
2014-02-26 19:48 ` Bjorn Helgaas
2014-02-26 19:48   ` Bjorn Helgaas
2014-02-26 19:48   ` Bjorn Helgaas
2014-02-26 19:57   ` Arnd Bergmann
2014-02-26 19:57     ` Arnd Bergmann
2014-02-26 19:57     ` Arnd Bergmann
2014-02-26 21:02     ` Bjorn Helgaas
2014-02-26 21:02       ` Bjorn Helgaas
2014-02-26 21:02       ` Bjorn Helgaas
2014-02-26 21:52       ` Arnd Bergmann
2014-02-26 21:52         ` Arnd Bergmann
2014-02-26 21:52         ` Arnd Bergmann
2014-03-20 15:04     ` Ben Dooks
2014-03-20 15:04       ` Ben Dooks
2014-03-20 15:04       ` Ben Dooks
2014-03-20 15:26       ` Russell King - ARM Linux
2014-03-20 15:26         ` Russell King - ARM Linux
2014-03-20 15:26         ` Russell King - ARM Linux
2014-03-20 15:36         ` Ben Dooks [this message]
2014-03-20 15:36           ` Ben Dooks
2014-03-20 15:36           ` Ben Dooks
2014-03-20 16:09       ` Arnd Bergmann
2014-03-20 16:09         ` Arnd Bergmann
2014-03-20 16:09         ` Arnd Bergmann
2014-03-20 16:12         ` Ben Dooks
2014-03-20 16:12           ` Ben Dooks
2014-03-20 16:12           ` Ben Dooks
2014-03-20 16:41           ` Arnd Bergmann
2014-03-20 16:41             ` Arnd Bergmann
2014-03-20 16:41             ` Arnd Bergmann
2014-03-20 17:25             ` Ben Dooks
2014-03-20 17:25               ` Ben Dooks
2014-03-20 17:25               ` Ben Dooks
2014-03-20 17:31               ` Jason Gunthorpe
2014-03-20 17:31                 ` Jason Gunthorpe
2014-03-20 17:31                 ` Jason Gunthorpe
2014-03-20 17:32                 ` Ben Dooks
2014-03-20 17:32                   ` Ben Dooks
2014-03-20 17:32                   ` Ben Dooks
2014-03-20 18:29                   ` Arnd Bergmann
2014-03-20 18:29                     ` Arnd Bergmann
2014-03-20 18:29                     ` Arnd Bergmann
2014-03-20 18:39                     ` Russell King - ARM Linux
2014-03-20 18:39                       ` Russell King - ARM Linux
2014-03-20 18:39                       ` Russell King - ARM Linux
2014-03-20 19:04                       ` Geert Uytterhoeven
2014-03-20 19:04                         ` Geert Uytterhoeven
2014-03-20 19:04                         ` Geert Uytterhoeven
2014-03-20 22:11                       ` Arnd Bergmann
2014-03-20 22:11                         ` Arnd Bergmann
2014-03-20 22:11                         ` Arnd Bergmann
2014-03-20 22:50                         ` Russell King - ARM Linux
2014-03-20 22:50                           ` Russell King - ARM Linux
2014-03-20 22:50                           ` Russell King - ARM Linux

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=532B0B14.7040600@codethink.co.uk \
    --to=ben.dooks@codethink.co.uk \
    --cc=arnd@arndb.de \
    --cc=ben-linux@fluff.org \
    --cc=bhelgaas@google.com \
    --cc=damm@opensource.se \
    --cc=horms+renesas@verge.net.au \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-sh@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.