All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: BALATON Zoltan <balaton@eik.bme.hu>
Cc: qemu-trivial@nongnu.org, Michael Tokarev <mjt@tls.msk.ru>,
	qemu-devel@nongnu.org
Subject: Re: [Qemu-trivial] [PATCH] serial-pci: Set prog interface field of pci config to 16550 compatible
Date: Thu, 20 Mar 2014 17:32:15 +0100	[thread overview]
Message-ID: <532B180F.5080301@redhat.com> (raw)
In-Reply-To: <alpine.LMD.2.02.1403201659440.1844@jedlik.phy.bme.hu>

Il 20/03/2014 17:01, BALATON Zoltan ha scritto:
> On Thu, 20 Mar 2014, Paolo Bonzini wrote:
>> Il 20/03/2014 16:42, Michael Tokarev ha scritto:
>>> 10.03.2014 22:40, BALATON Zoltan wrote:
>>>> Ping!
>>>> http://patchwork.ozlabs.org/patch/324674/
>>>
>>> Thanks, applied to -trivial.
>>
>> No, please don't; this needs to be done for new machine types only.
>
> Why? I tried running a Windows XP image that was set up before this
> patch and it did not complain about changed hardware. Or is there
> another reason I'm missing?

Classes (or anything guest-visible in fact) must never ever be changed 
for the same machine type.  It's a rule.

Paolo



WARNING: multiple messages have this Message-ID (diff)
From: Paolo Bonzini <pbonzini@redhat.com>
To: BALATON Zoltan <balaton@eik.bme.hu>
Cc: qemu-trivial@nongnu.org, Michael Tokarev <mjt@tls.msk.ru>,
	qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [Qemu-trivial] [PATCH] serial-pci: Set prog interface field of pci config to 16550 compatible
Date: Thu, 20 Mar 2014 17:32:15 +0100	[thread overview]
Message-ID: <532B180F.5080301@redhat.com> (raw)
In-Reply-To: <alpine.LMD.2.02.1403201659440.1844@jedlik.phy.bme.hu>

Il 20/03/2014 17:01, BALATON Zoltan ha scritto:
> On Thu, 20 Mar 2014, Paolo Bonzini wrote:
>> Il 20/03/2014 16:42, Michael Tokarev ha scritto:
>>> 10.03.2014 22:40, BALATON Zoltan wrote:
>>>> Ping!
>>>> http://patchwork.ozlabs.org/patch/324674/
>>>
>>> Thanks, applied to -trivial.
>>
>> No, please don't; this needs to be done for new machine types only.
>
> Why? I tried running a Windows XP image that was set up before this
> patch and it did not complain about changed hardware. Or is there
> another reason I'm missing?

Classes (or anything guest-visible in fact) must never ever be changed 
for the same machine type.  It's a rule.

Paolo

  reply	other threads:[~2014-03-20 16:32 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-27  1:05 [Qemu-devel] [PATCH] serial-pci: Set prog interface field of pci config to 16550 compatible BALATON Zoltan
2014-03-10 18:40 ` [Qemu-trivial] " BALATON Zoltan
2014-03-10 18:40   ` BALATON Zoltan
2014-03-14 16:21   ` [Qemu-trivial] " Michael Tokarev
2014-03-14 16:21     ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev
2014-03-14 17:44     ` [Qemu-trivial] [Qemu-devel] " BALATON Zoltan
2014-03-14 17:44       ` [Qemu-devel] [Qemu-trivial] " BALATON Zoltan
2014-03-14 17:57       ` [Qemu-trivial] [Qemu-devel] " BALATON Zoltan
2014-03-14 17:57         ` [Qemu-devel] [Qemu-trivial] " BALATON Zoltan
2014-03-17 12:32         ` [Qemu-trivial] [Qemu-devel] " Gerd Hoffmann
2014-03-17 12:32           ` [Qemu-devel] [Qemu-trivial] " Gerd Hoffmann
2014-03-20  9:58           ` [Qemu-trivial] [Qemu-devel] " BALATON Zoltan
2014-03-20  9:58             ` [Qemu-devel] [Qemu-trivial] " BALATON Zoltan
2014-03-21  8:43             ` [Qemu-trivial] [Qemu-devel] " Gerd Hoffmann
2014-03-21  8:43               ` [Qemu-devel] [Qemu-trivial] " Gerd Hoffmann
2014-03-21  9:10               ` [Qemu-trivial] [Qemu-devel] " BALATON Zoltan
2014-03-21  9:10                 ` [Qemu-devel] [Qemu-trivial] " BALATON Zoltan
2014-03-20 15:42   ` [Qemu-trivial] [Qemu-devel] " Michael Tokarev
2014-03-20 15:42     ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev
2014-03-20 15:51     ` Paolo Bonzini
2014-03-20 15:51       ` [Qemu-devel] " Paolo Bonzini
2014-03-20 16:01       ` BALATON Zoltan
2014-03-20 16:01         ` [Qemu-devel] " BALATON Zoltan
2014-03-20 16:32         ` Paolo Bonzini [this message]
2014-03-20 16:32           ` Paolo Bonzini
2014-03-20 16:58           ` BALATON Zoltan
2014-03-20 16:58             ` [Qemu-devel] " BALATON Zoltan
2014-03-20 17:35             ` Paolo Bonzini
2014-03-20 17:35               ` [Qemu-devel] " Paolo Bonzini
2014-03-21  8:19       ` Michael Tokarev
2014-03-21  8:19         ` [Qemu-devel] " Michael Tokarev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=532B180F.5080301@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=balaton@eik.bme.hu \
    --cc=mjt@tls.msk.ru \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.