From: Kukjin Kim <kgene.kim@samsung.com>
To: Mark Brown <broonie@kernel.org>
Cc: Kukjin Kim <kgene.kim@samsung.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-samsung-soc@vger.kernel.org,
linaro-kernel@lists.linaro.org,
linux-arm-kernel@lists.infradead.org,
Mark Brown <broonie@linaro.org>, Tomasz Figa <t.figa@samsung.com>
Subject: Re: [PATCH 2/2] ARM: s3c64xx: Fix build for implicit serial_s3c.h inclusion
Date: Fri, 21 Mar 2014 02:56:36 +0900 [thread overview]
Message-ID: <532B2BD4.7060809@samsung.com> (raw)
In-Reply-To: <1395143803-2032-2-git-send-email-broonie@kernel.org>
On 03/18/14 20:56, Mark Brown wrote:
> From: Mark Brown<broonie@linaro.org>
>
> Some very recent change appears to have removed an implicit inclusion of
> serial_s3c.h causing build failures due to references to UART registers
> in the serial port restore code in next-20140318. Include it explicitly
> to fix the build.
>
> Signed-off-by: Mark Brown<broonie@linaro.org>
> ---
> arch/arm/mach-s3c64xx/include/mach/pm-core.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm/mach-s3c64xx/include/mach/pm-core.h b/arch/arm/mach-s3c64xx/include/mach/pm-core.h
> index c0537f40a3d8..a30a1e3ffc6a 100644
> --- a/arch/arm/mach-s3c64xx/include/mach/pm-core.h
> +++ b/arch/arm/mach-s3c64xx/include/mach/pm-core.h
> @@ -15,6 +15,8 @@
> #ifndef __MACH_S3C64XX_PM_CORE_H
> #define __MACH_S3C64XX_PM_CORE_H __FILE__
>
> +#include<linux/serial_s3c.h>
> +
> #include<mach/regs-gpio.h>
>
> static inline void s3c_pm_debug_init_uart(void)
Applied, thanks.
- Kukjin
WARNING: multiple messages have this Message-ID (diff)
From: kgene.kim@samsung.com (Kukjin Kim)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] ARM: s3c64xx: Fix build for implicit serial_s3c.h inclusion
Date: Fri, 21 Mar 2014 02:56:36 +0900 [thread overview]
Message-ID: <532B2BD4.7060809@samsung.com> (raw)
In-Reply-To: <1395143803-2032-2-git-send-email-broonie@kernel.org>
On 03/18/14 20:56, Mark Brown wrote:
> From: Mark Brown<broonie@linaro.org>
>
> Some very recent change appears to have removed an implicit inclusion of
> serial_s3c.h causing build failures due to references to UART registers
> in the serial port restore code in next-20140318. Include it explicitly
> to fix the build.
>
> Signed-off-by: Mark Brown<broonie@linaro.org>
> ---
> arch/arm/mach-s3c64xx/include/mach/pm-core.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm/mach-s3c64xx/include/mach/pm-core.h b/arch/arm/mach-s3c64xx/include/mach/pm-core.h
> index c0537f40a3d8..a30a1e3ffc6a 100644
> --- a/arch/arm/mach-s3c64xx/include/mach/pm-core.h
> +++ b/arch/arm/mach-s3c64xx/include/mach/pm-core.h
> @@ -15,6 +15,8 @@
> #ifndef __MACH_S3C64XX_PM_CORE_H
> #define __MACH_S3C64XX_PM_CORE_H __FILE__
>
> +#include<linux/serial_s3c.h>
> +
> #include<mach/regs-gpio.h>
>
> static inline void s3c_pm_debug_init_uart(void)
Applied, thanks.
- Kukjin
next prev parent reply other threads:[~2014-03-20 17:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-18 11:56 [PATCH 1/2] serial: s3c: Fix build of header without serial_core.h preinclusion Mark Brown
2014-03-18 11:56 ` Mark Brown
2014-03-18 11:56 ` [PATCH 2/2] ARM: s3c64xx: Fix build for implicit serial_s3c.h inclusion Mark Brown
2014-03-18 11:56 ` Mark Brown
2014-03-20 17:56 ` Kukjin Kim [this message]
2014-03-20 17:56 ` Kukjin Kim
2014-03-18 17:30 ` [PATCH 1/2] serial: s3c: Fix build of header without serial_core.h preinclusion Tomasz Figa
2014-03-18 17:30 ` Tomasz Figa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=532B2BD4.7060809@samsung.com \
--to=kgene.kim@samsung.com \
--cc=broonie@kernel.org \
--cc=broonie@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=t.figa@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.