* [RESEND] [PATCH] xhci: Switch Intel Lynx Point ports to EHCI on shutdown.
@ 2014-03-21 10:01 Denis Turischev
2014-03-21 12:10 ` Mathias Nyman
0 siblings, 1 reply; 8+ messages in thread
From: Denis Turischev @ 2014-03-21 10:01 UTC (permalink / raw)
To: Sarah Sharp; +Cc: Greg Kroah-Hartman, linux-kernel, linux-usb
The same issue like with Panther Point chipsets. If the USB ports are
switched to xHCI on shutdown, the xHCI host will send a spurious interrupt,
which will wake the system. Some BIOS have work around for this, but not all.
One example is Compulab's mini-desktop, the Intense-PC2.
The bug can be avoided if the USB ports are switched back to EHCI on
shutdown.
Signed-off-by: Denis Turischev <denis@compulab.co.il>
---
drivers/usb/host/xhci-pci.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/usb/host/xhci-pci.c b/drivers/usb/host/xhci-pci.c
index 3c898c1..9233d12 100644
--- a/drivers/usb/host/xhci-pci.c
+++ b/drivers/usb/host/xhci-pci.c
@@ -134,6 +134,8 @@ static void xhci_pci_quirks(struct device *dev, struct xhci_hcd *xhci)
*/
if (pdev->subsystem_vendor == PCI_VENDOR_ID_HP)
xhci->quirks |= XHCI_SPURIOUS_WAKEUP;
+
+ xhci->quirks |= XHCI_SPURIOUS_REBOOT;
}
if (pdev->vendor == PCI_VENDOR_ID_ETRON &&
pdev->device == PCI_DEVICE_ID_ASROCK_P67) {
-- 1.8.1.2
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [RESEND] [PATCH] xhci: Switch Intel Lynx Point ports to EHCI on shutdown.
2014-03-21 10:01 [RESEND] [PATCH] xhci: Switch Intel Lynx Point ports to EHCI on shutdown Denis Turischev
@ 2014-03-21 12:10 ` Mathias Nyman
2014-04-22 11:04 ` Denis Turischev
0 siblings, 1 reply; 8+ messages in thread
From: Mathias Nyman @ 2014-03-21 12:10 UTC (permalink / raw)
To: Denis Turischev, Sarah Sharp; +Cc: Greg Kroah-Hartman, linux-kernel, linux-usb
On 03/21/2014 12:01 PM, Denis Turischev wrote:
> The same issue like with Panther Point chipsets. If the USB ports are
> switched to xHCI on shutdown, the xHCI host will send a spurious interrupt,
> which will wake the system. Some BIOS have work around for this, but not all.
> One example is Compulab's mini-desktop, the Intense-PC2.
>
> The bug can be avoided if the USB ports are switched back to EHCI on
> shutdown.
>
I'll queue this up and send it forward to Greg once 3.15-rc1 is out
-Mathias
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [RESEND] [PATCH] xhci: Switch Intel Lynx Point ports to EHCI on shutdown.
2014-03-21 12:10 ` Mathias Nyman
@ 2014-04-22 11:04 ` Denis Turischev
2014-04-22 12:26 ` Mathias Nyman
0 siblings, 1 reply; 8+ messages in thread
From: Denis Turischev @ 2014-04-22 11:04 UTC (permalink / raw)
To: Mathias Nyman; +Cc: Greg Kroah-Hartman, linux-kernel, linux-usb
Hi Mathias,
Just want to remind you about the patch, thanks.
Denis
On 03/21/2014 02:10 PM, Mathias Nyman wrote:
> On 03/21/2014 12:01 PM, Denis Turischev wrote:
>> The same issue like with Panther Point chipsets. If the USB ports are
>> switched to xHCI on shutdown, the xHCI host will send a spurious interrupt,
>> which will wake the system. Some BIOS have work around for this, but not all.
>> One example is Compulab's mini-desktop, the Intense-PC2.
>>
>> The bug can be avoided if the USB ports are switched back to EHCI on
>> shutdown.
>>
>
> I'll queue this up and send it forward to Greg once 3.15-rc1 is out
>
> -Mathias
>
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* [RESEND] [PATCH] xhci: Switch Intel Lynx Point ports to EHCI on shutdown.
@ 2014-03-09 12:43 Denis Turischev
0 siblings, 0 replies; 8+ messages in thread
From: Denis Turischev @ 2014-03-09 12:43 UTC (permalink / raw)
To: Sarah Sharp, Greg Kroah-Hartman; +Cc: linux-usb, linux-kernel
The same issue like with Panther Point chipsets. If the USB ports are
switched to xHCI on shutdown, the xHCI host will send a spurious interrupt,
which will wake the system. Some BIOS have work around for this, but not all.
One example is Compulab's mini-desktop, the Intense-PC2.
The bug can be avoided if the USB ports are switched back to EHCI on
shutdown.
Signed-off-by: Denis Turischev <denis@compulab.co.il>
---
drivers/usb/host/xhci-pci.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/usb/host/xhci-pci.c b/drivers/usb/host/xhci-pci.c
index 3c898c1..9233d12 100644
--- a/drivers/usb/host/xhci-pci.c
+++ b/drivers/usb/host/xhci-pci.c
@@ -134,6 +134,8 @@ static void xhci_pci_quirks(struct device *dev, struct xhci_hcd *xhci)
*/
if (pdev->subsystem_vendor == PCI_VENDOR_ID_HP)
xhci->quirks |= XHCI_SPURIOUS_WAKEUP;
+
+ xhci->quirks |= XHCI_SPURIOUS_REBOOT;
}
if (pdev->vendor == PCI_VENDOR_ID_ETRON &&
pdev->device == PCI_DEVICE_ID_ASROCK_P67) {
-- 1.8.1.2
^ permalink raw reply related [flat|nested] 8+ messages in thread* [RESEND] [PATCH] xhci: Switch Intel Lynx Point ports to EHCI on shutdown.
@ 2014-03-07 9:40 Denis Turischev
0 siblings, 0 replies; 8+ messages in thread
From: Denis Turischev @ 2014-03-07 9:40 UTC (permalink / raw)
To: Sarah Sharp, linux-usb; +Cc: Greg Kroah-Hartman, linux-kernel
The same issue like with Panther Point chipsets. If the USB ports are
switched to xHCI on shutdown, the xHCI host will send a spurious interrupt,
which will wake the system. Some BIOS have work around for this, but not all.
One example is Compulab's mini-desktop, the Intense-PC2.
The bug can be avoided if the USB ports are switched back to EHCI on
shutdown.
Signed-off-by: Denis Turischev <denis@compulab.co.il>
---
drivers/usb/host/xhci-pci.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/usb/host/xhci-pci.c b/drivers/usb/host/xhci-pci.c
index 3c898c1..9233d12 100644
--- a/drivers/usb/host/xhci-pci.c
+++ b/drivers/usb/host/xhci-pci.c
@@ -134,6 +134,8 @@ static void xhci_pci_quirks(struct device *dev, struct xhci_hcd *xhci)
*/
if (pdev->subsystem_vendor == PCI_VENDOR_ID_HP)
xhci->quirks |= XHCI_SPURIOUS_WAKEUP;
+
+ xhci->quirks |= XHCI_SPURIOUS_REBOOT;
}
if (pdev->vendor == PCI_VENDOR_ID_ETRON &&
pdev->device == PCI_DEVICE_ID_ASROCK_P67) {
-- 1.8.1.2
^ permalink raw reply related [flat|nested] 8+ messages in thread* xhci: Switch Intel Lynx Point ports to EHCI on shutdown
@ 2013-12-19 16:29 Denis Turischev
2014-02-04 11:10 ` [PATCH] " Denis Turischev
0 siblings, 1 reply; 8+ messages in thread
From: Denis Turischev @ 2013-12-19 16:29 UTC (permalink / raw)
To: Sarah Sharp; +Cc: linux-kernel, linux-usb
The same issue like with Panther Point chipsets. If the USB ports are
switched to xHCI on shutdown, the xHCI host will send a spurious interrupt,
which will wake the system. Some BIOS have work around for this, but not all.
The bug can be avoided if the USB ports are switched back to EHCI on
shutdown.
Signed-off-by: Denis Turischev <denis@compulab.co.il>
diff --git a/drivers/usb/host/xhci-pci.c b/drivers/usb/host/xhci-pci.c
--- a/drivers/usb/host/xhci-pci.c 2013-12-19 11:36:12.049589400 +0200
+++ b/drivers/usb/host/xhci-pci.c 2013-12-19 11:37:27.261590385 +0200
@@ -91,8 +91,9 @@
xhci->quirks |= XHCI_LPM_SUPPORT;
xhci->quirks |= XHCI_INTEL_HOST;
}
- if (pdev->vendor == PCI_VENDOR_ID_INTEL &&
- pdev->device == PCI_DEVICE_ID_INTEL_PANTHERPOINT_XHCI) {
+ if (pdev->vendor == PCI_VENDOR_ID_INTEL && (
+ (pdev->device == PCI_DEVICE_ID_INTEL_PANTHERPOINT_XHCI) ||
+ (pdev->device == PCI_DEVICE_ID_INTEL_LYNXPOINT_XHCI))) {
xhci->quirks |= XHCI_EP_LIMIT_QUIRK;
xhci->limit_active_eps = 64;
xhci->quirks |= XHCI_SW_BW_CHECKING;
diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h
--- a/include/linux/pci_ids.h 2013-12-19 11:36:11.945589398 +0200
+++ b/include/linux/pci_ids.h 2013-12-19 11:35:57.817589213 +0200
@@ -2576,6 +2576,7 @@
#define PCI_DEVICE_ID_INTEL_COUGARPOINT_LPC_MAX 0x1c5f
#define PCI_DEVICE_ID_INTEL_PATSBURG_LPC_0 0x1d40
#define PCI_DEVICE_ID_INTEL_PATSBURG_LPC_1 0x1d41
+#define PCI_DEVICE_ID_INTEL_LYNXPOINT_XHCI 0x9c31
#define PCI_DEVICE_ID_INTEL_PANTHERPOINT_XHCI 0x1e31
#define PCI_DEVICE_ID_INTEL_PANTHERPOINT_LPC_MIN 0x1e40
#define PCI_DEVICE_ID_INTEL_PANTHERPOINT_LPC_MAX 0x1e5f
^ permalink raw reply [flat|nested] 8+ messages in thread* [PATCH] xhci: Switch Intel Lynx Point ports to EHCI on shutdown.
2013-12-19 16:29 Denis Turischev
@ 2014-02-04 11:10 ` Denis Turischev
2014-02-18 7:42 ` [RESEND] " Denis Turischev
0 siblings, 1 reply; 8+ messages in thread
From: Denis Turischev @ 2014-02-04 11:10 UTC (permalink / raw)
To: Sarah Sharp; +Cc: linux-kernel, linux-usb
The same issue like with Panther Point chipsets. If the USB ports are
switched to xHCI on shutdown, the xHCI host will send a spurious interrupt,
which will wake the system. Some BIOS have work around for this, but not all.
One example is Compulab's mini-desktop, the Intense-PC2.
The bug can be avoided if the USB ports are switched back to EHCI on
shutdown.
Signed-off-by: Denis Turischev <denis@compulab.co.il>
---
drivers/usb/host/xhci-pci.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/usb/host/xhci-pci.c b/drivers/usb/host/xhci-pci.c
index 3c898c1..9233d12 100644
--- a/drivers/usb/host/xhci-pci.c
+++ b/drivers/usb/host/xhci-pci.c
@@ -134,6 +134,8 @@ static void xhci_pci_quirks(struct device *dev, struct xhci_hcd *xhci)
*/
if (pdev->subsystem_vendor == PCI_VENDOR_ID_HP)
xhci->quirks |= XHCI_SPURIOUS_WAKEUP;
+
+ xhci->quirks |= XHCI_SPURIOUS_REBOOT;
}
if (pdev->vendor == PCI_VENDOR_ID_ETRON &&
pdev->device == PCI_DEVICE_ID_ASROCK_P67) {
--
1.8.1.2
^ permalink raw reply related [flat|nested] 8+ messages in thread* [RESEND] [PATCH] xhci: Switch Intel Lynx Point ports to EHCI on shutdown.
2014-02-04 11:10 ` [PATCH] " Denis Turischev
@ 2014-02-18 7:42 ` Denis Turischev
2014-02-18 18:54 ` Sarah Sharp
0 siblings, 1 reply; 8+ messages in thread
From: Denis Turischev @ 2014-02-18 7:42 UTC (permalink / raw)
To: Sarah Sharp; +Cc: linux-kernel, linux-usb, Greg Kroah-Hartman
The same issue like with Panther Point chipsets. If the USB ports are
switched to xHCI on shutdown, the xHCI host will send a spurious interrupt,
which will wake the system. Some BIOS have work around for this, but not all.
One example is Compulab's mini-desktop, the Intense-PC2.
The bug can be avoided if the USB ports are switched back to EHCI on
shutdown.
Signed-off-by: Denis Turischev <denis@compulab.co.il>
---
drivers/usb/host/xhci-pci.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/usb/host/xhci-pci.c b/drivers/usb/host/xhci-pci.c
index 3c898c1..9233d12 100644
--- a/drivers/usb/host/xhci-pci.c
+++ b/drivers/usb/host/xhci-pci.c
@@ -134,6 +134,8 @@ static void xhci_pci_quirks(struct device *dev, struct xhci_hcd *xhci)
*/
if (pdev->subsystem_vendor == PCI_VENDOR_ID_HP)
xhci->quirks |= XHCI_SPURIOUS_WAKEUP;
+
+ xhci->quirks |= XHCI_SPURIOUS_REBOOT;
}
if (pdev->vendor == PCI_VENDOR_ID_ETRON &&
pdev->device == PCI_DEVICE_ID_ASROCK_P67) {
-- 1.8.1.2
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [RESEND] [PATCH] xhci: Switch Intel Lynx Point ports to EHCI on shutdown.
2014-02-18 7:42 ` [RESEND] " Denis Turischev
@ 2014-02-18 18:54 ` Sarah Sharp
0 siblings, 0 replies; 8+ messages in thread
From: Sarah Sharp @ 2014-02-18 18:54 UTC (permalink / raw)
To: Denis Turischev; +Cc: linux-kernel, linux-usb, Greg Kroah-Hartman
Sorry for the delay in reviewing this. It helps me if you don't make the
patch in-reply-to a months old thread. :) I'll take a look at this
shortly.
Sarah Sharp
On Tue, Feb 18, 2014 at 09:42:39AM +0200, Denis Turischev wrote:
> The same issue like with Panther Point chipsets. If the USB ports are
> switched to xHCI on shutdown, the xHCI host will send a spurious interrupt,
> which will wake the system. Some BIOS have work around for this, but not all.
> One example is Compulab's mini-desktop, the Intense-PC2.
>
> The bug can be avoided if the USB ports are switched back to EHCI on
> shutdown.
>
> Signed-off-by: Denis Turischev <denis@compulab.co.il>
> ---
> drivers/usb/host/xhci-pci.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/usb/host/xhci-pci.c b/drivers/usb/host/xhci-pci.c
> index 3c898c1..9233d12 100644
> --- a/drivers/usb/host/xhci-pci.c
> +++ b/drivers/usb/host/xhci-pci.c
> @@ -134,6 +134,8 @@ static void xhci_pci_quirks(struct device *dev, struct xhci_hcd *xhci)
> */
> if (pdev->subsystem_vendor == PCI_VENDOR_ID_HP)
> xhci->quirks |= XHCI_SPURIOUS_WAKEUP;
> +
> + xhci->quirks |= XHCI_SPURIOUS_REBOOT;
> }
> if (pdev->vendor == PCI_VENDOR_ID_ETRON &&
> pdev->device == PCI_DEVICE_ID_ASROCK_P67) {
> -- 1.8.1.2
>
>
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2014-04-22 12:15 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-03-21 10:01 [RESEND] [PATCH] xhci: Switch Intel Lynx Point ports to EHCI on shutdown Denis Turischev
2014-03-21 12:10 ` Mathias Nyman
2014-04-22 11:04 ` Denis Turischev
2014-04-22 12:26 ` Mathias Nyman
-- strict thread matches above, loose matches on Subject: below --
2014-03-09 12:43 Denis Turischev
2014-03-07 9:40 Denis Turischev
2013-12-19 16:29 Denis Turischev
2014-02-04 11:10 ` [PATCH] " Denis Turischev
2014-02-18 7:42 ` [RESEND] " Denis Turischev
2014-02-18 18:54 ` Sarah Sharp
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.