All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sasha Levin <sasha.levin@oracle.com>
To: Andrew Morton <akpm@linux-foundation.org>, Mel Gorman <mgorman@suse.de>
Cc: Rik van Riel <riel@redhat.com>,
	David Rientjes <rientjes@google.com>,
	hhuang@redhat.com, knoel@redhat.com, aarcange@redhat.com,
	Davidlohr Bueso <davidlohr@hp.com>,
	"linux-mm@kvack.org" <linux-mm@kvack.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mm: numa: Recheck for transhuge pages under lock during protection changes
Date: Fri, 21 Mar 2014 18:36:56 -0400	[thread overview]
Message-ID: <532CBF08.4030100@oracle.com> (raw)
In-Reply-To: <20140321150658.386926ac3afa263946b1a2aa@linux-foundation.org>

On 03/21/2014 06:06 PM, Andrew Morton wrote:
> On Wed, 19 Mar 2014 14:38:32 +0000 Mel Gorman<mgorman@suse.de>  wrote:
>
>> >On Fri, Mar 14, 2014 at 11:15:37PM -0400, Sasha Levin wrote:
>>> > >On 03/12/2014 06:36 AM, Mel Gorman wrote:
>>>> > > >Andrew, this should go with the patches
>>>> > > >mmnuma-reorganize-change_pmd_range.patch
>>>> > > >mmnuma-reorganize-change_pmd_range-fix.patch
>>>> > > >move-mmu-notifier-call-from-change_protection-to-change_pmd_range.patch
>>>> > > >in mmotm please.
>>>> > > >
>>>> > > >Thanks.
>>>> > > >
>>>> > > >---8<---
>>>> > > >From: Mel Gorman<mgorman@suse.de>
>>>> > > >Subject: [PATCH] mm: numa: Recheck for transhuge pages under lock during protection changes
>>>> > > >
>>>> > > >Sasha Levin reported the following bug using trinity
>>> > >
>>> > >I'm seeing a different issue with this patch. A NULL ptr deref occurs in the
>>> > >pte_offset_map_lock() macro right before the new recheck code:
>>> > >
>> >
>> >This on top?
>> >
>> >I tried testing it but got all sorts of carnage that trinity throw up
>> >in the mix and ordinary testing does not trigger the race. I've no idea
>> >which of the current mess of trinity-exposed bugs you've encountered and
>> >got fixed already.
>> >
> Where are we at with this one?

Looking good here, haven't seen any of the issues reported in this thread.


Thanks,
Sasha

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Sasha Levin <sasha.levin@oracle.com>
To: Andrew Morton <akpm@linux-foundation.org>, Mel Gorman <mgorman@suse.de>
Cc: Rik van Riel <riel@redhat.com>,
	David Rientjes <rientjes@google.com>,
	hhuang@redhat.com, knoel@redhat.com, aarcange@redhat.com,
	Davidlohr Bueso <davidlohr@hp.com>,
	"linux-mm@kvack.org" <linux-mm@kvack.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mm: numa: Recheck for transhuge pages under lock during protection changes
Date: Fri, 21 Mar 2014 18:36:56 -0400	[thread overview]
Message-ID: <532CBF08.4030100@oracle.com> (raw)
In-Reply-To: <20140321150658.386926ac3afa263946b1a2aa@linux-foundation.org>

On 03/21/2014 06:06 PM, Andrew Morton wrote:
> On Wed, 19 Mar 2014 14:38:32 +0000 Mel Gorman<mgorman@suse.de>  wrote:
>
>> >On Fri, Mar 14, 2014 at 11:15:37PM -0400, Sasha Levin wrote:
>>> > >On 03/12/2014 06:36 AM, Mel Gorman wrote:
>>>> > > >Andrew, this should go with the patches
>>>> > > >mmnuma-reorganize-change_pmd_range.patch
>>>> > > >mmnuma-reorganize-change_pmd_range-fix.patch
>>>> > > >move-mmu-notifier-call-from-change_protection-to-change_pmd_range.patch
>>>> > > >in mmotm please.
>>>> > > >
>>>> > > >Thanks.
>>>> > > >
>>>> > > >---8<---
>>>> > > >From: Mel Gorman<mgorman@suse.de>
>>>> > > >Subject: [PATCH] mm: numa: Recheck for transhuge pages under lock during protection changes
>>>> > > >
>>>> > > >Sasha Levin reported the following bug using trinity
>>> > >
>>> > >I'm seeing a different issue with this patch. A NULL ptr deref occurs in the
>>> > >pte_offset_map_lock() macro right before the new recheck code:
>>> > >
>> >
>> >This on top?
>> >
>> >I tried testing it but got all sorts of carnage that trinity throw up
>> >in the mix and ordinary testing does not trigger the race. I've no idea
>> >which of the current mess of trinity-exposed bugs you've encountered and
>> >got fixed already.
>> >
> Where are we at with this one?

Looking good here, haven't seen any of the issues reported in this thread.


Thanks,
Sasha

  reply	other threads:[~2014-03-21 22:37 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-06 21:12 mm: kernel BUG at mm/mprotect.c:149 Sasha Levin
2014-03-06 21:12 ` Sasha Levin
2014-03-06 22:31 ` [PATCH -mm] mm,numa,mprotect: always continue after finding a stable thp page Rik van Riel
2014-03-06 22:31   ` Rik van Riel
2014-03-06 22:31 ` Rik van Riel
2014-03-06 22:31   ` Rik van Riel
2014-03-06 22:52   ` Rik van Riel
2014-03-06 22:52     ` Rik van Riel
2014-03-07 14:06     ` Mel Gorman
2014-03-07 14:06       ` Mel Gorman
2014-03-07 15:09       ` Mel Gorman
2014-03-07 15:09         ` Mel Gorman
2014-03-07 15:13         ` Mel Gorman
2014-03-07 15:13           ` Mel Gorman
2014-03-07 18:27         ` Mel Gorman
2014-03-07 18:27           ` Mel Gorman
2014-03-11 16:28           ` Mel Gorman
2014-03-11 16:28             ` Mel Gorman
2014-03-11 16:51             ` Sasha Levin
2014-03-11 16:51               ` Sasha Levin
2014-03-11 17:00               ` Rik van Riel
2014-03-11 17:00                 ` Rik van Riel
2014-03-11 17:33                 ` Sasha Levin
2014-03-11 17:33                   ` Sasha Levin
2014-03-11 17:32                   ` Rik van Riel
2014-03-11 17:32                     ` Rik van Riel
2014-03-11 18:06                   ` Mel Gorman
2014-03-11 18:06                     ` Mel Gorman
2014-03-11 19:18                     ` Sasha Levin
2014-03-11 19:18                       ` Sasha Levin
2014-03-11 19:28                       ` Andrew Morton
2014-03-11 19:28                         ` Andrew Morton
2014-03-11 19:33                         ` Sasha Levin
2014-03-11 19:33                           ` Sasha Levin
2014-03-12 10:36                         ` [PATCH] mm: numa: Recheck for transhuge pages under lock during protection changes Mel Gorman
2014-03-12 10:36                           ` Mel Gorman
2014-03-12 12:16                           ` Rik van Riel
2014-03-12 12:16                             ` Rik van Riel
2014-03-15  3:15                           ` Sasha Levin
2014-03-15  3:15                             ` Sasha Levin
2014-03-19 14:38                             ` Mel Gorman
2014-03-19 14:38                               ` Mel Gorman
2014-03-21 22:06                               ` Andrew Morton
2014-03-21 22:06                                 ` Andrew Morton
2014-03-21 22:36                                 ` Sasha Levin [this message]
2014-03-21 22:36                                   ` Sasha Levin
2014-03-21 22:24                               ` Rik van Riel
2014-03-21 22:24                                 ` Rik van Riel
2014-03-11 19:31                     ` [PATCH -mm] mm,numa,mprotect: always continue after finding a stable thp page Davidlohr Bueso
2014-03-11 19:31                       ` Davidlohr Bueso
2014-03-07  1:04   ` Sasha Levin
2014-03-07  1:04     ` Sasha Levin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=532CBF08.4030100@oracle.com \
    --to=sasha.levin@oracle.com \
    --cc=aarcange@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=davidlohr@hp.com \
    --cc=hhuang@redhat.com \
    --cc=knoel@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mgorman@suse.de \
    --cc=riel@redhat.com \
    --cc=rientjes@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.