From: sdu.liu@huawei.com (Liu hua)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: kdump: Avoid overflow when converting pfn to physaddr
Date: Sat, 22 Mar 2014 13:14:43 +0800 [thread overview]
Message-ID: <532D1C43.4070206@huawei.com> (raw)
In-Reply-To: <20140318104855.GU21483@n2100.arm.linux.org.uk>
On 2014/3/18 18:48, Russell King - ARM Linux wrote:
> On Tue, Mar 18, 2014 at 06:20:42PM +0800, Liu Hua wrote:
>> When we configure CONFIG_LPAE=y, pfn << PAGE_SHIFT will
>> overflow if pfn >= 0x100000 in copy_oldmem_page.
>>
>> So use __pfn_to_phys for converting.
>
> Yes. The sad thing is that if you grep the kernel for similar things,
> it's littered with this problem. I'm not sure whether anyone
> particularly "owns" the crash_dump.c file - Mika Westerberg and
> Olaf Hering were the last two to touch it... I guess put this in my
> patch system please.
>
> Thanks.
>
Yes, I found this problem in serval places after a quick review. I will
do a check on this.
WARNING: multiple messages have this Message-ID (diff)
From: Liu hua <sdu.liu@huawei.com>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: <wangnan0@huawei.com>, <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>, <peifeiyue@huawei.com>
Subject: Re: [PATCH] ARM: kdump: Avoid overflow when converting pfn to physaddr
Date: Sat, 22 Mar 2014 13:14:43 +0800 [thread overview]
Message-ID: <532D1C43.4070206@huawei.com> (raw)
In-Reply-To: <20140318104855.GU21483@n2100.arm.linux.org.uk>
On 2014/3/18 18:48, Russell King - ARM Linux wrote:
> On Tue, Mar 18, 2014 at 06:20:42PM +0800, Liu Hua wrote:
>> When we configure CONFIG_LPAE=y, pfn << PAGE_SHIFT will
>> overflow if pfn >= 0x100000 in copy_oldmem_page.
>>
>> So use __pfn_to_phys for converting.
>
> Yes. The sad thing is that if you grep the kernel for similar things,
> it's littered with this problem. I'm not sure whether anyone
> particularly "owns" the crash_dump.c file - Mika Westerberg and
> Olaf Hering were the last two to touch it... I guess put this in my
> patch system please.
>
> Thanks.
>
Yes, I found this problem in serval places after a quick review. I will
do a check on this.
next prev parent reply other threads:[~2014-03-22 5:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-18 10:20 [PATCH] ARM: kdump: Avoid overflow when converting pfn to physaddr Liu Hua
2014-03-18 10:20 ` Liu Hua
2014-03-18 10:48 ` Russell King - ARM Linux
2014-03-18 10:48 ` Russell King - ARM Linux
2014-03-22 5:14 ` Liu hua [this message]
2014-03-22 5:14 ` Liu hua
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=532D1C43.4070206@huawei.com \
--to=sdu.liu@huawei.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.