From: Mathias Nyman <mathias.nyman@linux.intel.com>
To: Anurag Kumar Vulisha <anurag.kumar.vulisha@xilinx.com>,
mathias.nyman@intel.com, gregkh@linuxfoundation.org
Cc: v.anuragkumar@gmail.com, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [v3] usb: host: xhci-plat: Iterate over parent nodes for finding quirks
Date: Mon, 6 Aug 2018 16:58:40 +0300 [thread overview]
Message-ID: <532f004d-8a79-e61b-e668-958c162599aa@linux.intel.com> (raw)
On 06.08.2018 16:04, Anurag Kumar Vulisha wrote:
> In xhci_plat_probe() both sysdev and pdev->dev are being used
> for finding quirks. There are some drivers(like dwc3 host.c)
> which adds quirks(like usb3-lpm-capable) into pdev and the logic
> present in xhci_plat_probe() checks for quirks in either sysdev
> or pdev for finding the quirks. Because of this logic, some of
> the quirks are getting missed(usb3-lpm-capable quirk added by dwc3
> host.c driver is getting missed).This patch fixes this by iterating
> over all the available parents for finding the quirks. In this way
> all the quirks which are present in child or parent are correctly
> updated.
>
> Signed-off-by: Anurag Kumar Vulisha <anurag.kumar.vulisha@xilinx.com>
> ---
> Changes in v3:
> 1. As Mathias suggested, moved the position of reading devicetree
> property "imod-interval-ns" into for loop
>
> Changes in v2:
> 1. As suggested by Mathias, restoring immod_interval changes to
> default
> ---
Thanks, adding to queue
-Mathias
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Mathias Nyman <mathias.nyman@linux.intel.com>
To: Anurag Kumar Vulisha <anurag.kumar.vulisha@xilinx.com>,
mathias.nyman@intel.com, gregkh@linuxfoundation.org
Cc: v.anuragkumar@gmail.com, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] usb: host: xhci-plat: Iterate over parent nodes for finding quirks
Date: Mon, 6 Aug 2018 16:58:40 +0300 [thread overview]
Message-ID: <532f004d-8a79-e61b-e668-958c162599aa@linux.intel.com> (raw)
In-Reply-To: <1533560671-32640-1-git-send-email-anurag.kumar.vulisha@xilinx.com>
On 06.08.2018 16:04, Anurag Kumar Vulisha wrote:
> In xhci_plat_probe() both sysdev and pdev->dev are being used
> for finding quirks. There are some drivers(like dwc3 host.c)
> which adds quirks(like usb3-lpm-capable) into pdev and the logic
> present in xhci_plat_probe() checks for quirks in either sysdev
> or pdev for finding the quirks. Because of this logic, some of
> the quirks are getting missed(usb3-lpm-capable quirk added by dwc3
> host.c driver is getting missed).This patch fixes this by iterating
> over all the available parents for finding the quirks. In this way
> all the quirks which are present in child or parent are correctly
> updated.
>
> Signed-off-by: Anurag Kumar Vulisha <anurag.kumar.vulisha@xilinx.com>
> ---
> Changes in v3:
> 1. As Mathias suggested, moved the position of reading devicetree
> property "imod-interval-ns" into for loop
>
> Changes in v2:
> 1. As suggested by Mathias, restoring immod_interval changes to
> default
> ---
Thanks, adding to queue
-Mathias
next reply other threads:[~2018-08-06 13:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-06 13:58 Mathias Nyman [this message]
2018-08-06 13:58 ` [PATCH v3] usb: host: xhci-plat: Iterate over parent nodes for finding quirks Mathias Nyman
-- strict thread matches above, loose matches on Subject: below --
2018-08-06 14:05 [v3] " Anurag Kumar Vulisha
2018-08-06 14:05 ` [PATCH v3] " Anurag Kumar Vulisha
2018-08-06 13:04 [v3] " Anurag Kumar Vulisha
2018-08-06 13:04 ` [PATCH v3] " Anurag Kumar Vulisha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=532f004d-8a79-e61b-e668-958c162599aa@linux.intel.com \
--to=mathias.nyman@linux.intel.com \
--cc=anurag.kumar.vulisha@xilinx.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
--cc=v.anuragkumar@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.