All of lore.kernel.org
 help / color / mirror / Atom feed
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH RESEND net-next 2/3] dts: hisi: fixes no syscon error when init mdio
Date: Sat, 05 Dec 2015 23:15:07 +0100	[thread overview]
Message-ID: <5330584.WSWh7F8G32@wuerfel> (raw)
In-Reply-To: <1449302218-54374-3-git-send-email-yankejian@huawei.com>

On Saturday 05 December 2015 15:56:57 yankejian wrote:
>                 #size-cells = <0>;
>                 compatible = "hisilicon,hns-mdio";
> -               reg = <0x0 0x803c0000 0x0 0x10000
> -                      0x0 0x80000000 0x0 0x10000>;
> +               reg = <0x0 0x803c0000 0x0 0x10000>;
> +               subctrl_vbase = <&peri_c_subctrl>;
>  
>                 soc0_phy0: ethernet-phy at 0 {
>                         reg = <0x0>;

I don't see the subctrl_vbase property documented in the binding. Please
modify the binding as well.

Also, please use the normal naming conventions using '-' instead of '_'
inside of property names.

	Arnd

WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
To: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Cc: yankejian <yankejian-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>,
	davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org,
	robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
	pawel.moll-5wv7dgnIgG8@public.gmane.org,
	mark.rutland-5wv7dgnIgG8@public.gmane.org,
	ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org,
	galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org,
	xuwei5-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org,
	catalin.marinas-5wv7dgnIgG8@public.gmane.org,
	will.deacon-5wv7dgnIgG8@public.gmane.org,
	wangkefeng.wang-hv44wF8Li93QT0dZR+AlfA@public.gmane.org,
	dingtianhong-hv44wF8Li93QT0dZR+AlfA@public.gmane.org,
	liguozhu-hv44wF8Li93QT0dZR+AlfA@public.gmane.org,
	Yisen.Zhuang-hv44wF8Li93QT0dZR+AlfA@public.gmane.org,
	sboyd-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org,
	haojian.zhuang-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
	wangzhou1-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org,
	bintian.wang-hv44wF8Li93QT0dZR+AlfA@public.gmane.org,
	long.wanglong-hv44wF8Li93QT0dZR+AlfA@public.gmane.org,
	leo.yan-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	haifeng.wei-hv44wF8Li93QT0dZR+AlfA@public.gmane.org,
	netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linuxarm-hv44wF8Li93QT0dZR+AlfA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH RESEND net-next 2/3] dts: hisi: fixes no syscon error when init mdio
Date: Sat, 05 Dec 2015 23:15:07 +0100	[thread overview]
Message-ID: <5330584.WSWh7F8G32@wuerfel> (raw)
In-Reply-To: <1449302218-54374-3-git-send-email-yankejian-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>

On Saturday 05 December 2015 15:56:57 yankejian wrote:
>                 #size-cells = <0>;
>                 compatible = "hisilicon,hns-mdio";
> -               reg = <0x0 0x803c0000 0x0 0x10000
> -                      0x0 0x80000000 0x0 0x10000>;
> +               reg = <0x0 0x803c0000 0x0 0x10000>;
> +               subctrl_vbase = <&peri_c_subctrl>;
>  
>                 soc0_phy0: ethernet-phy@0 {
>                         reg = <0x0>;

I don't see the subctrl_vbase property documented in the binding. Please
modify the binding as well.

Also, please use the normal naming conventions using '-' instead of '_'
inside of property names.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: yankejian <yankejian@huawei.com>,
	davem@davemloft.net, robh+dt@kernel.org, pawel.moll@arm.com,
	mark.rutland@arm.com, ijc+devicetree@hellion.org.uk,
	galak@codeaurora.org, xuwei5@hisilicon.com,
	catalin.marinas@arm.com, will.deacon@arm.com,
	wangkefeng.wang@huawei.com, dingtianhong@huawei.com,
	liguozhu@huawei.com, Yisen.Zhuang@huawei.com,
	sboyd@codeaurora.org, haojian.zhuang@linaro.org,
	wangzhou1@hisilicon.com, bintian.wang@huawei.com,
	long.wanglong@huawei.com, leo.yan@linaro.org,
	devicetree@vger.kernel.org, haifeng.wei@huawei.com,
	netdev@vger.kernel.org, linuxarm@huawei.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH RESEND net-next 2/3] dts: hisi: fixes no syscon error when init mdio
Date: Sat, 05 Dec 2015 23:15:07 +0100	[thread overview]
Message-ID: <5330584.WSWh7F8G32@wuerfel> (raw)
In-Reply-To: <1449302218-54374-3-git-send-email-yankejian@huawei.com>

On Saturday 05 December 2015 15:56:57 yankejian wrote:
>                 #size-cells = <0>;
>                 compatible = "hisilicon,hns-mdio";
> -               reg = <0x0 0x803c0000 0x0 0x10000
> -                      0x0 0x80000000 0x0 0x10000>;
> +               reg = <0x0 0x803c0000 0x0 0x10000>;
> +               subctrl_vbase = <&peri_c_subctrl>;
>  
>                 soc0_phy0: ethernet-phy@0 {
>                         reg = <0x0>;

I don't see the subctrl_vbase property documented in the binding. Please
modify the binding as well.

Also, please use the normal naming conventions using '-' instead of '_'
inside of property names.

	Arnd

  reply	other threads:[~2015-12-05 22:15 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-05  7:56 [PATCH RESEND net-next 0/3] dts: hisi: fixes can't find eth for hip05-D02 yankejian
2015-12-05  7:56 ` yankejian
2015-12-05  7:56 ` yankejian
2015-12-05  7:56 ` [PATCH RESEND net-next 1/3] dts: hisi: enables the ethX for D02 board yankejian
2015-12-05  7:56   ` yankejian
2015-12-05  7:56   ` yankejian
2015-12-05  7:56   ` yankejian
2015-12-05 12:53   ` kbuild test robot
2015-12-05 12:53     ` kbuild test robot
2015-12-05  7:56 ` [PATCH RESEND net-next 2/3] dts: hisi: fixes no syscon error when init mdio yankejian
2015-12-05  7:56   ` yankejian
2015-12-05  7:56   ` yankejian
2015-12-05 22:15   ` Arnd Bergmann [this message]
2015-12-05 22:15     ` Arnd Bergmann
2015-12-05 22:15     ` Arnd Bergmann
2015-12-07  1:30     ` Yankejian (Hackim Yim)
2015-12-07  1:30       ` Yankejian (Hackim Yim)
2015-12-07  1:30       ` Yankejian (Hackim Yim)
2015-12-07  1:30       ` Yankejian (Hackim Yim)
2015-12-05  7:56 ` [PATCH RESEND net-next 3/3] arm64: hip05-d02: Document devicetree bindings for Hisilicon D02 Board yankejian
2015-12-05  7:56   ` yankejian
2015-12-05  7:56   ` yankejian
2015-12-05  7:56   ` yankejian
2015-12-05 22:13   ` Arnd Bergmann
2015-12-05 22:13     ` Arnd Bergmann
2015-12-05 22:13     ` Arnd Bergmann
2015-12-07  1:29     ` Yankejian (Hackim Yim)
2015-12-07  1:29       ` Yankejian (Hackim Yim)
2015-12-07  1:29       ` Yankejian (Hackim Yim)
  -- strict thread matches above, loose matches on Subject: below --
2015-12-05  7:54 [PATCH RESEND net-next 0/3] dts: hisi: fixes can't find eth for hip05-D02 yankejian
2015-12-05  7:54 ` [PATCH RESEND net-next 2/3] dts: hisi: fixes no syscon error when init mdio yankejian
2015-12-05  7:54   ` yankejian
2015-12-05  7:54   ` yankejian

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5330584.WSWh7F8G32@wuerfel \
    --to=arnd@arndb.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.