All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ben Greear <greearb@candelatech.com>
To: Janusz Dziedzic <janusz.dziedzic@tieto.com>
Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org
Subject: Re: [PATCH v2 2/2] ath10k: fix rssi and rate reporting
Date: Mon, 24 Mar 2014 15:20:54 -0700	[thread overview]
Message-ID: <5330AFC6.60205@candelatech.com> (raw)
In-Reply-To: <1395692698-4745-2-git-send-email-janusz.dziedzic@tieto.com>

On 03/24/2014 01:24 PM, Janusz Dziedzic wrote:
> RSSI and RATES fields are valid only when START_VALID
> bit is set. So, in current implementation we have to
> remember/caclulate them when START_VALID and report the same
> when only END_VALID is set.
> Currently during heavy traffic we could have:
> - 10 packets with START_VALID - correct RSSI and RATES
> - 10 packets with END_VALID
> - 10 packets with START_VALID - correct RSSI and RATES
> - 10 packets with END_VALID

I applied all 8 of these patches to my tree, and it does fix the problems I saw with
rx-rate and signal being broken (perhaps because I am using raw rx mode for
my stations).

I'll leave these in my tree and will let you know if I see any
problems that might be related to them.

Thanks,
Ben

-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com


_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

WARNING: multiple messages have this Message-ID (diff)
From: Ben Greear <greearb@candelatech.com>
To: Janusz Dziedzic <janusz.dziedzic@tieto.com>
Cc: ath10k@lists.infradead.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCH v2 2/2] ath10k: fix rssi and rate reporting
Date: Mon, 24 Mar 2014 15:20:54 -0700	[thread overview]
Message-ID: <5330AFC6.60205@candelatech.com> (raw)
In-Reply-To: <1395692698-4745-2-git-send-email-janusz.dziedzic@tieto.com>

On 03/24/2014 01:24 PM, Janusz Dziedzic wrote:
> RSSI and RATES fields are valid only when START_VALID
> bit is set. So, in current implementation we have to
> remember/caclulate them when START_VALID and report the same
> when only END_VALID is set.
> Currently during heavy traffic we could have:
> - 10 packets with START_VALID - correct RSSI and RATES
> - 10 packets with END_VALID
> - 10 packets with START_VALID - correct RSSI and RATES
> - 10 packets with END_VALID

I applied all 8 of these patches to my tree, and it does fix the problems I saw with
rx-rate and signal being broken (perhaps because I am using raw rx mode for
my stations).

I'll leave these in my tree and will let you know if I see any
problems that might be related to them.

Thanks,
Ben

-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com


  reply	other threads:[~2014-03-24 22:21 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-24 20:24 [PATCH v2 1/2] ath10k: introduce rx_status htt template Janusz Dziedzic
2014-03-24 20:24 ` Janusz Dziedzic
2014-03-24 20:24 ` [PATCH v2 2/2] ath10k: fix rssi and rate reporting Janusz Dziedzic
2014-03-24 20:24   ` Janusz Dziedzic
2014-03-24 22:20   ` Ben Greear [this message]
2014-03-24 22:20     ` Ben Greear
2014-05-15 17:24   ` Ben Greear
2014-05-15 17:24     ` Ben Greear
2014-05-16  6:45     ` Janusz Dziedzic
2014-05-16  6:45       ` Janusz Dziedzic
2014-03-25 12:16 ` [PATCH v2 1/2] ath10k: introduce rx_status htt template Kalle Valo
2014-03-25 12:16   ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5330AFC6.60205@candelatech.com \
    --to=greearb@candelatech.com \
    --cc=ath10k@lists.infradead.org \
    --cc=janusz.dziedzic@tieto.com \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.