All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bo Shen <voice.shen@atmel.com>
To: Mark Brown <broonie@kernel.org>
Cc: mark.rutland@arm.com, alsa-devel@alsa-project.org,
	b.brezillon.dev@gmail.com, nicolas.ferre@atmel.com,
	linux-sound@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [alsa-devel] [RFC v2 PATCH] ASoC: wm8904: add CCF support
Date: Wed, 26 Mar 2014 09:32:25 +0800	[thread overview]
Message-ID: <53322E29.3070000@atmel.com> (raw)
In-Reply-To: <20140325112716.GS2269@sirena.org.uk>

Hi Mark,

On 03/25/2014 07:27 PM, Mark Brown wrote:
> On Tue, Mar 25, 2014 at 05:56:56PM +0800, Bo Shen wrote:
>
>>   	case SND_SOC_BIAS_ON:
>> +		if (IS_ENABLED(CONFIG_COMMON_CLK))
>> +			if (wm8904->mclk)
>> +				clk_prepare_enable(wm8904->mclk);
>
> No, this shouldn't depend on COMMON_CLK - there is no reason other clock
> API implementations shouldn't be able to use this.  Providing a clock is
> something you can only do with COMMON_CLK but using one doesn't need
> that, generally using a clock is done unconditionally.

Actually in probe function, it does this check, if not CCF support, the 
wm8904->mclk is NULL. So, we can remove the CCF check here.

Thanks.

Best Regards,
Bo Shen

WARNING: multiple messages have this Message-ID (diff)
From: Bo Shen <voice.shen@atmel.com>
To: Mark Brown <broonie@kernel.org>
Cc: mark.rutland@arm.com, alsa-devel@alsa-project.org,
	b.brezillon.dev@gmail.com, nicolas.ferre@atmel.com,
	linux-sound@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [alsa-devel] [RFC v2 PATCH] ASoC: wm8904: add CCF support
Date: Wed, 26 Mar 2014 01:32:25 +0000	[thread overview]
Message-ID: <53322E29.3070000@atmel.com> (raw)
In-Reply-To: <20140325112716.GS2269@sirena.org.uk>

Hi Mark,

On 03/25/2014 07:27 PM, Mark Brown wrote:
> On Tue, Mar 25, 2014 at 05:56:56PM +0800, Bo Shen wrote:
>
>>   	case SND_SOC_BIAS_ON:
>> +		if (IS_ENABLED(CONFIG_COMMON_CLK))
>> +			if (wm8904->mclk)
>> +				clk_prepare_enable(wm8904->mclk);
>
> No, this shouldn't depend on COMMON_CLK - there is no reason other clock
> API implementations shouldn't be able to use this.  Providing a clock is
> something you can only do with COMMON_CLK but using one doesn't need
> that, generally using a clock is done unconditionally.

Actually in probe function, it does this check, if not CCF support, the 
wm8904->mclk is NULL. So, we can remove the CCF check here.

Thanks.

Best Regards,
Bo Shen

WARNING: multiple messages have this Message-ID (diff)
From: voice.shen@atmel.com (Bo Shen)
To: linux-arm-kernel@lists.infradead.org
Subject: [alsa-devel] [RFC v2 PATCH] ASoC: wm8904: add CCF support
Date: Wed, 26 Mar 2014 09:32:25 +0800	[thread overview]
Message-ID: <53322E29.3070000@atmel.com> (raw)
In-Reply-To: <20140325112716.GS2269@sirena.org.uk>

Hi Mark,

On 03/25/2014 07:27 PM, Mark Brown wrote:
> On Tue, Mar 25, 2014 at 05:56:56PM +0800, Bo Shen wrote:
>
>>   	case SND_SOC_BIAS_ON:
>> +		if (IS_ENABLED(CONFIG_COMMON_CLK))
>> +			if (wm8904->mclk)
>> +				clk_prepare_enable(wm8904->mclk);
>
> No, this shouldn't depend on COMMON_CLK - there is no reason other clock
> API implementations shouldn't be able to use this.  Providing a clock is
> something you can only do with COMMON_CLK but using one doesn't need
> that, generally using a clock is done unconditionally.

Actually in probe function, it does this check, if not CCF support, the 
wm8904->mclk is NULL. So, we can remove the CCF check here.

Thanks.

Best Regards,
Bo Shen

  reply	other threads:[~2014-03-26  1:32 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-25  9:56 [RFC v2 PATCH] ASoC: wm8904: add CCF support Bo Shen
2014-03-25  9:56 ` Bo Shen
2014-03-25  9:56 ` Bo Shen
2014-03-25 11:27 ` Mark Brown
2014-03-25 11:27   ` Mark Brown
2014-03-26  1:32   ` Bo Shen [this message]
2014-03-26  1:32     ` [alsa-devel] " Bo Shen
2014-03-26  1:32     ` Bo Shen
2014-03-25 11:59 ` Boris BREZILLON
2014-03-25 11:59   ` Boris BREZILLON
2014-03-25 11:59   ` Boris BREZILLON
2014-03-25 12:09   ` Luis Alberto Sanchez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53322E29.3070000@atmel.com \
    --to=voice.shen@atmel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=b.brezillon.dev@gmail.com \
    --cc=broonie@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=nicolas.ferre@atmel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.