Re: [PATCH] adv7611: Set HPD GPIO direction to output

[Hans Verkuil <hansverk@cisco.com>]

Hi Laurent,

Stupid question perhaps, but why is gpiod_set_value_cansleep() removed?
Does setting the output direction force the value to 0 as well?

Regards,

	Hans

On 03/26/14 03:28, Laurent Pinchart wrote:
> The HPD GPIO is used as an output but its direction is never set. Fix
> it.
> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
>  drivers/media/i2c/adv7604.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> This patch applies on top of the ADV7611 support series queued for v3.16.
> 
> diff --git a/drivers/media/i2c/adv7604.c b/drivers/media/i2c/adv7604.c
> index 51f14ab..b38ebb9 100644
> --- a/drivers/media/i2c/adv7604.c
> +++ b/drivers/media/i2c/adv7604.c
> @@ -2845,7 +2845,7 @@ static int adv7604_probe(struct i2c_client *client,
>  		if (IS_ERR(state->hpd_gpio[i]))
>  			continue;
>  
> -		gpiod_set_value_cansleep(state->hpd_gpio[i], 0);
> +		gpiod_direction_output(state->hpd_gpio[i], 0);
>  
>  		v4l_info(client, "Handling HPD %u GPIO\n", i);
>  	}
>