From: Christian Borntraeger <borntraeger@de.ibm.com>
To: "Gonglei (Arei)" <arei.gonglei@huawei.com>,
Paolo Bonzini <pbonzini@redhat.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>
Cc: "gleb@redhat.com" <gleb@redhat.com>,
"mst@redhat.com" <mst@redhat.com>,
"avi.kivity@gmail.com" <avi.kivity@gmail.com>,
"Herongguang (Stephen)" <herongguang.he@huawei.com>,
"Huangweidong (C)" <weidong.huang@huawei.com>
Subject: Re: [RFC]Two ideas to optimize updating irq routing table
Date: Wed, 26 Mar 2014 12:14:34 +0100 [thread overview]
Message-ID: <5332B69A.6060102@de.ibm.com> (raw)
In-Reply-To: <33183CC9F5247A488A2544077AF19020815DAEBA@SZXEMA503-MBS.china.huawei.com>
On 26/03/14 09:22, Gonglei (Arei) wrote:
> Without patches, ping time can jump from 0.3ms to 2ms-30ms. With synchronize_srcu
> patch, ping time is worse. With synchronize_srcu_expedited patch, ping time is
> overall good, though sometimes ping time jump to 1ms-3ms.
Just to understand whats going on, does something like
diff --git a/kernel/rcu/srcu.c b/kernel/rcu/srcu.c
index 3318d82..432c2a2 100644
--- a/kernel/rcu/srcu.c
+++ b/kernel/rcu/srcu.c
@@ -331,7 +331,7 @@ EXPORT_SYMBOL_GPL(__srcu_read_unlock);
*/
#define SRCU_RETRY_CHECK_DELAY 5
#define SYNCHRONIZE_SRCU_TRYCOUNT 2
-#define SYNCHRONIZE_SRCU_EXP_TRYCOUNT 12
+#define SYNCHRONIZE_SRCU_EXP_TRYCOUNT 50
/*
* @@@ Wait until all pre-existing readers complete. Such readers
make the problem go away?
WARNING: multiple messages have this Message-ID (diff)
From: Christian Borntraeger <borntraeger@de.ibm.com>
To: "Gonglei (Arei)" <arei.gonglei@huawei.com>,
Paolo Bonzini <pbonzini@redhat.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>
Cc: "Herongguang (Stephen)" <herongguang.he@huawei.com>,
"Huangweidong (C)" <weidong.huang@huawei.com>,
"avi.kivity@gmail.com" <avi.kivity@gmail.com>,
"gleb@redhat.com" <gleb@redhat.com>,
"mst@redhat.com" <mst@redhat.com>
Subject: Re: [Qemu-devel] [RFC]Two ideas to optimize updating irq routing table
Date: Wed, 26 Mar 2014 12:14:34 +0100 [thread overview]
Message-ID: <5332B69A.6060102@de.ibm.com> (raw)
In-Reply-To: <33183CC9F5247A488A2544077AF19020815DAEBA@SZXEMA503-MBS.china.huawei.com>
On 26/03/14 09:22, Gonglei (Arei) wrote:
> Without patches, ping time can jump from 0.3ms to 2ms-30ms. With synchronize_srcu
> patch, ping time is worse. With synchronize_srcu_expedited patch, ping time is
> overall good, though sometimes ping time jump to 1ms-3ms.
Just to understand whats going on, does something like
diff --git a/kernel/rcu/srcu.c b/kernel/rcu/srcu.c
index 3318d82..432c2a2 100644
--- a/kernel/rcu/srcu.c
+++ b/kernel/rcu/srcu.c
@@ -331,7 +331,7 @@ EXPORT_SYMBOL_GPL(__srcu_read_unlock);
*/
#define SRCU_RETRY_CHECK_DELAY 5
#define SYNCHRONIZE_SRCU_TRYCOUNT 2
-#define SYNCHRONIZE_SRCU_EXP_TRYCOUNT 12
+#define SYNCHRONIZE_SRCU_EXP_TRYCOUNT 50
/*
* @@@ Wait until all pre-existing readers complete. Such readers
make the problem go away?
next prev parent reply other threads:[~2014-03-26 11:14 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-25 3:19 [RFC]Two ideas to optimize updating irq routing table Gonglei (Arei)
2014-03-25 3:19 ` [Qemu-devel] " Gonglei (Arei)
2014-03-25 12:37 ` Paolo Bonzini
2014-03-25 12:37 ` [Qemu-devel] " Paolo Bonzini
2014-03-26 8:16 ` Christian Borntraeger
2014-03-26 8:16 ` [Qemu-devel] " Christian Borntraeger
2014-03-26 8:39 ` Gonglei (Arei)
2014-03-26 8:39 ` [Qemu-devel] " Gonglei (Arei)
2014-03-26 8:22 ` Gonglei (Arei)
2014-03-26 8:22 ` [Qemu-devel] " Gonglei (Arei)
2014-03-26 9:37 ` Paolo Bonzini
2014-03-26 9:37 ` [Qemu-devel] " Paolo Bonzini
2014-03-26 11:14 ` Christian Borntraeger [this message]
2014-03-26 11:14 ` Christian Borntraeger
2014-03-26 11:45 ` Michael S. Tsirkin
2014-03-26 11:45 ` [Qemu-devel] " Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5332B69A.6060102@de.ibm.com \
--to=borntraeger@de.ibm.com \
--cc=arei.gonglei@huawei.com \
--cc=avi.kivity@gmail.com \
--cc=gleb@redhat.com \
--cc=herongguang.he@huawei.com \
--cc=kvm@vger.kernel.org \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=weidong.huang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.