From: Julien Grall <julien.grall@linaro.org>
To: Ian Campbell <ian.campbell@citrix.com>
Cc: stefano.stabellini@eu.citrix.com, tim@xen.org, xen-devel@lists.xen.org
Subject: Re: [PATCH v2 15/17] xen: arm64: optimised clear_page
Date: Wed, 26 Mar 2014 14:16:06 +0000 [thread overview]
Message-ID: <5332E126.2020907@linaro.org> (raw)
In-Reply-To: <1395841133-2223-15-git-send-email-ian.campbell@citrix.com>
Hi Ian,
On 03/26/2014 01:38 PM, Ian Campbell wrote:
> Taken from Linux v3.14-rc7.
>
> The clear_page header now needs to be within the !__ASSEMBLY__
>
> Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
> ---
[..]
> +
> +#ifdef CONFIG_ARM_32
> +#define clear_page(page) memset((void *)(page), 0, PAGE_SIZE)
> +#else
> +extern void clear_page(void *to);
> +#endif
> +
I would prefer if you move the defined in arm{32,64}/page.h.
Regards,
--
Julien Grall
next prev parent reply other threads:[~2014-03-26 14:16 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-26 13:36 [PATCH v2 00/17] xen: arm: resync low level asm primitive from Linux Ian Campbell
2014-03-26 13:38 ` [PATCH v2 01/17] xen: x86 & generic: change to __builtin_prefetch() Ian Campbell
2014-04-02 16:01 ` Ian Campbell
2014-03-26 13:38 ` [PATCH v2 02/17] xen: arm32: resync bitops with Linux v3.14-rc7 Ian Campbell
2014-03-26 13:38 ` [PATCH v2 03/17] xen: arm32: ensure cmpxchg has full barrier semantics Ian Campbell
2014-03-26 13:38 ` [PATCH v2 04/17] xen: arm32: replace hard tabs in atomics.h Ian Campbell
2014-03-26 13:38 ` [PATCH v2 05/17] xen: arm32: resync atomics with (almost) v3.14-rc7 Ian Campbell
2014-03-26 14:10 ` Julien Grall
2014-03-26 13:38 ` [PATCH v2 06/17] xen: arm32: resync mem* with Linux v3.14-rc7 Ian Campbell
2014-03-26 13:38 ` [PATCH v2 07/17] xen: arm32: add optimised memchr routine Ian Campbell
2014-03-26 13:38 ` [PATCH v2 08/17] xen: arm32: add optimised strchr and strrchr routines Ian Campbell
2014-03-26 13:38 ` [PATCH v2 09/17] xen: arm: remove atomic_clear_mask() Ian Campbell
2014-03-26 13:38 ` [PATCH v2 10/17] xen: arm64: disable alignment traps Ian Campbell
2014-03-26 13:38 ` [PATCH v2 11/17] xen: arm64: atomics: fix use of acquire + release for full barrier semantics Ian Campbell
2014-03-26 13:38 ` [PATCH v2 12/17] xen: arm64: reinstate hard tabs in system.h cmpxchg Ian Campbell
2014-03-26 13:38 ` [PATCH v2 13/17] xen: arm64: asm: remove redundant "cc" clobbers Ian Campbell
2014-03-26 13:38 ` [PATCH v2 14/17] xen: arm64: assembly optimised mem* and str* Ian Campbell
2014-03-26 13:38 ` [PATCH v2 15/17] xen: arm64: optimised clear_page Ian Campbell
2014-03-26 14:16 ` Julien Grall [this message]
2014-04-02 16:23 ` [PATCH v3 " Ian Campbell
2014-04-02 16:26 ` Julien Grall
2014-03-26 13:38 ` [PATCH v2 16/17] xen: arm: refactor xchg and cmpxchg into their own headers Ian Campbell
2014-03-26 14:18 ` Julien Grall
2014-03-26 13:38 ` [PATCH v2 17/17] xen: arm: document what low level primitives we have imported from Linux Ian Campbell
2014-03-26 14:20 ` Julien Grall
2014-03-27 16:59 ` [PATCH v2 00/17] xen: arm: resync low level asm primitive " Tim Deegan
2014-03-27 17:02 ` Ian Campbell
2014-03-27 17:04 ` Tim Deegan
2014-03-27 17:18 ` Ian Campbell
2014-03-28 18:00 ` Julien Grall
2014-04-03 16:32 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5332E126.2020907@linaro.org \
--to=julien.grall@linaro.org \
--cc=ian.campbell@citrix.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.