From: Dinh Nguyen <dinh.linux@gmail.com>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
delicious quinoa <delicious.quinoa@gmail.com>
Cc: Alan Tull <atull@altera.com>,
Linus Walleij <linus.walleij@linaro.org>,
Alexandre Courbot <gnurou@gmail.com>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Dinh Nguyen <dinguyen@altera.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH 3/3] ARM: dts: socfpga: add gpio pieces
Date: Wed, 26 Mar 2014 10:29:34 -0500 [thread overview]
Message-ID: <5332F25E.10104@gmail.com> (raw)
In-Reply-To: <532D73D1.7020408@linutronix.de>
On 03/22/2014 06:28 AM, Sebastian Andrzej Siewior wrote:
> On 03/21/2014 11:15 PM, delicious quinoa wrote:
>> snps,nr-gpios = <27>;
>>
>> As noted on other thread, gpio2 is 27 wide, despite what the
>> documentation says. When I made that change and remove your other two
>> patches the gpios worked for me on a cyclone5 devkit board.
>>
>> So if you fix the "#gpio-cells = <2>;" for all 3 gpios and fix
>> "snps,nr-gpios = <27>;" for gpio2, then this one patch looks good to
>> me. With these changes,
>
> Okay will do. And I also add a note that the reference manual is wrong
> here.
>
I've applied this patch to rocketboards/linux-socfpga-next/next-dt. I
will take through the arm-soc tree for 3.16.
Dinh
>>
>> Acked-by: Alan Tull <atull@altera.com>
>>
>> Alan Tull
>> aka
>> delicous quinoa
>
> Sebastian
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
prev parent reply other threads:[~2014-03-26 15:29 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-20 19:55 two patches for the synposys gpio controller Sebastian Andrzej Siewior
2014-03-20 19:55 ` Sebastian Andrzej Siewior
2014-03-20 19:55 ` [PATCH 1/3] gpio: dwapb: drop irq_setup_generic_chip() Sebastian Andrzej Siewior
2014-03-25 20:37 ` Linus Walleij
2014-03-25 20:37 ` Linus Walleij
2014-03-31 16:22 ` Jamie Iles
2014-03-20 19:55 ` [PATCH 2/3] gpio: dwapb: do not create the irq mapping upfront Sebastian Andrzej Siewior
2014-03-20 20:20 ` delicious quinoa
2014-03-22 12:37 ` Sebastian Andrzej Siewior
2014-03-25 20:43 ` Linus Walleij
2014-03-25 21:17 ` Sebastian Andrzej Siewior
2014-04-08 13:20 ` Linus Walleij
[not found] ` <1395345324-18299-1-git-send-email-bigeasy-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>
2014-03-20 19:55 ` [PATCH 3/3] ARM: dts: socfpga: add gpio pieces Sebastian Andrzej Siewior
2014-03-20 19:55 ` Sebastian Andrzej Siewior
2014-03-21 17:24 ` Gerhard Sittig
2014-03-21 19:10 ` Sebastian Andrzej Siewior
2014-03-21 19:10 ` Sebastian Andrzej Siewior
2014-03-21 22:06 ` delicious quinoa
2014-03-21 18:14 ` delicious quinoa
2014-03-21 19:08 ` Sebastian Andrzej Siewior
[not found] ` <CANk1AXRa4V1ADNaT+T3pYF4zyxni9Y8rmU9UYRoA_7NxW8KWEg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-03-21 22:15 ` delicious quinoa
2014-03-21 22:15 ` delicious quinoa
2014-03-22 11:28 ` Sebastian Andrzej Siewior
2014-03-26 15:29 ` Dinh Nguyen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5332F25E.10104@gmail.com \
--to=dinh.linux@gmail.com \
--cc=atull@altera.com \
--cc=bigeasy@linutronix.de \
--cc=delicious.quinoa@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dinguyen@altera.com \
--cc=gnurou@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.