From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Gerhard Sittig <gsi@denx.de>
Cc: Alan Tull <atull@altera.com>,
Linus Walleij <linus.walleij@linaro.org>,
Alexandre Courbot <gnurou@gmail.com>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
Dinh Nguyen <dinguyen@altera.com>,
devicetree@vger.kernel.org
Subject: Re: [PATCH 3/3] ARM: dts: socfpga: add gpio pieces
Date: Fri, 21 Mar 2014 20:10:03 +0100 [thread overview]
Message-ID: <532C8E8B.9080406@linutronix.de> (raw)
In-Reply-To: <20140321172434.GB3998@book.gsilab.sittig.org>
On 03/21/2014 06:24 PM, Gerhard Sittig wrote:
> On Thu, Mar 20, 2014 at 20:55 +0100, Sebastian Andrzej Siewior wrote:
>>
>> The cycloneV has three gpio controllers, each one with 29 gpios. This patch
>> adds the three controller with the gpio driver which is now sitting the
>> gpio tree.
>
> The third bank should have 27 pins, only the first two have 29.
It is not a bank it is a complete controller. Why 27 pins? The
reference manual says that there register 0…28.
> The commit message probably should not discuss which git tree a
> driver currently resides in. This is just a temporary detail
> which no longer applies to the mainline source base where your
> patch will end up in.
This patch adds a binding which is not in kernel. It is worth to
mention.
>
>
> virtually yours
> Gerhard Sittig
>
Sebastian
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Gerhard Sittig <gsi@denx.de>
Cc: Alan Tull <atull@altera.com>,
Linus Walleij <linus.walleij@linaro.org>,
Alexandre Courbot <gnurou@gmail.com>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
Dinh Nguyen <dinguyen@altera.com>,
devicetree@vger.kernel.org
Subject: Re: [PATCH 3/3] ARM: dts: socfpga: add gpio pieces
Date: Fri, 21 Mar 2014 20:10:03 +0100 [thread overview]
Message-ID: <532C8E8B.9080406@linutronix.de> (raw)
In-Reply-To: <20140321172434.GB3998@book.gsilab.sittig.org>
On 03/21/2014 06:24 PM, Gerhard Sittig wrote:
> On Thu, Mar 20, 2014 at 20:55 +0100, Sebastian Andrzej Siewior wrote:
>>
>> The cycloneV has three gpio controllers, each one with 29 gpios. This patch
>> adds the three controller with the gpio driver which is now sitting the
>> gpio tree.
>
> The third bank should have 27 pins, only the first two have 29.
It is not a bank it is a complete controller. Why 27 pins? The
reference manual says that there register 0…28.
> The commit message probably should not discuss which git tree a
> driver currently resides in. This is just a temporary detail
> which no longer applies to the mainline source base where your
> patch will end up in.
This patch adds a binding which is not in kernel. It is worth to
mention.
>
>
> virtually yours
> Gerhard Sittig
>
Sebastian
next prev parent reply other threads:[~2014-03-21 19:10 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-20 19:55 two patches for the synposys gpio controller Sebastian Andrzej Siewior
2014-03-20 19:55 ` Sebastian Andrzej Siewior
2014-03-20 19:55 ` [PATCH 1/3] gpio: dwapb: drop irq_setup_generic_chip() Sebastian Andrzej Siewior
2014-03-25 20:37 ` Linus Walleij
2014-03-25 20:37 ` Linus Walleij
2014-03-31 16:22 ` Jamie Iles
2014-03-20 19:55 ` [PATCH 2/3] gpio: dwapb: do not create the irq mapping upfront Sebastian Andrzej Siewior
2014-03-20 20:20 ` delicious quinoa
2014-03-22 12:37 ` Sebastian Andrzej Siewior
2014-03-25 20:43 ` Linus Walleij
2014-03-25 21:17 ` Sebastian Andrzej Siewior
2014-04-08 13:20 ` Linus Walleij
[not found] ` <1395345324-18299-1-git-send-email-bigeasy-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>
2014-03-20 19:55 ` [PATCH 3/3] ARM: dts: socfpga: add gpio pieces Sebastian Andrzej Siewior
2014-03-20 19:55 ` Sebastian Andrzej Siewior
2014-03-21 17:24 ` Gerhard Sittig
2014-03-21 19:10 ` Sebastian Andrzej Siewior [this message]
2014-03-21 19:10 ` Sebastian Andrzej Siewior
2014-03-21 22:06 ` delicious quinoa
2014-03-21 18:14 ` delicious quinoa
2014-03-21 19:08 ` Sebastian Andrzej Siewior
[not found] ` <CANk1AXRa4V1ADNaT+T3pYF4zyxni9Y8rmU9UYRoA_7NxW8KWEg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-03-21 22:15 ` delicious quinoa
2014-03-21 22:15 ` delicious quinoa
2014-03-22 11:28 ` Sebastian Andrzej Siewior
2014-03-26 15:29 ` Dinh Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=532C8E8B.9080406@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=atull@altera.com \
--cc=devicetree@vger.kernel.org \
--cc=dinguyen@altera.com \
--cc=gnurou@gmail.com \
--cc=gsi@denx.de \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.