From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Vlad Yasevich <vyasevic@redhat.com>, netdev@vger.kernel.org
Cc: shemminger@vyatta.com, bridge@lists.linux-foundation.org
Subject: Re: [Bridge] [PATCH v2 net 1/2] net: Allow modules to use is_skb_forwardable
Date: Wed, 26 Mar 2014 22:18:33 +0300 [thread overview]
Message-ID: <53332809.4000404@cogentembedded.com> (raw)
In-Reply-To: <1395850490-27628-2-git-send-email-vyasevic@redhat.com>
Hello.
On 03/26/2014 07:14 PM, Vlad Yasevich wrote:
> Signed-off-by: Vlad Yasevich <vyasevic@redhat.com>
[...]
> diff --git a/net/core/dev.c b/net/core/dev.c
> index b1b0c8d..a98f7fa 100644
> --- a/net/core/dev.c
> +++ b/net/core/dev.c
> @@ -1645,7 +1645,7 @@ static inline void net_timestamp_set(struct sk_buff *skb)
> __net_timestamp(SKB); \
> } \
>
> -static inline bool is_skb_forwardable(struct net_device *dev,
> +bool is_skb_forwardable(struct net_device *dev,
> struct sk_buff *skb)
Please re-indent the above line, so that it still starts under *struct*.
> {
> unsigned int len;
WBR, Sergei
WARNING: multiple messages have this Message-ID (diff)
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Vlad Yasevich <vyasevic@redhat.com>, netdev@vger.kernel.org
Cc: bridge@lists.linux-foundation.org, shemminger@vyatta.com
Subject: Re: [PATCH v2 net 1/2] net: Allow modules to use is_skb_forwardable
Date: Wed, 26 Mar 2014 22:18:33 +0300 [thread overview]
Message-ID: <53332809.4000404@cogentembedded.com> (raw)
In-Reply-To: <1395850490-27628-2-git-send-email-vyasevic@redhat.com>
Hello.
On 03/26/2014 07:14 PM, Vlad Yasevich wrote:
> Signed-off-by: Vlad Yasevich <vyasevic@redhat.com>
[...]
> diff --git a/net/core/dev.c b/net/core/dev.c
> index b1b0c8d..a98f7fa 100644
> --- a/net/core/dev.c
> +++ b/net/core/dev.c
> @@ -1645,7 +1645,7 @@ static inline void net_timestamp_set(struct sk_buff *skb)
> __net_timestamp(SKB); \
> } \
>
> -static inline bool is_skb_forwardable(struct net_device *dev,
> +bool is_skb_forwardable(struct net_device *dev,
> struct sk_buff *skb)
Please re-indent the above line, so that it still starts under *struct*.
> {
> unsigned int len;
WBR, Sergei
next prev parent reply other threads:[~2014-03-26 19:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-26 16:14 [Bridge] [PATCH v2 net 0/2] bridge: Fix forwarding of 8021AD frames Vlad Yasevich
2014-03-26 16:14 ` Vlad Yasevich
2014-03-26 16:14 ` [Bridge] [PATCH v2 net 1/2] net: Allow modules to use is_skb_forwardable Vlad Yasevich
2014-03-26 16:14 ` Vlad Yasevich
2014-03-26 19:18 ` Sergei Shtylyov [this message]
2014-03-26 19:18 ` Sergei Shtylyov
2014-03-26 16:14 ` [Bridge] [PATCH v2 net 2/2] bridge: use is_skb_forwardable in forward path Vlad Yasevich
2014-03-26 16:14 ` Vlad Yasevich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53332809.4000404@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=bridge@lists.linux-foundation.org \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
--cc=vyasevic@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.