From: Timur Tabi <timur@tabi.org>
To: "Jason.Jin@freescale.com" <Jason.Jin@freescale.com>
Cc: Scott Wood <scottwood@freescale.com>,
"linux-fbdev@vger.kernel.org" <linux-fbdev@vger.kernel.org>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [PATCH 1/2] video/fsl: make the diu driver work without platform hooks
Date: Thu, 27 Mar 2014 03:35:50 +0000 [thread overview]
Message-ID: <53339C96.3070406@tabi.org> (raw)
In-Reply-To: <f6883c3f759a4544936acec5dc7e542b@BLUPR03MB373.namprd03.prod.outlook.com>
Jason.Jin@freescale.com wrote:
>>>>> However, the DIU is already initialized in u-boot and we can
>>>>> rely on the settings in u-boot for corenet platform,
>>>
>>> I don't like that at all.
> [Jason Jin-R64188] What's the potential issue of this? Most of the
> IPs need the platform initialization in u-boot. For example, the
> hwconfig in u-boot used for board specific settings for most
> platform.
The potential problem is that it's not stable. Power management breaks
your code.
I won't NACK your patch, but it feels like a band-aid rather than a real
solution.
WARNING: multiple messages have this Message-ID (diff)
From: Timur Tabi <timur@tabi.org>
To: "Jason.Jin@freescale.com" <Jason.Jin@freescale.com>
Cc: Scott Wood <scottwood@freescale.com>,
"linux-fbdev@vger.kernel.org" <linux-fbdev@vger.kernel.org>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [PATCH 1/2] video/fsl: make the diu driver work without platform hooks
Date: Wed, 26 Mar 2014 22:35:50 -0500 [thread overview]
Message-ID: <53339C96.3070406@tabi.org> (raw)
In-Reply-To: <f6883c3f759a4544936acec5dc7e542b@BLUPR03MB373.namprd03.prod.outlook.com>
Jason.Jin@freescale.com wrote:
>>>>> However, the DIU is already initialized in u-boot and we can
>>>>> rely on the settings in u-boot for corenet platform,
>>>
>>> I don't like that at all.
> [Jason Jin-R64188] What's the potential issue of this? Most of the
> IPs need the platform initialization in u-boot. For example, the
> hwconfig in u-boot used for board specific settings for most
> platform.
The potential problem is that it's not stable. Power management breaks
your code.
I won't NACK your patch, but it feels like a band-aid rather than a real
solution.
next prev parent reply other threads:[~2014-03-27 3:35 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-26 17:41 [PATCH 1/2] video/fsl: make the diu driver work without platform hooks Jason Jin
2014-03-26 17:41 ` Jason Jin
2014-03-26 17:41 ` [PATCH 2/2] video/fsl: Fix the sleep function for FSL DIU module Jason Jin
2014-03-26 17:41 ` Jason Jin
2014-03-26 18:50 ` Timur Tabi
2014-03-26 18:50 ` Timur Tabi
2014-03-27 3:42 ` Jason.Jin
2014-03-27 3:42 ` Jason.Jin
2014-03-27 3:46 ` Timur Tabi
2014-03-27 3:46 ` Timur Tabi
2014-03-27 3:57 ` Jason.Jin
2014-03-27 3:57 ` Jason.Jin
2014-03-26 18:46 ` [PATCH 1/2] video/fsl: make the diu driver work without platform hooks Timur Tabi
2014-03-26 18:46 ` Timur Tabi
2014-03-27 3:30 ` Jason.Jin
2014-03-27 3:30 ` Jason.Jin
2014-03-27 3:35 ` Timur Tabi [this message]
2014-03-27 3:35 ` Timur Tabi
2014-03-27 3:38 ` Jason.Jin
2014-03-27 3:38 ` Jason.Jin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53339C96.3070406@tabi.org \
--to=timur@tabi.org \
--cc=Jason.Jin@freescale.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=scottwood@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.