All of lore.kernel.org
 help / color / mirror / Atom feed
From: lars@metafoo.de (Lars-Peter Clausen)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH resend] clk: axi-clkgen: Add support for v2
Date: Thu, 27 Mar 2014 09:29:53 +0100	[thread overview]
Message-ID: <5333E181.60607@metafoo.de> (raw)
In-Reply-To: <20140327023817.5762.48198@quantum>

On 03/27/2014 03:38 AM, Mike Turquette wrote:
> Quoting Lars-Peter Clausen (2014-02-26 22:20:53)
>> On 02/27/2014 02:04 AM, Mike Turquette wrote:
>>> Quoting Lars-Peter Clausen (2014-02-17 01:31:53)
>>>> This patch adds support for the new v2 version of the axi-clkgen core.
>>>> Unfortunately the method of accessing the registers is quite different on v2,
>>>> while the content still stays largely the same. So the patch adds a small
>>>> abstraction layer which implements the specific read and write functions for v1
>>>> and v2 in callback functions.
>>>
>>> Hi,
>>>
>>> This patch almost doubles the size of clk-axi-clkgen.c. Should it be a
>>> separate clock driver? I guess that depends on the relationship between
>>> "v1" and "v2". Are both of those versions of the clkgen core going into
>>> production?
>>
>> Hi,
>>
>> The only thing that is different between the two versions is how the PLL
>> registers are accessed. The content that is written to those register is a
>> 100% identical. So splitting it up into two drivers makes no sense, since
>> you'd have to copy&paste all the application logic. Both versions of the
>> core can be found in the wild.
>
> Hi Lars,
>
> I took this into clk-next some time ago but never replied to this thread
> letting you know. Better late than never :-)

Yep, already saw it showing up in clk-next a while ago, thanks.

- Lars

WARNING: multiple messages have this Message-ID (diff)
From: Lars-Peter Clausen <lars@metafoo.de>
To: Mike Turquette <mturquette@linaro.org>
Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH resend] clk: axi-clkgen: Add support for v2
Date: Thu, 27 Mar 2014 09:29:53 +0100	[thread overview]
Message-ID: <5333E181.60607@metafoo.de> (raw)
In-Reply-To: <20140327023817.5762.48198@quantum>

On 03/27/2014 03:38 AM, Mike Turquette wrote:
> Quoting Lars-Peter Clausen (2014-02-26 22:20:53)
>> On 02/27/2014 02:04 AM, Mike Turquette wrote:
>>> Quoting Lars-Peter Clausen (2014-02-17 01:31:53)
>>>> This patch adds support for the new v2 version of the axi-clkgen core.
>>>> Unfortunately the method of accessing the registers is quite different on v2,
>>>> while the content still stays largely the same. So the patch adds a small
>>>> abstraction layer which implements the specific read and write functions for v1
>>>> and v2 in callback functions.
>>>
>>> Hi,
>>>
>>> This patch almost doubles the size of clk-axi-clkgen.c. Should it be a
>>> separate clock driver? I guess that depends on the relationship between
>>> "v1" and "v2". Are both of those versions of the clkgen core going into
>>> production?
>>
>> Hi,
>>
>> The only thing that is different between the two versions is how the PLL
>> registers are accessed. The content that is written to those register is a
>> 100% identical. So splitting it up into two drivers makes no sense, since
>> you'd have to copy&paste all the application logic. Both versions of the
>> core can be found in the wild.
>
> Hi Lars,
>
> I took this into clk-next some time ago but never replied to this thread
> letting you know. Better late than never :-)

Yep, already saw it showing up in clk-next a while ago, thanks.

- Lars


  reply	other threads:[~2014-03-27  8:29 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-17  9:31 [PATCH resend] clk: axi-clkgen: Add support for v2 Lars-Peter Clausen
2014-02-17  9:31 ` Lars-Peter Clausen
2014-02-27  1:04 ` Mike Turquette
2014-02-27  6:20   ` Lars-Peter Clausen
2014-02-27  6:20     ` Lars-Peter Clausen
2014-03-27  2:38     ` Mike Turquette
2014-03-27  8:29       ` Lars-Peter Clausen [this message]
2014-03-27  8:29         ` Lars-Peter Clausen
  -- strict thread matches above, loose matches on Subject: below --
2014-01-13 17:30 Lars-Peter Clausen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5333E181.60607@metafoo.de \
    --to=lars@metafoo.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.