From: "Srivatsa S. Bhat" <srivatsa.bhat@linux.vnet.ibm.com>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: "ego@linux.vnet.ibm.com" <ego@linux.vnet.ibm.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
"linuxppc-dev@ozlabs.org" <linuxppc-dev@ozlabs.org>,
Linux PM list <linux-pm@vger.kernel.org>,
Vaidyanathan Srinivasan <svaidy@linux.vnet.ibm.com>,
Anton Blanchard <anton@samba.org>
Subject: Re: [PATCH v4] powernv, cpufreq: cpufreq driver for powernv platform
Date: Thu, 27 Mar 2014 15:51:28 +0530 [thread overview]
Message-ID: <5333FBA8.1040107@linux.vnet.ibm.com> (raw)
In-Reply-To: <CAKohponOe9Au+pe5u9FpddW3+f5pegZB953+5fmYBDusE9j0HA@mail.gmail.com>
On 03/27/2014 03:29 PM, Viresh Kumar wrote:
> On 27 March 2014 15:00, Gautham R Shenoy <ego@linux.vnet.ibm.com> wrote:
>> As of now, I prefer this patch be based on code that is in the -next
>> tree. I'll get rid of the per-core locking once the serialization
>> patch of the core is accepted.
>
[...]
>>>> + pr_debug("cpu %d pmsr %lx pstate_id %d frequency %d kHz \n",
>>>> + smp_processor_id(), pmspr_val, freq_data->pstate_id,
>>>
>>> s/smp_processor_id/raw_smp_processor_id ?
>>
>> No. This function is called via smp_call_function(). So we have
>> preempt_disable on and it is safe to use smp_processor_id.
>
> My question wasn't about being safe, but avoiding the complexity
> of debug_smp_processor_id(). raw_smp_processor_id() can execute
> very quickly.
>
smp_processor_id() maps to debug_smp_processor_id() only if
CONFIG_DEBUG_PREEMPT is set. Otherwise, it is same as raw_smp_processor_id().
So I think its best to keep it as it is.
Regards,
Srivatsa S. Bhat
WARNING: multiple messages have this Message-ID (diff)
From: "Srivatsa S. Bhat" <srivatsa.bhat@linux.vnet.ibm.com>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: "ego@linux.vnet.ibm.com" <ego@linux.vnet.ibm.com>,
Linux PM list <linux-pm@vger.kernel.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
"linuxppc-dev@ozlabs.org" <linuxppc-dev@ozlabs.org>,
Anton Blanchard <anton@samba.org>
Subject: Re: [PATCH v4] powernv, cpufreq: cpufreq driver for powernv platform
Date: Thu, 27 Mar 2014 15:51:28 +0530 [thread overview]
Message-ID: <5333FBA8.1040107@linux.vnet.ibm.com> (raw)
In-Reply-To: <CAKohponOe9Au+pe5u9FpddW3+f5pegZB953+5fmYBDusE9j0HA@mail.gmail.com>
On 03/27/2014 03:29 PM, Viresh Kumar wrote:
> On 27 March 2014 15:00, Gautham R Shenoy <ego@linux.vnet.ibm.com> wrote:
>> As of now, I prefer this patch be based on code that is in the -next
>> tree. I'll get rid of the per-core locking once the serialization
>> patch of the core is accepted.
>
[...]
>>>> + pr_debug("cpu %d pmsr %lx pstate_id %d frequency %d kHz \n",
>>>> + smp_processor_id(), pmspr_val, freq_data->pstate_id,
>>>
>>> s/smp_processor_id/raw_smp_processor_id ?
>>
>> No. This function is called via smp_call_function(). So we have
>> preempt_disable on and it is safe to use smp_processor_id.
>
> My question wasn't about being safe, but avoiding the complexity
> of debug_smp_processor_id(). raw_smp_processor_id() can execute
> very quickly.
>
smp_processor_id() maps to debug_smp_processor_id() only if
CONFIG_DEBUG_PREEMPT is set. Otherwise, it is same as raw_smp_processor_id().
So I think its best to keep it as it is.
Regards,
Srivatsa S. Bhat
next prev parent reply other threads:[~2014-03-27 10:21 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-26 16:55 [PATCH v4] powernv: Dynamic Frequency Scaling Enablement Gautham R. Shenoy
2014-03-26 16:55 ` Gautham R. Shenoy
2014-03-26 16:55 ` [PATCH v4] powernv, cpufreq: cpufreq driver for powernv platform Gautham R. Shenoy
2014-03-26 16:55 ` Gautham R. Shenoy
2014-03-27 3:56 ` Anton Blanchard
2014-03-27 3:56 ` Anton Blanchard
2014-03-27 6:39 ` Viresh Kumar
2014-03-27 6:39 ` Viresh Kumar
2014-03-27 9:30 ` Gautham R Shenoy
2014-03-27 9:30 ` Gautham R Shenoy
2014-03-27 9:59 ` Viresh Kumar
2014-03-27 9:59 ` Viresh Kumar
2014-03-27 10:21 ` Srivatsa S. Bhat [this message]
2014-03-27 10:21 ` Srivatsa S. Bhat
2014-03-27 10:23 ` Viresh Kumar
2014-03-27 10:23 ` Viresh Kumar
2014-03-27 11:20 ` Gautham R Shenoy
2014-03-27 11:20 ` Gautham R Shenoy
2014-03-27 11:29 ` Viresh Kumar
2014-03-27 11:29 ` Viresh Kumar
2014-03-27 12:56 ` Benjamin Herrenschmidt
2014-03-27 12:56 ` Benjamin Herrenschmidt
2014-03-27 10:11 ` Vaidyanathan Srinivasan
2014-03-27 10:11 ` Vaidyanathan Srinivasan
2014-03-27 10:22 ` Viresh Kumar
2014-03-27 10:22 ` Viresh Kumar
2014-03-27 11:12 ` Benjamin Herrenschmidt
2014-03-27 11:12 ` Benjamin Herrenschmidt
2014-03-28 5:25 ` Viresh Kumar
2014-03-28 5:25 ` Viresh Kumar
2014-03-27 5:38 ` [PATCH v4] powernv: Dynamic Frequency Scaling Enablement Viresh Kumar
2014-03-27 5:38 ` Viresh Kumar
2014-03-27 6:28 ` Benjamin Herrenschmidt
2014-03-27 6:28 ` Benjamin Herrenschmidt
2014-03-27 6:42 ` Viresh Kumar
2014-03-27 6:42 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5333FBA8.1040107@linux.vnet.ibm.com \
--to=srivatsa.bhat@linux.vnet.ibm.com \
--cc=anton@samba.org \
--cc=benh@kernel.crashing.org \
--cc=ego@linux.vnet.ibm.com \
--cc=linux-pm@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=rjw@rjwysocki.net \
--cc=svaidy@linux.vnet.ibm.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.