All of lore.kernel.org
 help / color / mirror / Atom feed
From: Keir Fraser <keir.xen@gmail.com>
To: Julien Grall <julien.grall@linaro.org>
Cc: xen-devel@lists.xenproject.org, tim@xen.org,
	ian.campbell@citrix.com, stefano.stabellini@citrix.com
Subject: Re: [PATCH v3] xen/serial: Don't leak memory mapping if the serial initialization has failed
Date: Fri, 28 Mar 2014 15:31:12 +0000	[thread overview]
Message-ID: <533595C0.6090606@gmail.com> (raw)
In-Reply-To: <1396019517-2778-1-git-send-email-julien.grall@linaro.org>

Julien Grall wrote:
> The memory mapping leaked when the serial driver failed to retrieve
> the IRQ. We can safely move the call to ioremap after.
>
> Also use ioremap_cache instead of ioremap_attr in some serial drivers.
>
> Signed-off-by: Julien Grall<julien.grall@linaro.org>
> Acked-by: Ian Campbell<ian.campbell@citrix.com>
> Cc: Keir Fraser<keir@xen.org>
Acked-by: Keir Fraser <keir@xen.org>

  reply	other threads:[~2014-03-28 15:31 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-28 15:11 [PATCH v3] xen/serial: Don't leak memory mapping if the serial initialization has failed Julien Grall
2014-03-28 15:31 ` Keir Fraser [this message]
2014-04-01 10:53   ` Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=533595C0.6090606@gmail.com \
    --to=keir.xen@gmail.com \
    --cc=ian.campbell@citrix.com \
    --cc=julien.grall@linaro.org \
    --cc=stefano.stabellini@citrix.com \
    --cc=tim@xen.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.