From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: "qiang.zhao@freescale.com" <qiang.zhao@freescale.com>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Scott Wood <scottwood@freescale.com>
Cc: "mugunthanvnm@ti.com" <mugunthanvnm@ti.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"helmut.schaa@googlemail.com" <helmut.schaa@googlemail.com>,
"zonque@gmail.com" <zonque@gmail.com>,
"davem@davemloft.net" <davem@davemloft.net>,
Xiaobo Xie <X.Xie@freescale.com>
Subject: Re: [PATCH] phy/at8031: enable at8031 to work on interrupt mode
Date: Fri, 28 Mar 2014 21:09:02 +0300 [thread overview]
Message-ID: <5335BABE.80007@cogentembedded.com> (raw)
In-Reply-To: <0ca1e7910cd247c4aebe4cbd48a633cb@BLUPR03MB341.namprd03.prod.outlook.com>
Hello.
On 03/28/2014 10:36 AM, qiang.zhao@freescale.com wrote:
>>> The at8031 can work on polling mode and interrupt mode.
>>> Add ack_interrupt and config intr funcs to enable interrupt mode for
>>> it.
>>> Signed-off-by: Zhao Qiang <B45475@freescale.com>
>>> ---
>>> drivers/net/phy/at803x.c | 30 ++++++++++++++++++++++++++++++
>>> 1 file changed, 30 insertions(+)
>>> diff --git a/drivers/net/phy/at803x.c b/drivers/net/phy/at803x.c index
>>> bc71947..d034ef5 100644
>>> --- a/drivers/net/phy/at803x.c
>>> +++ b/drivers/net/phy/at803x.c
>> [...]
>>> @@ -191,6 +194,31 @@ static int at803x_config_init(struct phy_device
>> *phydev)
>>> return 0;
>>> }
>>>
>>> +static int at803x_ack_interrupt(struct phy_device *phydev) {
>>> + int err;
>>> +
>>> + err = phy_read(phydev, AT803X_INSR);
>> Could make this an initializer...
> Thank you very much. However I have no idea about "make this an initializer".
int err = phy_read(phydev, AT803X_INSR);
WBR, Sergei
WARNING: multiple messages have this Message-ID (diff)
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: "qiang.zhao@freescale.com" <qiang.zhao@freescale.com>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Scott Wood <scottwood@freescale.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"davem@davemloft.net" <davem@davemloft.net>,
"mugunthanvnm@ti.com" <mugunthanvnm@ti.com>,
"zonque@gmail.com" <zonque@gmail.com>,
"helmut.schaa@googlemail.com" <helmut.schaa@googlemail.com>,
Xiaobo Xie <X.Xie@freescale.com>
Subject: Re: [PATCH] phy/at8031: enable at8031 to work on interrupt mode
Date: Fri, 28 Mar 2014 21:09:02 +0300 [thread overview]
Message-ID: <5335BABE.80007@cogentembedded.com> (raw)
In-Reply-To: <0ca1e7910cd247c4aebe4cbd48a633cb@BLUPR03MB341.namprd03.prod.outlook.com>
Hello.
On 03/28/2014 10:36 AM, qiang.zhao@freescale.com wrote:
>>> The at8031 can work on polling mode and interrupt mode.
>>> Add ack_interrupt and config intr funcs to enable interrupt mode for
>>> it.
>>> Signed-off-by: Zhao Qiang <B45475@freescale.com>
>>> ---
>>> drivers/net/phy/at803x.c | 30 ++++++++++++++++++++++++++++++
>>> 1 file changed, 30 insertions(+)
>>> diff --git a/drivers/net/phy/at803x.c b/drivers/net/phy/at803x.c index
>>> bc71947..d034ef5 100644
>>> --- a/drivers/net/phy/at803x.c
>>> +++ b/drivers/net/phy/at803x.c
>> [...]
>>> @@ -191,6 +194,31 @@ static int at803x_config_init(struct phy_device
>> *phydev)
>>> return 0;
>>> }
>>>
>>> +static int at803x_ack_interrupt(struct phy_device *phydev) {
>>> + int err;
>>> +
>>> + err = phy_read(phydev, AT803X_INSR);
>> Could make this an initializer...
> Thank you very much. However I have no idea about "make this an initializer".
int err = phy_read(phydev, AT803X_INSR);
WBR, Sergei
next prev parent reply other threads:[~2014-03-28 17:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-27 6:18 [PATCH] phy/at8031: enable at8031 to work on interrupt mode Zhao Qiang
2014-03-27 6:18 ` Zhao Qiang
2014-03-27 11:52 ` Sergei Shtylyov
2014-03-27 11:52 ` Sergei Shtylyov
2014-03-28 7:36 ` qiang.zhao
2014-03-28 7:36 ` qiang.zhao
2014-03-28 7:36 ` qiang.zhao
2014-03-28 18:09 ` Sergei Shtylyov [this message]
2014-03-28 18:09 ` Sergei Shtylyov
-- strict thread matches above, loose matches on Subject: below --
2014-03-26 6:45 Zhao Qiang
2014-03-26 18:13 ` Scott Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5335BABE.80007@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=X.Xie@freescale.com \
--cc=davem@davemloft.net \
--cc=helmut.schaa@googlemail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mugunthanvnm@ti.com \
--cc=netdev@vger.kernel.org \
--cc=qiang.zhao@freescale.com \
--cc=scottwood@freescale.com \
--cc=zonque@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.