* [PATCH for-3.15] scsi/libiscsi: Fix static checker warning on bh locking
@ 2014-03-30 12:26 Or Gerlitz
2014-03-31 6:59 ` Mike Christie
0 siblings, 1 reply; 2+ messages in thread
From: Or Gerlitz @ 2014-03-30 12:26 UTC (permalink / raw)
To: James.Bottomley; +Cc: linux-scsi, michaelc, Shlomo Pongratz, Or Gerlitz
From: Shlomo Pongratz <shlomop@mellanox.com>
Commit 659743b "[SCSI] libiscsi: Reduce locking contention in fast path" introduced a
new smatch warning on libiscsi.c "iscsi_xmit_task() warn: inconsistent returns
bottom_half:: locked (1410 [(-61)]) unlocked (1425 [0], 1425 [s32min-(-1),1-s32max])",
which we can eliminate by using non bh locking on the nested spin_lock call.
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Shlomo Pongratz <shlomop@mellanox.com>
Signed-off-by: Or Gerlitz <ogerlitz@mellanox.com>
---
drivers/scsi/libiscsi.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/libiscsi.c b/drivers/scsi/libiscsi.c
index 5b8605c..5087957 100644
--- a/drivers/scsi/libiscsi.c
+++ b/drivers/scsi/libiscsi.c
@@ -1411,9 +1411,9 @@ static int iscsi_xmit_task(struct iscsi_conn *conn)
conn->task = NULL;
}
/* regular RX path uses back_lock */
- spin_lock_bh(&conn->session->back_lock);
+ spin_lock(&conn->session->back_lock);
__iscsi_put_task(task);
- spin_unlock_bh(&conn->session->back_lock);
+ spin_unlock(&conn->session->back_lock);
return rc;
}
--
1.7.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH for-3.15] scsi/libiscsi: Fix static checker warning on bh locking
2014-03-30 12:26 [PATCH for-3.15] scsi/libiscsi: Fix static checker warning on bh locking Or Gerlitz
@ 2014-03-31 6:59 ` Mike Christie
0 siblings, 0 replies; 2+ messages in thread
From: Mike Christie @ 2014-03-31 6:59 UTC (permalink / raw)
To: Or Gerlitz; +Cc: James.Bottomley, linux-scsi, Shlomo Pongratz
On 03/30/2014 07:26 AM, Or Gerlitz wrote:
> From: Shlomo Pongratz <shlomop@mellanox.com>
>
> Commit 659743b "[SCSI] libiscsi: Reduce locking contention in fast path" introduced a
> new smatch warning on libiscsi.c "iscsi_xmit_task() warn: inconsistent returns
> bottom_half:: locked (1410 [(-61)]) unlocked (1425 [0], 1425 [s32min-(-1),1-s32max])",
> which we can eliminate by using non bh locking on the nested spin_lock call.
>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: Shlomo Pongratz <shlomop@mellanox.com>
> Signed-off-by: Or Gerlitz <ogerlitz@mellanox.com>
> ---
>
> drivers/scsi/libiscsi.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/scsi/libiscsi.c b/drivers/scsi/libiscsi.c
> index 5b8605c..5087957 100644
> --- a/drivers/scsi/libiscsi.c
> +++ b/drivers/scsi/libiscsi.c
> @@ -1411,9 +1411,9 @@ static int iscsi_xmit_task(struct iscsi_conn *conn)
> conn->task = NULL;
> }
> /* regular RX path uses back_lock */
> - spin_lock_bh(&conn->session->back_lock);
> + spin_lock(&conn->session->back_lock);
> __iscsi_put_task(task);
> - spin_unlock_bh(&conn->session->back_lock);
> + spin_unlock(&conn->session->back_lock);
> return rc;
Thanks for cleaning this up Or and Shlomo.
Reviewed-by: Mike Christie <michaelc@cs.wisc.edu>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-03-31 6:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-03-30 12:26 [PATCH for-3.15] scsi/libiscsi: Fix static checker warning on bh locking Or Gerlitz
2014-03-31 6:59 ` Mike Christie
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.