All of lore.kernel.org
 help / color / mirror / Atom feed
From: awallis@codeaurora.org (Adam Wallis)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 0/5] Switch arm64 over to qrwlock
Date: Thu, 12 Oct 2017 09:16:33 -0400	[thread overview]
Message-ID: <53399b22-8062-aa06-8569-e3fb0ae70ff0@codeaurora.org> (raw)
In-Reply-To: <1507810851-306-1-git-send-email-will.deacon@arm.com>

On 10/12/2017 8:20 AM, Will Deacon wrote:
> Hello,
> 
> This is version three of the patches previously posted here:
> 
> v1: http://lists.infradead.org/pipermail/linux-arm-kernel/2017-October/534666.html
> v2: http://lists.infradead.org/pipermail/linux-arm-kernel/2017-October/534981.html
> 
> Changes since v2 include:
> 
>   * Drop unused cnt argument
>   * Fix typo in UNLOCK Kconfig inlining options
>   * Added Tested-by tags
> 
> Thanks to all of those who provided review and testing feedback!
> 
> Will
> 
> --->8
> 
> Will Deacon (5):
>   kernel/locking: Use struct qrwlock instead of struct __qrwlock
>   locking/atomic: Add atomic_cond_read_acquire
>   kernel/locking: Use atomic_cond_read_acquire when spinning in qrwlock
>   arm64: locking: Move rwlock implementation over to qrwlocks
>   kernel/locking: Prevent slowpath writers getting held up by fastpath
> 
>  arch/arm64/Kconfig                      |  17 ++++
>  arch/arm64/include/asm/Kbuild           |   1 +
>  arch/arm64/include/asm/spinlock.h       | 164 +-------------------------------
>  arch/arm64/include/asm/spinlock_types.h |   6 +-
>  include/asm-generic/atomic-long.h       |   3 +
>  include/asm-generic/qrwlock.h           |  37 ++-----
>  include/asm-generic/qrwlock_types.h     |  15 ++-
>  include/linux/atomic.h                  |   4 +
>  kernel/locking/qrwlock.c                |  86 +++--------------
>  9 files changed, 61 insertions(+), 272 deletions(-)
> 

Will, I see the same performance improvements that I was getting in v2 of the
patch. I will continue to run these patches on multiple systems over the next
few weeks, months for stability/functionality testing as well.

Tested-by: Adam Wallis <awallis@codeaurora.org>

-- 
Adam Wallis
Qualcomm Datacenter Technologies as an affiliate of Qualcomm Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project.

WARNING: multiple messages have this Message-ID (diff)
From: Adam Wallis <awallis@codeaurora.org>
To: Will Deacon <will.deacon@arm.com>, linux-kernel@vger.kernel.org
Cc: peterz@infradead.org, boqun.feng@gmail.com,
	Jeremy.Linton@arm.com, mingo@redhat.com, longman@redhat.com,
	paulmck@linux.vnet.ibm.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 0/5] Switch arm64 over to qrwlock
Date: Thu, 12 Oct 2017 09:16:33 -0400	[thread overview]
Message-ID: <53399b22-8062-aa06-8569-e3fb0ae70ff0@codeaurora.org> (raw)
In-Reply-To: <1507810851-306-1-git-send-email-will.deacon@arm.com>

On 10/12/2017 8:20 AM, Will Deacon wrote:
> Hello,
> 
> This is version three of the patches previously posted here:
> 
> v1: http://lists.infradead.org/pipermail/linux-arm-kernel/2017-October/534666.html
> v2: http://lists.infradead.org/pipermail/linux-arm-kernel/2017-October/534981.html
> 
> Changes since v2 include:
> 
>   * Drop unused cnt argument
>   * Fix typo in UNLOCK Kconfig inlining options
>   * Added Tested-by tags
> 
> Thanks to all of those who provided review and testing feedback!
> 
> Will
> 
> --->8
> 
> Will Deacon (5):
>   kernel/locking: Use struct qrwlock instead of struct __qrwlock
>   locking/atomic: Add atomic_cond_read_acquire
>   kernel/locking: Use atomic_cond_read_acquire when spinning in qrwlock
>   arm64: locking: Move rwlock implementation over to qrwlocks
>   kernel/locking: Prevent slowpath writers getting held up by fastpath
> 
>  arch/arm64/Kconfig                      |  17 ++++
>  arch/arm64/include/asm/Kbuild           |   1 +
>  arch/arm64/include/asm/spinlock.h       | 164 +-------------------------------
>  arch/arm64/include/asm/spinlock_types.h |   6 +-
>  include/asm-generic/atomic-long.h       |   3 +
>  include/asm-generic/qrwlock.h           |  37 ++-----
>  include/asm-generic/qrwlock_types.h     |  15 ++-
>  include/linux/atomic.h                  |   4 +
>  kernel/locking/qrwlock.c                |  86 +++--------------
>  9 files changed, 61 insertions(+), 272 deletions(-)
> 

Will, I see the same performance improvements that I was getting in v2 of the
patch. I will continue to run these patches on multiple systems over the next
few weeks, months for stability/functionality testing as well.

Tested-by: Adam Wallis <awallis@codeaurora.org>

-- 
Adam Wallis
Qualcomm Datacenter Technologies as an affiliate of Qualcomm Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project.

  parent reply	other threads:[~2017-10-12 13:16 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-12 12:20 [PATCH v3 0/5] Switch arm64 over to qrwlock Will Deacon
2017-10-12 12:20 ` Will Deacon
2017-10-12 12:20 ` [PATCH v3 1/5] kernel/locking: Use struct qrwlock instead of struct __qrwlock Will Deacon
2017-10-12 12:20   ` Will Deacon
2017-10-25 10:13   ` [tip:locking/core] locking/qrwlock: Use 'struct qrwlock' instead of 'struct __qrwlock' tip-bot for Will Deacon
2017-10-12 12:20 ` [PATCH v3 2/5] locking/atomic: Add atomic_cond_read_acquire Will Deacon
2017-10-12 12:20   ` Will Deacon
2017-10-25 10:14   ` [tip:locking/core] locking/atomic: Add atomic_cond_read_acquire() tip-bot for Will Deacon
2017-10-12 12:20 ` [PATCH v3 3/5] kernel/locking: Use atomic_cond_read_acquire when spinning in qrwlock Will Deacon
2017-10-12 12:20   ` Will Deacon
2017-10-25 10:14   ` [tip:locking/core] locking/qrwlock: Use atomic_cond_read_acquire() " tip-bot for Will Deacon
2017-10-12 12:20 ` [PATCH v3 4/5] arm64: locking: Move rwlock implementation over to qrwlocks Will Deacon
2017-10-12 12:20   ` Will Deacon
2017-10-25 10:14   ` [tip:locking/core] locking/qrwlock, arm64: " tip-bot for Will Deacon
2017-10-12 12:20 ` [PATCH v3 5/5] kernel/locking: Prevent slowpath writers getting held up by fastpath Will Deacon
2017-10-12 12:20   ` Will Deacon
2017-10-25 10:15   ` [tip:locking/core] locking/qrwlock: " tip-bot for Will Deacon
2017-10-12 13:16 ` Adam Wallis [this message]
2017-10-12 13:16   ` [PATCH v3 0/5] Switch arm64 over to qrwlock Adam Wallis
2017-10-19 16:53 ` Will Deacon
2017-10-19 16:53   ` Will Deacon
2017-10-24 14:48   ` Will Deacon
2017-10-24 14:48     ` Will Deacon
2017-10-24 15:40     ` Ingo Molnar
2017-10-24 15:40       ` Ingo Molnar
2017-10-25  8:36       ` Peter Zijlstra
2017-10-25  8:36         ` Peter Zijlstra
2017-10-28  6:10   ` chengjian (D)
2017-10-28  6:10     ` chengjian (D)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53399b22-8062-aa06-8569-e3fb0ae70ff0@codeaurora.org \
    --to=awallis@codeaurora.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.