From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Tejun Heo <tj@kernel.org>
Cc: Andrew Victor <linux@maxim.org.za>,
Nicolas Ferre <nicolas.ferre@atmel.com>,
Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
linux-ide@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pata_at91: fix ata_host_activate() failure handling
Date: Mon, 31 Mar 2014 21:59:38 +0400 [thread overview]
Message-ID: <5339AD0A.6050404@cogentembedded.com> (raw)
In-Reply-To: <3354637.ASvWtLs5Rq@amdc1032>
Hello.
On 03/31/2014 09:51 PM, Bartlomiej Zolnierkiewicz wrote:
> Add missing clk_put() call to ata_host_activate() failure path.
> Cc: Andrew Victor <linux@maxim.org.za>
> Cc: Nicolas Ferre <nicolas.ferre@atmel.com>
> Cc: Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>
> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> ---
> drivers/ata/pata_at91.c | 11 ++++++-----
> 1 file changed, 6 insertions(+), 5 deletions(-)
> Index: b/drivers/ata/pata_at91.c
> ===================================================================
> --- a/drivers/ata/pata_at91.c 2014-03-14 16:45:04.196724381 +0100
> +++ b/drivers/ata/pata_at91.c 2014-03-31 17:46:40.127677782 +0200
> @@ -407,12 +407,13 @@ static int pata_at91_probe(struct platfo
>
> host->private_data = info;
>
> - return ata_host_activate(host, gpio_is_valid(irq) ? gpio_to_irq(irq) : 0,
> - gpio_is_valid(irq) ? ata_sff_interrupt : NULL,
> - irq_flags, &pata_at91_sht);
> + ret = ata_host_activate(host, gpio_is_valid(irq) ? gpio_to_irq(irq) : 0,
> + gpio_is_valid(irq) ? ata_sff_interrupt : NULL,
> + irq_flags, &pata_at91_sht);
> + if (ret)
> + goto err_put;
>
> - if (!ret)
> - return 0;
> + return 0;
Hm, I have once fixed that (see that *if* (!ret)) but looks like a later
commit 477c87e90853d136b188c50c0e4a93d01cad872e (ARM: at91/pata: use
gpio_is_valid to check the gpio) broke it again. :-( Would be good if the
changelog did mention that...
MBR, Sergei
WARNING: multiple messages have this Message-ID (diff)
From: sergei.shtylyov@cogentembedded.com (Sergei Shtylyov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] pata_at91: fix ata_host_activate() failure handling
Date: Mon, 31 Mar 2014 21:59:38 +0400 [thread overview]
Message-ID: <5339AD0A.6050404@cogentembedded.com> (raw)
In-Reply-To: <3354637.ASvWtLs5Rq@amdc1032>
Hello.
On 03/31/2014 09:51 PM, Bartlomiej Zolnierkiewicz wrote:
> Add missing clk_put() call to ata_host_activate() failure path.
> Cc: Andrew Victor <linux@maxim.org.za>
> Cc: Nicolas Ferre <nicolas.ferre@atmel.com>
> Cc: Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>
> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> ---
> drivers/ata/pata_at91.c | 11 ++++++-----
> 1 file changed, 6 insertions(+), 5 deletions(-)
> Index: b/drivers/ata/pata_at91.c
> ===================================================================
> --- a/drivers/ata/pata_at91.c 2014-03-14 16:45:04.196724381 +0100
> +++ b/drivers/ata/pata_at91.c 2014-03-31 17:46:40.127677782 +0200
> @@ -407,12 +407,13 @@ static int pata_at91_probe(struct platfo
>
> host->private_data = info;
>
> - return ata_host_activate(host, gpio_is_valid(irq) ? gpio_to_irq(irq) : 0,
> - gpio_is_valid(irq) ? ata_sff_interrupt : NULL,
> - irq_flags, &pata_at91_sht);
> + ret = ata_host_activate(host, gpio_is_valid(irq) ? gpio_to_irq(irq) : 0,
> + gpio_is_valid(irq) ? ata_sff_interrupt : NULL,
> + irq_flags, &pata_at91_sht);
> + if (ret)
> + goto err_put;
>
> - if (!ret)
> - return 0;
> + return 0;
Hm, I have once fixed that (see that *if* (!ret)) but looks like a later
commit 477c87e90853d136b188c50c0e4a93d01cad872e (ARM: at91/pata: use
gpio_is_valid to check the gpio) broke it again. :-( Would be good if the
changelog did mention that...
MBR, Sergei
next prev parent reply other threads:[~2014-03-31 17:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-31 17:51 [PATCH] pata_at91: fix ata_host_activate() failure handling Bartlomiej Zolnierkiewicz
2014-03-31 17:51 ` Bartlomiej Zolnierkiewicz
2014-03-31 17:59 ` Sergei Shtylyov [this message]
2014-03-31 17:59 ` Sergei Shtylyov
2014-04-02 17:19 ` Tejun Heo
2014-04-02 17:19 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5339AD0A.6050404@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=b.zolnierkie@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@maxim.org.za \
--cc=nicolas.ferre@atmel.com \
--cc=plagnioj@jcrosoft.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.