Re: [PATCH 1/3] ASoC: alc5632: add an of_match table

[Stephen Warren <swarren@wwwdotorg.org>]

On 03/31/2014 12:53 PM, Daniel Mack wrote:
> On 03/31/2014 08:38 PM, Stephen Warren wrote:
>> From: Stephen Warren <swarren@nvidia.com>
>>
>> Add a device tree match table. This serves to make the driver's support
>> of device tree more explicit. Perhaps the fallback for DT matching to
>> using the i2c_device_id table will go away one day, since it fails in
>> face of devices from different vendors with the same name.
>>
>> Signed-off-by: Stephen Warren <swarren@nvidia.com>
>> ---
>>  sound/soc/codecs/alc5632.c | 7 +++++++
>>  1 file changed, 7 insertions(+)
>>
>> diff --git a/sound/soc/codecs/alc5632.c b/sound/soc/codecs/alc5632.c
>> index 3ee8d4e41a99..85942ca36cbf 100644
>> --- a/sound/soc/codecs/alc5632.c
>> +++ b/sound/soc/codecs/alc5632.c
>> @@ -1190,11 +1190,18 @@ static const struct i2c_device_id alc5632_i2c_table[] = {
>>  };
>>  MODULE_DEVICE_TABLE(i2c, alc5632_i2c_table);
>>  
>> +static const struct of_device_id alc5632_of_match[] = {
>> +	{ .compatible = "realtek,alc5632", },
> 
> In order to make them usable with the simple-card machine driver, all
> codecs that have DT bindings should be visible in Kconfig. Maybe this
> can be done in a subsequent patch though.

I personally don't need to use that machine driver; the drivers patched
in this series are all already in use on Tegra using DT via other
machine drivers.