From: Stephen Warren <swarren@wwwdotorg.org>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: alsa-devel@alsa-project.org, Mark Brown <broonie@kernel.org>,
Stephen Warren <swarren@nvidia.com>,
Liam Girdwood <lgirdwood@gmail.com>
Subject: Re: [PATCH 1/3] ASoC: alc5632: add an of_match table
Date: Mon, 31 Mar 2014 13:47:04 -0600 [thread overview]
Message-ID: <5339C638.5030303@wwwdotorg.org> (raw)
In-Reply-To: <20140331192349.GA3431@mithrandir>
On 03/31/2014 01:23 PM, Thierry Reding wrote:
> On Mon, Mar 31, 2014 at 12:38:16PM -0600, Stephen Warren wrote:
> [...]
>> diff --git a/sound/soc/codecs/alc5632.c b/sound/soc/codecs/alc5632.c
> [...]
>> +static const struct of_device_id alc5632_of_match[] = {
>> + { .compatible = "realtek,alc5632", },
>> + { }
>> +};
>> +MODULE_DEVICE_TABLE(of, alc5632_of_match);
>
> Doesn't this need #ifdef protection to prevent warnings about this being
> unused for !OF?
What I really meant to do was reference these tables directly rather
than using of_match_ptr().
There seems to be a mix of ifdef'ing the table and using of_match_ptr()
vs. the other way around in ASoC. Mark, do you have a preference which
way to go?
next prev parent reply other threads:[~2014-03-31 19:55 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-31 18:38 [PATCH 1/3] ASoC: alc5632: add an of_match table Stephen Warren
2014-03-31 18:38 ` [PATCH 2/3] ASoC: tlv320aic23: " Stephen Warren
2014-04-01 11:45 ` Mark Brown
2014-03-31 18:38 ` [PATCH 3/3] ASoC: max98090: " Stephen Warren
2014-04-01 11:46 ` Mark Brown
2014-03-31 18:53 ` [PATCH 1/3] ASoC: alc5632: " Daniel Mack
2014-03-31 18:58 ` Stephen Warren
2014-03-31 19:23 ` Thierry Reding
2014-03-31 19:47 ` Stephen Warren [this message]
2014-03-31 22:45 ` Mark Brown
2014-03-31 22:53 ` Stephen Warren
2014-03-31 23:05 ` Mark Brown
2014-04-04 9:06 ` Thierry Reding
2014-04-01 11:40 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5339C638.5030303@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=swarren@nvidia.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.