From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: jon@ringle.org
Cc: plagnioj@jcrosoft.com, linux-fbdev@vger.kernel.org,
linux-kernel@vger.kernel.org, Jon Ringle <jringle@gridpoint.com>
Subject: Re: [PATCH] video: da8xx-fb: Add support for Densitron 84-0023-001T
Date: Tue, 01 Apr 2014 09:14:42 +0000 [thread overview]
Message-ID: <533A8382.7070603@ti.com> (raw)
In-Reply-To: <1394042711-7907-1-git-send-email-jon@ringle.org>
[-- Attachment #1: Type: text/plain, Size: 838 bytes --]
Hi,
On 05/03/14 20:05, jon@ringle.org wrote:
> From: Jon Ringle <jringle@gridpoint.com>
>
> Signed-off-by: Jon Ringle <jringle@gridpoint.com>
> ---
> drivers/video/da8xx-fb.c | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/drivers/video/da8xx-fb.c b/drivers/video/da8xx-fb.c
> index e7f5937..83c43b2 100644
> --- a/drivers/video/da8xx-fb.c
> +++ b/drivers/video/da8xx-fb.c
> @@ -243,6 +243,20 @@ static struct fb_videomode known_lcd_panels[] = {
> .sync = FB_SYNC_HOR_HIGH_ACT | FB_SYNC_VERT_HIGH_ACT,
> .flag = 0,
> },
> + [3] = {
> + /* Densitron 84-0023-001T */
> + .name = "Densitron_LCD",
I think the name should be a bit better. Why it is not something like
"Densitron_84-0023-001T", which is the style the other panels use?
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 901 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: <jon@ringle.org>
Cc: <plagnioj@jcrosoft.com>, <linux-fbdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
Jon Ringle <jringle@gridpoint.com>
Subject: Re: [PATCH] video: da8xx-fb: Add support for Densitron 84-0023-001T
Date: Tue, 1 Apr 2014 12:14:42 +0300 [thread overview]
Message-ID: <533A8382.7070603@ti.com> (raw)
In-Reply-To: <1394042711-7907-1-git-send-email-jon@ringle.org>
[-- Attachment #1: Type: text/plain, Size: 838 bytes --]
Hi,
On 05/03/14 20:05, jon@ringle.org wrote:
> From: Jon Ringle <jringle@gridpoint.com>
>
> Signed-off-by: Jon Ringle <jringle@gridpoint.com>
> ---
> drivers/video/da8xx-fb.c | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/drivers/video/da8xx-fb.c b/drivers/video/da8xx-fb.c
> index e7f5937..83c43b2 100644
> --- a/drivers/video/da8xx-fb.c
> +++ b/drivers/video/da8xx-fb.c
> @@ -243,6 +243,20 @@ static struct fb_videomode known_lcd_panels[] = {
> .sync = FB_SYNC_HOR_HIGH_ACT | FB_SYNC_VERT_HIGH_ACT,
> .flag = 0,
> },
> + [3] = {
> + /* Densitron 84-0023-001T */
> + .name = "Densitron_LCD",
I think the name should be a bit better. Why it is not something like
"Densitron_84-0023-001T", which is the style the other panels use?
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 901 bytes --]
next prev parent reply other threads:[~2014-04-01 9:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-05 18:05 [PATCH] video: da8xx-fb: Add support for Densitron 84-0023-001T jon
2014-03-05 18:05 ` jon
2014-03-26 16:56 ` Jon Ringle
2014-03-26 16:56 ` Jon Ringle
2014-04-01 9:14 ` Tomi Valkeinen [this message]
2014-04-01 9:14 ` Tomi Valkeinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=533A8382.7070603@ti.com \
--to=tomi.valkeinen@ti.com \
--cc=jon@ringle.org \
--cc=jringle@gridpoint.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=plagnioj@jcrosoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.