From: Roger Quadros <rogerq@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] ahci: Fix cache align error messages
Date: Tue, 1 Apr 2014 16:40:31 +0300 [thread overview]
Message-ID: <533AC1CF.60508@ti.com> (raw)
In-Reply-To: <9ADB7F3FA4136F45A1D33301B450724601BAA8305288@IL-MB01.marvell.com>
Hi Eli,
On 04/01/2014 04:09 PM, Eli Nidam wrote:
> Hi Roger,
>
> In u-boot I tried to run twice the command ?scsi init? and on the second time it?s hung,,
> after debug I found the patch ahci: Fix cache align error messages
> replace the malloc with ALLOC_CACHE_ALIGN_BUFFER.
> And remove the line free(tmpid);
>
> 1. One more free should be remove in line 653 ?free(ataid[port]);?
> This is why the second scsi init is hung.
> 2. Actually I revert this patch because the ALLOC_CACHE_ALIGN_BUFFER is use
> the buffer from stack and the ataid[] is used from other routine.
You are right. My patch is all messed up and better to revert it, sorry.
Do you still get the below messages after the revert?
ERROR: v7_dcache_inval_range - start address is not aligned - 0xfee46648
ERROR: v7_dcache_inval_range - stop address is not aligned - 0xfee46848
cheers,
-roger
>
> Please let me if I wrong.
>
> Thanks
>
> Eli Nidam
> Marvell Israel ? SW Engineer
> 6 Hamada Street
> Mordot HaCarmel Industrial Park
> Yokneam, 20692, Israel
> Email: elini at marvell.com
> Office: +972.4.9091167 - OnNet: 704.1xxx
> Fax: +972.4.9091501
> Mobile: +972.54.2490706
> Web site: http://www.marvell.com
>
> This message may contain confidential, proprietary or legally privileged information. The information is intended only for the use of the individual or entity named above. If the reader of this message is not the intended recipient, you are hereby notified that any dissemination, distribution or copying of this communication is strictly prohibited. If you have received this communication in error, please notify us immediately by telephone or by e-mail and delete the message from your computer.
>
>
next parent reply other threads:[~2014-04-01 13:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <9ADB7F3FA4136F45A1D33301B450724601BAA8305288@IL-MB01.marvell.com>
2014-04-01 13:40 ` Roger Quadros [this message]
2014-04-01 14:17 ` [U-Boot] ahci: Fix cache align error messages Eli Nidam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=533AC1CF.60508@ti.com \
--to=rogerq@ti.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.