[U-Boot] ahci: Fix cache align error messages

[U-Boot] ahci: Fix cache align error messages

[Roger Quadros]

Hi Eli,

On 04/01/2014 04:09 PM, Eli Nidam wrote:
> Hi Roger,
> 
> In u-boot I tried to run twice the command ?scsi init? and on the second time it?s hung,,
> after debug I found the patch  ahci: Fix cache align error messages 
> replace the malloc with ALLOC_CACHE_ALIGN_BUFFER.
> And remove the line free(tmpid);
> 
> 1. One more free should be remove in line 653 ?free(ataid[port]);?  
>     This is why the second scsi init is hung.
> 2. Actually I revert this patch because the  ALLOC_CACHE_ALIGN_BUFFER is use
>     the buffer from stack and the ataid[] is used from other routine.

You are right. My patch is all messed up and better to revert it, sorry.

Do you still get the below messages after the revert?

ERROR: v7_dcache_inval_range - start address is not aligned - 0xfee46648
ERROR: v7_dcache_inval_range - stop address is not aligned - 0xfee46848

cheers,
-roger

> 
> Please let me if I wrong.
> 
> Thanks
> 
> Eli Nidam
> Marvell Israel ? SW Engineer
> 6 Hamada Street 
> Mordot HaCarmel Industrial Park
> Yokneam, 20692, Israel
> Email: elini at marvell.com
> Office:  +972.4.9091167 - OnNet: 704.1xxx
> Fax:      +972.4.9091501
> Mobile: +972.54.2490706
> Web site: http://www.marvell.com 
>  
> This message may contain confidential, proprietary or legally privileged information. The information is intended only for the use of the individual or entity named above. If the reader of this message is not the intended recipient, you are hereby notified that any dissemination, distribution or copying of this communication is strictly prohibited. If you have received this communication in error, please notify us immediately by telephone or by e-mail and delete the message from your computer.
> 
> 

[U-Boot] ahci: Fix cache align error messages

[Eli Nidam]

Hi Roger,

I used the definition CONFIG_SYS_DCACHE_OFF (in our u-boot the cache is off)

For this reason I didn't get this message.

Thanks

Eli


-----Original Message-----
From: Roger Quadros [mailto:rogerq at ti.com] 
Sent: Tuesday, April 01, 2014 4:41 PM
To: Eli Nidam; Rini, Tom
Cc: aneesh at ti.com; morpheus.ibis at gmail.com; Omri Itach; U-Boot-Denx
Subject: Re: ahci: Fix cache align error messages

Hi Eli,

On 04/01/2014 04:09 PM, Eli Nidam wrote:
> Hi Roger,
> 
> In u-boot I tried to run twice the command "scsi init" and on the second time it's hung,,
> after debug I found the patch  ahci: Fix cache align error messages 
> replace the malloc with ALLOC_CACHE_ALIGN_BUFFER.
> And remove the line free(tmpid);
> 
> 1. One more free should be remove in line 653 "free(ataid[port]);"  
>     This is why the second scsi init is hung.
> 2. Actually I revert this patch because the  ALLOC_CACHE_ALIGN_BUFFER is use
>     the buffer from stack and the ataid[] is used from other routine.

You are right. My patch is all messed up and better to revert it, sorry.

Do you still get the below messages after the revert?

ERROR: v7_dcache_inval_range - start address is not aligned - 0xfee46648
ERROR: v7_dcache_inval_range - stop address is not aligned - 0xfee46848

cheers,
-roger

> 
> Please let me if I wrong.
> 
> Thanks
> 
> Eli Nidam
> Marvell Israel - SW Engineer
> 6 Hamada Street 
> Mordot HaCarmel Industrial Park
> Yokneam, 20692, Israel
> Email: elini at marvell.com
> Office:  +972.4.9091167 - OnNet: 704.1xxx
> Fax:      +972.4.9091501
> Mobile: +972.54.2490706
> Web site: http://www.marvell.com 
>  
> This message may contain confidential, proprietary or legally privileged information. The information is intended only for the use of the individual or entity named above. If the reader of this message is not the intended recipient, you are hereby notified that any dissemination, distribution or copying of this communication is strictly prohibited. If you have received this communication in error, please notify us immediately by telephone or by e-mail and delete the message from your computer.
> 
>