From: Alexander Graf <agraf@suse.de>
To: Christian Borntraeger <borntraeger@de.ibm.com>
Cc: qemu-devel <qemu-devel@nongnu.org>, KVM <kvm@vger.kernel.org>,
linux-s390 <linux-s390@vger.kernel.org>,
Cornelia Huck <cornelia.huck@de.ibm.com>,
Michael Mueller <mimu@linux.vnet.ibm.com>,
Ekaterina Tumanova <tumanova@linux.vnet.ibm.com>,
Jens Freimann <jfrei@linux.vnet.ibm.com>
Subject: Re: [PATCH/RFC] KVM: s390: Add S390 configuration and control kvm device
Date: Tue, 01 Apr 2014 16:58:53 +0200 [thread overview]
Message-ID: <533AD42D.8060504@suse.de> (raw)
In-Reply-To: <1396363663-50450-2-git-send-email-borntraeger@de.ibm.com>
On 04/01/2014 04:47 PM, Christian Borntraeger wrote:
> From: Ekaterina Tumanova <tumanova@linux.vnet.ibm.com>
>
> Add KVM_DEV_TYPE_S390_CONFIG kvm device that contains
> configuration and control attributes of particular vm.
> The device is created by KVM_CREATE_DEVICE ioctl.
> The attributes may be retrieved and stored by calling
> KVM_GET_DEVICE_ATTR and KVM_SET_DEVICE_ATTR ioctls.
>
> Signed-off-by: Ekaterina Tumanova <tumanova@linux.vnet.ibm.com>
> Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
I don't think a device is particularly the best fit. A device can
usually be instantiated multiple times. The configuration device can
only be created once. A device also gets created by user space which
enables it to receive the fd to drive it. Your device has to be created
during VM creation.
I think VM configuration is common enough to just make this a separate
interface.
Alex
WARNING: multiple messages have this Message-ID (diff)
From: Alexander Graf <agraf@suse.de>
To: Christian Borntraeger <borntraeger@de.ibm.com>
Cc: linux-s390 <linux-s390@vger.kernel.org>,
Michael Mueller <mimu@linux.vnet.ibm.com>,
KVM <kvm@vger.kernel.org>,
Ekaterina Tumanova <tumanova@linux.vnet.ibm.com>,
qemu-devel <qemu-devel@nongnu.org>,
Jens Freimann <jfrei@linux.vnet.ibm.com>,
Cornelia Huck <cornelia.huck@de.ibm.com>
Subject: Re: [Qemu-devel] [PATCH/RFC] KVM: s390: Add S390 configuration and control kvm device
Date: Tue, 01 Apr 2014 16:58:53 +0200 [thread overview]
Message-ID: <533AD42D.8060504@suse.de> (raw)
In-Reply-To: <1396363663-50450-2-git-send-email-borntraeger@de.ibm.com>
On 04/01/2014 04:47 PM, Christian Borntraeger wrote:
> From: Ekaterina Tumanova <tumanova@linux.vnet.ibm.com>
>
> Add KVM_DEV_TYPE_S390_CONFIG kvm device that contains
> configuration and control attributes of particular vm.
> The device is created by KVM_CREATE_DEVICE ioctl.
> The attributes may be retrieved and stored by calling
> KVM_GET_DEVICE_ATTR and KVM_SET_DEVICE_ATTR ioctls.
>
> Signed-off-by: Ekaterina Tumanova <tumanova@linux.vnet.ibm.com>
> Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
I don't think a device is particularly the best fit. A device can
usually be instantiated multiple times. The configuration device can
only be created once. A device also gets created by user space which
enables it to receive the fd to drive it. Your device has to be created
during VM creation.
I think VM configuration is common enough to just make this a separate
interface.
Alex
next prev parent reply other threads:[~2014-04-01 14:58 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-01 14:47 [PATCH/RFC] s390: Provide a configuration and control device Christian Borntraeger
2014-04-01 14:47 ` [Qemu-devel] " Christian Borntraeger
2014-04-01 14:47 ` [PATCH/RFC] KVM: s390: Add S390 configuration and control kvm device Christian Borntraeger
2014-04-01 14:47 ` [Qemu-devel] " Christian Borntraeger
2014-04-01 14:58 ` Alexander Graf [this message]
2014-04-01 14:58 ` Alexander Graf
2014-04-01 15:04 ` Christian Borntraeger
2014-04-01 15:04 ` [Qemu-devel] " Christian Borntraeger
2014-04-01 15:12 ` Alexander Graf
2014-04-01 15:12 ` [Qemu-devel] " Alexander Graf
2014-04-01 19:19 ` Christian Borntraeger
2014-04-01 19:19 ` [Qemu-devel] " Christian Borntraeger
2014-04-01 19:36 ` Alexander Graf
2014-04-01 19:36 ` [Qemu-devel] " Alexander Graf
2014-04-01 20:08 ` Christian Borntraeger
2014-04-01 20:08 ` [Qemu-devel] " Christian Borntraeger
2014-04-01 19:37 ` Alexander Graf
2014-04-01 19:37 ` [Qemu-devel] " Alexander Graf
2014-04-01 14:47 ` [PATCH/RFC] s390x/kvm: implement and use QEMU config device for s390 Christian Borntraeger
2014-04-01 14:47 ` [Qemu-devel] " Christian Borntraeger
2014-04-01 15:38 ` Paolo Bonzini
2014-04-01 15:38 ` [Qemu-devel] " Paolo Bonzini
2014-04-01 18:56 ` Christian Borntraeger
2014-04-01 18:56 ` [Qemu-devel] " Christian Borntraeger
2014-04-01 14:59 ` [PATCH/RFC] s390: Provide a configuration and control device Alexander Graf
2014-04-01 14:59 ` [Qemu-devel] " Alexander Graf
2014-04-01 19:23 ` Christian Borntraeger
2014-04-01 19:23 ` [Qemu-devel] " Christian Borntraeger
2014-04-01 19:37 ` Alexander Graf
2014-04-01 19:37 ` [Qemu-devel] " Alexander Graf
2014-04-02 8:31 ` Christian Borntraeger
2014-04-02 8:31 ` [Qemu-devel] " Christian Borntraeger
2014-04-02 8:39 ` Alexander Graf
2014-04-02 8:39 ` [Qemu-devel] " Alexander Graf
2014-04-02 8:54 ` Christian Borntraeger
2014-04-02 8:54 ` [Qemu-devel] " Christian Borntraeger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=533AD42D.8060504@suse.de \
--to=agraf@suse.de \
--cc=borntraeger@de.ibm.com \
--cc=cornelia.huck@de.ibm.com \
--cc=jfrei@linux.vnet.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=mimu@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=tumanova@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.