All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dirk Behme <dirk.behme@de.bosch.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] ARM: Add workaround for Cortex-A9 errata 794072
Date: Wed, 2 Apr 2014 08:41:38 +0200	[thread overview]
Message-ID: <533BB122.90304@de.bosch.com> (raw)
In-Reply-To: <1396409638-6257-2-git-send-email-nitin.garg@freescale.com>

On 02.04.2014 05:33, nitin.garg at freescale.com wrote:
> From: Nitin Garg <nitin.garg@freescale.com>
>
> A short loop including a DMB instruction might cause a denial of
> service on another processor which executes a CP15 broadcast operation.
> Exists on r1, r2, r3, r4 revisions.
>
> Signed-off-by: Nitin Garg <nitin.garg@freescale.com>
> ---
>   README                     |    1 +
>   arch/arm/cpu/armv7/start.S |    5 +++++
>   2 files changed, 6 insertions(+), 0 deletions(-)
>
> diff --git a/README b/README
> index 7cb7c4f..a496c65 100644
> --- a/README
> +++ b/README
> @@ -566,6 +566,7 @@ The following options need to be configured:
>   		CONFIG_ARM_ERRATA_742230
>   		CONFIG_ARM_ERRATA_743622
>   		CONFIG_ARM_ERRATA_751472
> +		CONFIG_ARM_ERRATA_794072
>
>   		If set, the workarounds for these ARM errata are applied early
>   		during U-Boot startup. Note that these options force the
> diff --git a/arch/arm/cpu/armv7/start.S b/arch/arm/cpu/armv7/start.S
> index ac1e55a..b87a378 100644
> --- a/arch/arm/cpu/armv7/start.S
> +++ b/arch/arm/cpu/armv7/start.S
> @@ -222,6 +222,11 @@ ENTRY(cpu_init_cp15)
>   	orr	r0, r0, #1 << 11	@ set bit #11
>   	mcr	p15, 0, r0, c15, c0, 1	@ write diagnostic register
>   #endif
> +#ifdef CONFIG_ARM_ERRATA_794072
> +	mrc	p15, 0, r0, c15, c0, 1	@ read diagnostic register
> +	orr	r0, r0, #1 << 4		@ set bit #4
> +	mcr	p15, 0, r0, c15, c0, 1	@ write diagnostic register
> +#endif

Where is the difference between the errata code for above new 
CONFIG_ARM_ERRATA_794072 and the existing

#ifdef CONFIG_ARM_ERRATA_742230
	mrc	p15, 0, r0, c15, c0, 1	@ read diagnostic register
	orr	r0, r0, #1 << 4		@ set bit #4
	mcr	p15, 0, r0, c15, c0, 1	@ write diagnostic register
#endif

?

Maybe we should just do a

#if (defined(CONFIG_ARM_ERRATA_794072) || defined(CONFIG_ARM_ERRATA_742230))

?

Best regards

Dirk

  reply	other threads:[~2014-04-02  6:41 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-02  3:33 [U-Boot] [PATCH 0/2] Add workaround for Cortex-A9 errata nitin.garg at freescale.com
2014-04-02  3:33 ` [U-Boot] [PATCH 1/2] ARM: Add workaround for Cortex-A9 errata 794072 nitin.garg at freescale.com
2014-04-02  6:41   ` Dirk Behme [this message]
2014-04-02 12:43     ` Nitin Garg
2014-04-02  3:33 ` [U-Boot] [PATCH 2/2] ARM: Add workaround for Cortex-A9 errata 761320 nitin.garg at freescale.com
2014-04-02  6:45   ` Dirk Behme
2014-04-02 12:44     ` Nitin Garg
2014-04-02  4:27 ` [U-Boot] [PATCH 0/2] Add workaround for Cortex-A9 errata Fabio Estevam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=533BB122.90304@de.bosch.com \
    --to=dirk.behme@de.bosch.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.