All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dirk Behme <dirk.behme@de.bosch.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/2] ARM: Add workaround for Cortex-A9 errata 761320
Date: Wed, 2 Apr 2014 08:45:56 +0200	[thread overview]
Message-ID: <533BB224.3020900@de.bosch.com> (raw)
In-Reply-To: <1396409638-6257-3-git-send-email-nitin.garg@freescale.com>

On 02.04.2014 05:33, nitin.garg at freescale.com wrote:
> From: Nitin Garg <nitin.garg@freescale.com>
>
> Full cache line writes to the same memory region from at least two
> processors might deadlock the processor. Exists on r1, r2, r3
> revisions.
>
> Signed-off-by: Nitin Garg <nitin.garg@freescale.com>
> ---
>   README                     |    1 +
>   arch/arm/cpu/armv7/start.S |    5 +++++
>   2 files changed, 6 insertions(+), 0 deletions(-)
>
> diff --git a/README b/README
> index a496c65..b7c0f68 100644
> --- a/README
> +++ b/README
> @@ -567,6 +567,7 @@ The following options need to be configured:
>   		CONFIG_ARM_ERRATA_743622
>   		CONFIG_ARM_ERRATA_751472
>   		CONFIG_ARM_ERRATA_794072
> +		CONFIG_ARM_ERRATA_761320
>
>   		If set, the workarounds for these ARM errata are applied early
>   		during U-Boot startup. Note that these options force the
> diff --git a/arch/arm/cpu/armv7/start.S b/arch/arm/cpu/armv7/start.S
> index b87a378..1229476 100644
> --- a/arch/arm/cpu/armv7/start.S
> +++ b/arch/arm/cpu/armv7/start.S
> @@ -227,6 +227,11 @@ ENTRY(cpu_init_cp15)
>   	orr	r0, r0, #1 << 4		@ set bit #4
>   	mcr	p15, 0, r0, c15, c0, 1	@ write diagnostic register
>   #endif
> +#ifdef CONFIG_ARM_ERRATA_761320
> +	mrc	p15, 0, r0, c15, c0, 1	@ read diagnostic register
> +	orr	r0, r0, #1 << 21	@ set bit #21
> +	mcr	p15, 0, r0, c15, c0, 1	@ write diagnostic register
> +#endif

Is there any reason why you dropped the check for r4p0

cmp	r6, #0x40	@ present prior to r4p0

which you still had in

http://www.spinics.net/lists/arm-kernel/msg319223.html

?

Best regards

Dirk

  reply	other threads:[~2014-04-02  6:45 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-02  3:33 [U-Boot] [PATCH 0/2] Add workaround for Cortex-A9 errata nitin.garg at freescale.com
2014-04-02  3:33 ` [U-Boot] [PATCH 1/2] ARM: Add workaround for Cortex-A9 errata 794072 nitin.garg at freescale.com
2014-04-02  6:41   ` Dirk Behme
2014-04-02 12:43     ` Nitin Garg
2014-04-02  3:33 ` [U-Boot] [PATCH 2/2] ARM: Add workaround for Cortex-A9 errata 761320 nitin.garg at freescale.com
2014-04-02  6:45   ` Dirk Behme [this message]
2014-04-02 12:44     ` Nitin Garg
2014-04-02  4:27 ` [U-Boot] [PATCH 0/2] Add workaround for Cortex-A9 errata Fabio Estevam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=533BB224.3020900@de.bosch.com \
    --to=dirk.behme@de.bosch.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.