From: Guenter Roeck <linux@roeck-us.net>
To: Julia Lawall <Julia.Lawall@lip6.fr>, Wim Van Sebroeck <wim@iguana.be>
Cc: kernel-janitors@vger.kernel.org, linux-watchdog@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] watchdog: via_wdt: replace del_timer by del_timer_sync
Date: Wed, 02 Apr 2014 14:08:59 +0000 [thread overview]
Message-ID: <533C19FB.8090302@roeck-us.net> (raw)
In-Reply-To: <1396360159-16244-4-git-send-email-Julia.Lawall@lip6.fr>
On 04/01/2014 06:49 AM, Julia Lawall wrote:
> From: Julia Lawall <Julia.Lawall@lip6.fr>
>
> Use del_timer_sync to ensure that the timer is stopped on all CPUs before
> the driver exits.
>
> This change was suggested by Thomas Gleixner.
>
> The semantic patch that makes this change is as follows:
> (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @r@
> identifier i,t,ex;
> @@
> struct t i = { .remove = ex, };
>
> @@
> identifier r.ex;
> @@
> ex(...) {
> <...
> - del_timer
> + del_timer_sync
> (...)
> ...>
> }
> // </smpl>
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
WARNING: multiple messages have this Message-ID (diff)
From: Guenter Roeck <linux@roeck-us.net>
To: Julia Lawall <Julia.Lawall@lip6.fr>, Wim Van Sebroeck <wim@iguana.be>
Cc: kernel-janitors@vger.kernel.org, linux-watchdog@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] watchdog: via_wdt: replace del_timer by del_timer_sync
Date: Wed, 02 Apr 2014 07:08:59 -0700 [thread overview]
Message-ID: <533C19FB.8090302@roeck-us.net> (raw)
In-Reply-To: <1396360159-16244-4-git-send-email-Julia.Lawall@lip6.fr>
On 04/01/2014 06:49 AM, Julia Lawall wrote:
> From: Julia Lawall <Julia.Lawall@lip6.fr>
>
> Use del_timer_sync to ensure that the timer is stopped on all CPUs before
> the driver exits.
>
> This change was suggested by Thomas Gleixner.
>
> The semantic patch that makes this change is as follows:
> (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @r@
> identifier i,t,ex;
> @@
> struct t i = { .remove = ex, };
>
> @@
> identifier r.ex;
> @@
> ex(...) {
> <...
> - del_timer
> + del_timer_sync
> (...)
> ...>
> }
> // </smpl>
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
next prev parent reply other threads:[~2014-04-02 14:08 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-01 13:49 [PATCH 0/3] replace del_timer by del_timer_sync Julia Lawall
2014-04-01 13:49 ` Julia Lawall
2014-04-01 13:49 ` Julia Lawall
2014-04-01 13:49 ` [PATCH 1/3] memstick: " Julia Lawall
2014-04-01 13:49 ` Julia Lawall
2014-04-01 13:49 ` [PATCH 2/3] ray_cs: " Julia Lawall
2014-04-01 13:49 ` Julia Lawall
2014-04-01 13:49 ` [PATCH 3/3] watchdog: via_wdt: " Julia Lawall
2014-04-01 13:49 ` Julia Lawall
2014-04-02 14:08 ` Guenter Roeck [this message]
2014-04-02 14:08 ` Guenter Roeck
2014-05-26 18:49 ` Wim Van Sebroeck
2014-05-26 18:49 ` Wim Van Sebroeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=533C19FB.8090302@roeck-us.net \
--to=linux@roeck-us.net \
--cc=Julia.Lawall@lip6.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.