All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tero Kristo <t-kristo@ti.com>
To: Peter Ujfalusi <peter.ujfalusi@ti.com>,
	Mike Turquette <mturquette@linaro.org>
Cc: Tony Lindgren <tony@atomide.com>,
	linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] clk: ti: clk-7xx: Correct ABE DPLL configuration
Date: Wed, 2 Apr 2014 17:12:18 +0300	[thread overview]
Message-ID: <533C1AC2.1000307@ti.com> (raw)
In-Reply-To: <1396446525-20302-1-git-send-email-peter.ujfalusi@ti.com>

On 04/02/2014 04:48 PM, Peter Ujfalusi wrote:
> ABE DPLL frequency need to be lowered from 361267200
> to 180633600 to facilitate the ATL requironments.
> The dpll_abe_m2x2_ck clock need to be set to double
> of ABE DPLL rate in order to have correct clocks
> for audio.

Do you have some sort of TRM reference for this?

-Tero

>
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
> ---
>   drivers/clk/ti/clk-7xx.c | 7 ++++++-
>   1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/clk/ti/clk-7xx.c b/drivers/clk/ti/clk-7xx.c
> index f7e40734c819..19a55bf407dd 100644
> --- a/drivers/clk/ti/clk-7xx.c
> +++ b/drivers/clk/ti/clk-7xx.c
> @@ -16,7 +16,7 @@
>   #include <linux/clkdev.h>
>   #include <linux/clk/ti.h>
>
> -#define DRA7_DPLL_ABE_DEFFREQ				361267200
> +#define DRA7_DPLL_ABE_DEFFREQ				180633600
>   #define DRA7_DPLL_GMAC_DEFFREQ				1000000000
>
>
> @@ -322,6 +322,11 @@ int __init dra7xx_dt_clk_init(void)
>   	if (rc)
>   		pr_err("%s: failed to configure ABE DPLL!\n", __func__);
>
> +	dpll_ck = clk_get_sys(NULL, "dpll_abe_m2x2_ck");
> +	rc = clk_set_rate(dpll_ck, DRA7_DPLL_ABE_DEFFREQ * 2);
> +	if (rc)
> +		pr_err("%s: failed to configure ABE DPLL m2x2!\n", __func__);
> +
>   	dpll_ck = clk_get_sys(NULL, "dpll_gmac_ck");
>   	rc = clk_set_rate(dpll_ck, DRA7_DPLL_GMAC_DEFFREQ);
>   	if (rc)
>


WARNING: multiple messages have this Message-ID (diff)
From: Tero Kristo <t-kristo@ti.com>
To: Peter Ujfalusi <peter.ujfalusi@ti.com>,
	Mike Turquette <mturquette@linaro.org>
Cc: Tony Lindgren <tony@atomide.com>, <linux-omap@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] clk: ti: clk-7xx: Correct ABE DPLL configuration
Date: Wed, 2 Apr 2014 17:12:18 +0300	[thread overview]
Message-ID: <533C1AC2.1000307@ti.com> (raw)
In-Reply-To: <1396446525-20302-1-git-send-email-peter.ujfalusi@ti.com>

On 04/02/2014 04:48 PM, Peter Ujfalusi wrote:
> ABE DPLL frequency need to be lowered from 361267200
> to 180633600 to facilitate the ATL requironments.
> The dpll_abe_m2x2_ck clock need to be set to double
> of ABE DPLL rate in order to have correct clocks
> for audio.

Do you have some sort of TRM reference for this?

-Tero

>
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
> ---
>   drivers/clk/ti/clk-7xx.c | 7 ++++++-
>   1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/clk/ti/clk-7xx.c b/drivers/clk/ti/clk-7xx.c
> index f7e40734c819..19a55bf407dd 100644
> --- a/drivers/clk/ti/clk-7xx.c
> +++ b/drivers/clk/ti/clk-7xx.c
> @@ -16,7 +16,7 @@
>   #include <linux/clkdev.h>
>   #include <linux/clk/ti.h>
>
> -#define DRA7_DPLL_ABE_DEFFREQ				361267200
> +#define DRA7_DPLL_ABE_DEFFREQ				180633600
>   #define DRA7_DPLL_GMAC_DEFFREQ				1000000000
>
>
> @@ -322,6 +322,11 @@ int __init dra7xx_dt_clk_init(void)
>   	if (rc)
>   		pr_err("%s: failed to configure ABE DPLL!\n", __func__);
>
> +	dpll_ck = clk_get_sys(NULL, "dpll_abe_m2x2_ck");
> +	rc = clk_set_rate(dpll_ck, DRA7_DPLL_ABE_DEFFREQ * 2);
> +	if (rc)
> +		pr_err("%s: failed to configure ABE DPLL m2x2!\n", __func__);
> +
>   	dpll_ck = clk_get_sys(NULL, "dpll_gmac_ck");
>   	rc = clk_set_rate(dpll_ck, DRA7_DPLL_GMAC_DEFFREQ);
>   	if (rc)
>


  reply	other threads:[~2014-04-02 14:12 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-02 13:48 [PATCH] clk: ti: clk-7xx: Correct ABE DPLL configuration Peter Ujfalusi
2014-04-02 13:48 ` Peter Ujfalusi
2014-04-02 14:12 ` Tero Kristo [this message]
2014-04-02 14:12   ` Tero Kristo
2014-04-03  6:29   ` Peter Ujfalusi
2014-04-03  6:29     ` Peter Ujfalusi
2014-04-24  9:11     ` Peter Ujfalusi
2014-04-24  9:11       ` Peter Ujfalusi
2014-04-24 15:03       ` Tero Kristo
2014-04-24 15:03         ` Tero Kristo
2014-05-06 13:39         ` Peter Ujfalusi
2014-05-06 13:39           ` Peter Ujfalusi
2014-05-19 12:29           ` Tero Kristo
2014-05-19 12:29             ` Tero Kristo
2014-07-14 10:10           ` Peter Ujfalusi
2014-07-14 10:10             ` Peter Ujfalusi
2014-07-29  6:27             ` Mike Turquette
2014-07-29  6:27               ` Mike Turquette
2014-07-29  8:23               ` Tero Kristo
2014-07-29  8:23                 ` Tero Kristo
2014-07-29 16:12                 ` Mike Turquette
2014-07-30  5:53                   ` Peter Ujfalusi
2014-07-30 12:27                     ` Tero Kristo
2014-07-30 22:42                       ` Mike Turquette
2014-07-31  6:37                         ` Tero Kristo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=533C1AC2.1000307@ti.com \
    --to=t-kristo@ti.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=mturquette@linaro.org \
    --cc=peter.ujfalusi@ti.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.