* [Qemu-trivial] [PATCH] Fix typo in eTSEC Ethernet controller
@ 2014-04-02 14:49 ` Fabien Chouteau
0 siblings, 0 replies; 6+ messages in thread
From: Fabien Chouteau @ 2014-04-02 14:49 UTC (permalink / raw)
To: qemu-devel, qemu-trivial; +Cc: peter.maydell, agraf, pbonzini
IRQ are lowered when ievent bit is cleared, so irq_pulse makes no sense
here...
Signed-off-by: Fabien Chouteau <chouteau@adacore.com>
---
hw/net/fsl_etsec/rings.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/net/fsl_etsec/rings.c b/hw/net/fsl_etsec/rings.c
index e36cfbe..d4a494f 100644
--- a/hw/net/fsl_etsec/rings.c
+++ b/hw/net/fsl_etsec/rings.c
@@ -159,7 +159,7 @@ static void ievent_set(eTSEC *etsec,
if ((flags & IEVENT_RXB && etsec->regs[IMASK].value & IMASK_RXBEN)
|| (flags & IEVENT_RXF && etsec->regs[IMASK].value & IMASK_RXFEN)) {
- qemu_irq_pulse(etsec->rx_irq);
+ qemu_irq_raise(etsec->rx_irq);
RING_DEBUG("%s Raise Rx IRQ\n", __func__);
}
}
--
1.7.9.5
^ permalink raw reply related [flat|nested] 6+ messages in thread* [Qemu-devel] [PATCH] Fix typo in eTSEC Ethernet controller
@ 2014-04-02 14:49 ` Fabien Chouteau
0 siblings, 0 replies; 6+ messages in thread
From: Fabien Chouteau @ 2014-04-02 14:49 UTC (permalink / raw)
To: qemu-devel, qemu-trivial; +Cc: peter.maydell, agraf, pbonzini
IRQ are lowered when ievent bit is cleared, so irq_pulse makes no sense
here...
Signed-off-by: Fabien Chouteau <chouteau@adacore.com>
---
hw/net/fsl_etsec/rings.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/net/fsl_etsec/rings.c b/hw/net/fsl_etsec/rings.c
index e36cfbe..d4a494f 100644
--- a/hw/net/fsl_etsec/rings.c
+++ b/hw/net/fsl_etsec/rings.c
@@ -159,7 +159,7 @@ static void ievent_set(eTSEC *etsec,
if ((flags & IEVENT_RXB && etsec->regs[IMASK].value & IMASK_RXBEN)
|| (flags & IEVENT_RXF && etsec->regs[IMASK].value & IMASK_RXFEN)) {
- qemu_irq_pulse(etsec->rx_irq);
+ qemu_irq_raise(etsec->rx_irq);
RING_DEBUG("%s Raise Rx IRQ\n", __func__);
}
}
--
1.7.9.5
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [Qemu-trivial] [PATCH] Fix typo in eTSEC Ethernet controller
2014-04-02 14:49 ` [Qemu-devel] " Fabien Chouteau
@ 2014-04-02 14:52 ` Alexander Graf
-1 siblings, 0 replies; 6+ messages in thread
From: Alexander Graf @ 2014-04-02 14:52 UTC (permalink / raw)
To: Fabien Chouteau; +Cc: qemu-trivial, peter.maydell, qemu-devel, pbonzini
On 02.04.2014, at 16:49, Fabien Chouteau <chouteau@adacore.com> wrote:
> IRQ are lowered when ievent bit is cleared, so irq_pulse makes no sense
> here...
>
> Signed-off-by: Fabien Chouteau <chouteau@adacore.com>
Thanks, applied to ppc-next. Given that the wiring with boards is still missing I don't think this is a critical 2.0 fix.
Alex
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH] Fix typo in eTSEC Ethernet controller
@ 2014-04-02 14:52 ` Alexander Graf
0 siblings, 0 replies; 6+ messages in thread
From: Alexander Graf @ 2014-04-02 14:52 UTC (permalink / raw)
To: Fabien Chouteau; +Cc: qemu-trivial, peter.maydell, qemu-devel, pbonzini
On 02.04.2014, at 16:49, Fabien Chouteau <chouteau@adacore.com> wrote:
> IRQ are lowered when ievent bit is cleared, so irq_pulse makes no sense
> here...
>
> Signed-off-by: Fabien Chouteau <chouteau@adacore.com>
Thanks, applied to ppc-next. Given that the wiring with boards is still missing I don't think this is a critical 2.0 fix.
Alex
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-trivial] [PATCH] Fix typo in eTSEC Ethernet controller
2014-04-02 14:52 ` [Qemu-devel] " Alexander Graf
@ 2014-04-02 14:56 ` Fabien Chouteau
-1 siblings, 0 replies; 6+ messages in thread
From: Fabien Chouteau @ 2014-04-02 14:56 UTC (permalink / raw)
To: Alexander Graf; +Cc: qemu-trivial, peter.maydell, qemu-devel, pbonzini
On 04/02/2014 04:52 PM, Alexander Graf wrote:
>
> On 02.04.2014, at 16:49, Fabien Chouteau <chouteau@adacore.com> wrote:
>
>> IRQ are lowered when ievent bit is cleared, so irq_pulse makes no sense
>> here...
>>
>> Signed-off-by: Fabien Chouteau <chouteau@adacore.com>
>
> Thanks, applied to ppc-next.
Thanks Alex,
> Given that the wiring with boards is still missing I don't think this is a critical 2.0 fix.
>
That's right.
Regards,
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH] Fix typo in eTSEC Ethernet controller
@ 2014-04-02 14:56 ` Fabien Chouteau
0 siblings, 0 replies; 6+ messages in thread
From: Fabien Chouteau @ 2014-04-02 14:56 UTC (permalink / raw)
To: Alexander Graf; +Cc: qemu-trivial, peter.maydell, qemu-devel, pbonzini
On 04/02/2014 04:52 PM, Alexander Graf wrote:
>
> On 02.04.2014, at 16:49, Fabien Chouteau <chouteau@adacore.com> wrote:
>
>> IRQ are lowered when ievent bit is cleared, so irq_pulse makes no sense
>> here...
>>
>> Signed-off-by: Fabien Chouteau <chouteau@adacore.com>
>
> Thanks, applied to ppc-next.
Thanks Alex,
> Given that the wiring with boards is still missing I don't think this is a critical 2.0 fix.
>
That's right.
Regards,
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-04-02 14:57 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-04-02 14:49 [Qemu-trivial] [PATCH] Fix typo in eTSEC Ethernet controller Fabien Chouteau
2014-04-02 14:49 ` [Qemu-devel] " Fabien Chouteau
2014-04-02 14:52 ` [Qemu-trivial] " Alexander Graf
2014-04-02 14:52 ` [Qemu-devel] " Alexander Graf
2014-04-02 14:56 ` [Qemu-trivial] " Fabien Chouteau
2014-04-02 14:56 ` [Qemu-devel] " Fabien Chouteau
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.