From: Nishanth Menon <nm@ti.com>
To: Peter Ujfalusi <peter.ujfalusi@ti.com>, mturquette@linaro.org
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-omap@vger.kernel.org, ldewangan@nvidia.com,
linux-doc@vger.kernel.org, grant.likely@linaro.org
Subject: Re: [PATCH] clk: Add driver for Palmas clk32kg and clk32kgaudio clocks
Date: Thu, 3 Apr 2014 08:49:38 -0500 [thread overview]
Message-ID: <533D66F2.7050600@ti.com> (raw)
In-Reply-To: <1396522348-31989-1-git-send-email-peter.ujfalusi@ti.com>
On 04/03/2014 05:52 AM, Peter Ujfalusi wrote:
[...]
> .../devicetree/bindings/clock/clk-palmas.txt | 35 +++
> drivers/clk/Kconfig | 7 +
> drivers/clk/Makefile | 1 +
> drivers/clk/clk-palmas.c | 307 +++++++++++++++++++++
> include/dt-bindings/mfd/palmas.h | 18 ++
> 5 files changed, 368 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/clock/clk-palmas.txt
> create mode 100644 drivers/clk/clk-palmas.c
> create mode 100644 include/dt-bindings/mfd/palmas.h
Only complaint i have is based on :
http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=2a9330010bea5982a5c6593824bc036bf62d67b7
you may want to split the new binding off to a separate patch.
Otherwise, personally, I think it is an good evolution, thanks for
doing it.
--
Regards,
Nishanth Menon
WARNING: multiple messages have this Message-ID (diff)
From: Nishanth Menon <nm@ti.com>
To: Peter Ujfalusi <peter.ujfalusi@ti.com>, <mturquette@linaro.org>
Cc: <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-omap@vger.kernel.org>, <ldewangan@nvidia.com>,
<linux-doc@vger.kernel.org>, <grant.likely@linaro.org>
Subject: Re: [PATCH] clk: Add driver for Palmas clk32kg and clk32kgaudio clocks
Date: Thu, 3 Apr 2014 08:49:38 -0500 [thread overview]
Message-ID: <533D66F2.7050600@ti.com> (raw)
In-Reply-To: <1396522348-31989-1-git-send-email-peter.ujfalusi@ti.com>
On 04/03/2014 05:52 AM, Peter Ujfalusi wrote:
[...]
> .../devicetree/bindings/clock/clk-palmas.txt | 35 +++
> drivers/clk/Kconfig | 7 +
> drivers/clk/Makefile | 1 +
> drivers/clk/clk-palmas.c | 307 +++++++++++++++++++++
> include/dt-bindings/mfd/palmas.h | 18 ++
> 5 files changed, 368 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/clock/clk-palmas.txt
> create mode 100644 drivers/clk/clk-palmas.c
> create mode 100644 include/dt-bindings/mfd/palmas.h
Only complaint i have is based on :
http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=2a9330010bea5982a5c6593824bc036bf62d67b7
you may want to split the new binding off to a separate patch.
Otherwise, personally, I think it is an good evolution, thanks for
doing it.
--
Regards,
Nishanth Menon
next prev parent reply other threads:[~2014-04-03 13:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-03 10:52 [PATCH] clk: Add driver for Palmas clk32kg and clk32kgaudio clocks Peter Ujfalusi
2014-04-03 10:52 ` Peter Ujfalusi
2014-04-03 13:49 ` Nishanth Menon [this message]
2014-04-03 13:49 ` Nishanth Menon
2014-04-04 6:53 ` Peter Ujfalusi
2014-04-04 6:53 ` Peter Ujfalusi
2014-04-24 9:09 ` Peter Ujfalusi
2014-04-24 9:09 ` Peter Ujfalusi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=533D66F2.7050600@ti.com \
--to=nm@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=grant.likely@linaro.org \
--cc=ldewangan@nvidia.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mturquette@linaro.org \
--cc=peter.ujfalusi@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.