net-core-rtnetlinkc-copy-paste-error-in-rtnl_bridge_notify.patch

net-core-rtnetlinkc-copy-paste-error-in-rtnl_bridge_notify.patch

[Andrew Morton]

Guys, I've been sitting on this since January and simply cannot
remember what happened with it.  Is this still a thing or did it get
nacked, or...?

Thanks.


From: Yogesh Gaur <yogeshgaur.83@gmail.com>
Subject: net/core/rtnetlink.c: copy paste error in rtnl_bridge_notify()

Seems to be copy paste error in calling ndo_bridge_getlink() func.

Signed-off-by: Yogesh Gaur <yogeshgaur.83@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Vlad Yasevich <vyasevich@gmail.com>
Cc: Jiri Pirko <jiri@resnulli.us>
Cc: Nicolas Dichtel <nicolas.dichtel@6wind.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 net/core/rtnetlink.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff -puN net/core/rtnetlink.c~net-core-rtnetlinkc-copy-paste-error-in-rtnl_bridge_notify net/core/rtnetlink.c
--- a/net/core/rtnetlink.c~net-core-rtnetlinkc-copy-paste-error-in-rtnl_bridge_notify
+++ a/net/core/rtnetlink.c
@@ -2576,7 +2576,7 @@ static int rtnl_bridge_notify(struct net
 
 	if ((!flags || (flags & BRIDGE_FLAGS_MASTER)) &&
 	    br_dev && br_dev->netdev_ops->ndo_bridge_getlink) {
-		err = br_dev->netdev_ops->ndo_bridge_getlink(skb, 0, 0, dev, 0);
+		err = br_dev->netdev_ops->ndo_bridge_getlink(skb, 0, 0, br_dev, 0);
 		if (err < 0)
 			goto errout;
 	}
_

Re: net-core-rtnetlinkc-copy-paste-error-in-rtnl_bridge_notify.patch

[Daniel Borkmann]

On 04/03/2014 09:01 PM, Andrew Morton wrote:
> Guys, I've been sitting on this since January and simply cannot
> remember what happened with it.  Is this still a thing or did it get
> nacked, or...?

http://thread.gmane.org/gmane.linux.kernel/1638261/focus=1642371

I think someone should add a comment to this code line stating that
this is intentional ... :)

> Thanks.
>
> From: Yogesh Gaur <yogeshgaur.83@gmail.com>
> Subject: net/core/rtnetlink.c: copy paste error in rtnl_bridge_notify()
>
> Seems to be copy paste error in calling ndo_bridge_getlink() func.
>
> Signed-off-by: Yogesh Gaur <yogeshgaur.83@gmail.com>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Vlad Yasevich <vyasevich@gmail.com>
> Cc: Jiri Pirko <jiri@resnulli.us>
> Cc: Nicolas Dichtel <nicolas.dichtel@6wind.com>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> ---
>
>   net/core/rtnetlink.c |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff -puN net/core/rtnetlink.c~net-core-rtnetlinkc-copy-paste-error-in-rtnl_bridge_notify net/core/rtnetlink.c
> --- a/net/core/rtnetlink.c~net-core-rtnetlinkc-copy-paste-error-in-rtnl_bridge_notify
> +++ a/net/core/rtnetlink.c
> @@ -2576,7 +2576,7 @@ static int rtnl_bridge_notify(struct net
>
>   	if ((!flags || (flags & BRIDGE_FLAGS_MASTER)) &&
>   	    br_dev && br_dev->netdev_ops->ndo_bridge_getlink) {
> -		err = br_dev->netdev_ops->ndo_bridge_getlink(skb, 0, 0, dev, 0);
> +		err = br_dev->netdev_ops->ndo_bridge_getlink(skb, 0, 0, br_dev, 0);
>   		if (err < 0)
>   			goto errout;
>   	}
> _
>
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>