From: "Emilio López" <emilio@elopez.com.ar>
To: Guenter Roeck <linux@roeck-us.net>,
Maxime Ripard <maxime.ripard@free-electrons.com>,
wim@iguana.be, carlo.caione@gmail.com
Cc: linux-watchdog@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] watchdog: sunxi: Fix compilation with C=2
Date: Fri, 04 Apr 2014 14:57:04 -0300 [thread overview]
Message-ID: <533EF270.9090308@elopez.com.ar> (raw)
In-Reply-To: <533EED7A.20307@roeck-us.net>
Hi,
El 04/04/14 14:35, Guenter Roeck escribió:
> On 04/04/2014 10:24 AM, Emilio López wrote:
>> When compiling sunxi_defconfig while using C=2, the following error
>> causes the compilation to fail:
>>
>> drivers/watchdog/sunxi_wdt.c:60:15: error: constant 0b0001 is not
>> a valid number
>>
>> Fix it by using hex notation instead of the non-standard binary one
>>
>
> What defines "non-standard" here ?
non-standard as not part of the C standard. Binary constant notation is
a GCC extension as far as I'm aware:
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23479
http://gcc.gnu.org/onlinedocs/gcc/Binary-constants.html (Note the "C
Extensions" section)
> Isn't this a sparse problem that
> should possibly
> be fixed in sparse instead ?
It could be fixed in sparse as well, I don't really mind either way. The
binary notation doesn't seem to be used much, if at all, on the kernel
though; most of the matches I saw when quickly grepping were comments.
Cheers,
Emilio
WARNING: multiple messages have this Message-ID (diff)
From: emilio@elopez.com.ar (Emilio López)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] watchdog: sunxi: Fix compilation with C=2
Date: Fri, 04 Apr 2014 14:57:04 -0300 [thread overview]
Message-ID: <533EF270.9090308@elopez.com.ar> (raw)
In-Reply-To: <533EED7A.20307@roeck-us.net>
Hi,
El 04/04/14 14:35, Guenter Roeck escribi?:
> On 04/04/2014 10:24 AM, Emilio L?pez wrote:
>> When compiling sunxi_defconfig while using C=2, the following error
>> causes the compilation to fail:
>>
>> drivers/watchdog/sunxi_wdt.c:60:15: error: constant 0b0001 is not
>> a valid number
>>
>> Fix it by using hex notation instead of the non-standard binary one
>>
>
> What defines "non-standard" here ?
non-standard as not part of the C standard. Binary constant notation is
a GCC extension as far as I'm aware:
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23479
http://gcc.gnu.org/onlinedocs/gcc/Binary-constants.html (Note the "C
Extensions" section)
> Isn't this a sparse problem that
> should possibly
> be fixed in sparse instead ?
It could be fixed in sparse as well, I don't really mind either way. The
binary notation doesn't seem to be used much, if at all, on the kernel
though; most of the matches I saw when quickly grepping were comments.
Cheers,
Emilio
next prev parent reply other threads:[~2014-04-04 17:57 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-04 17:24 [PATCH] watchdog: sunxi: Fix compilation with C=2 Emilio López
2014-04-04 17:24 ` Emilio López
2014-04-04 17:35 ` Guenter Roeck
2014-04-04 17:35 ` Guenter Roeck
2014-04-04 17:57 ` Emilio López [this message]
2014-04-04 17:57 ` Emilio López
2014-04-04 18:01 ` Guenter Roeck
2014-04-04 18:01 ` Guenter Roeck
2014-04-04 18:02 ` Guenter Roeck
2014-04-04 18:02 ` Guenter Roeck
2014-05-11 19:46 ` Emilio López
2014-05-11 19:46 ` Emilio López
2014-05-15 8:52 ` Maxime Ripard
2014-05-15 8:52 ` Maxime Ripard
2014-05-26 18:50 ` Wim Van Sebroeck
2014-05-26 18:51 ` Wim Van Sebroeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=533EF270.9090308@elopez.com.ar \
--to=emilio@elopez.com.ar \
--cc=carlo.caione@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=maxime.ripard@free-electrons.com \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.