* [PATCH] Staging: rtl8192e: Fix sparse warning
@ 2014-04-06 18:23 Joel Pelaez Jorge
2014-04-06 18:28 ` Greg Kroah-Hartman
0 siblings, 1 reply; 2+ messages in thread
From: Joel Pelaez Jorge @ 2014-04-06 18:23 UTC (permalink / raw)
To: Greg Kroah-Hartman, Silvan Jegen; +Cc: devel, linux-kernel
drivers/staging/rtl8192e/rtl8192e/rtl_wx.c:1323:24: warning:
symbol 'r8192_wx_handlers_def' was not declared. Should it be static
Signed-off-by: Joel Pelaez Jorge <joelpelaez@gmail.com>
---
drivers/staging/rtl8192e/rtl8192e/rtl_wx.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c
b/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c
index 498995d..5baa699 100644
--- a/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c
+++ b/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c
@@ -20,6 +20,8 @@
#include <linux/string.h>
#include "rtl_core.h"
+extern struct iw_handler_def r8192_wx_handlers_def;
+
#define RATE_COUNT 12
static u32 rtl8192_rates[] = {
1000000, 2000000, 5500000, 11000000, 6000000, 9000000, 12000000,
--
1.7.10.4
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] Staging: rtl8192e: Fix sparse warning
2014-04-06 18:23 [PATCH] Staging: rtl8192e: Fix sparse warning Joel Pelaez Jorge
@ 2014-04-06 18:28 ` Greg Kroah-Hartman
0 siblings, 0 replies; 2+ messages in thread
From: Greg Kroah-Hartman @ 2014-04-06 18:28 UTC (permalink / raw)
To: Joel Pelaez Jorge; +Cc: Silvan Jegen, devel, linux-kernel
On Sun, Apr 06, 2014 at 01:23:15PM -0500, Joel Pelaez Jorge wrote:
> drivers/staging/rtl8192e/rtl8192e/rtl_wx.c:1323:24: warning:
> symbol 'r8192_wx_handlers_def' was not declared. Should it be static
>
> Signed-off-by: Joel Pelaez Jorge <joelpelaez@gmail.com>
> ---
> drivers/staging/rtl8192e/rtl8192e/rtl_wx.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c
> b/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c
> index 498995d..5baa699 100644
> --- a/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c
> +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c
> @@ -20,6 +20,8 @@
> #include <linux/string.h>
> #include "rtl_core.h"
>
> +extern struct iw_handler_def r8192_wx_handlers_def;
Don't put "extern" in a .c file, that's never the correct solution.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-04-06 18:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-04-06 18:23 [PATCH] Staging: rtl8192e: Fix sparse warning Joel Pelaez Jorge
2014-04-06 18:28 ` Greg Kroah-Hartman
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.