From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: Sachin Kamat <sachin.kamat@linaro.org>
Cc: Kukjin Kim <kgene.kim@samsung.com>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
linux-samsung-soc <linux-samsung-soc@vger.kernel.org>,
Tomasz Figa <t.figa@samsung.com>,
Lists linaro-kernel <linaro-kernel@lists.linaro.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>
Subject: Re: [PATCH V2 16/17] ARM: exynos: cpuidle: Move the driver to drivers/cpuidle directory
Date: Mon, 07 Apr 2014 13:53:56 +0200 [thread overview]
Message-ID: <534291D4.1010803@linaro.org> (raw)
In-Reply-To: <CAK9yfHzXk6ErtmNuT0Z-kMfUGT=GMmFugPR8J=-3SvPMagp6ZA@mail.gmail.com>
On 04/07/2014 11:51 AM, Sachin Kamat wrote:
> Hi Daniel,
>
> On 4 April 2014 19:13, Daniel Lezcano <daniel.lezcano@linaro.org> wrote:
>> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
>> Reviewed-by: Viresh Kumar <viresh.kumar@linaro.org>
>> ---
>> arch/arm/mach-exynos/Makefile | 1 -
>> drivers/cpuidle/Kconfig.arm | 7 +++++++
>> drivers/cpuidle/Makefile | 1 +
>> .../cpuidle.c => drivers/cpuidle/cpuidle-exynos.c | 0
>> 4 files changed, 8 insertions(+), 1 deletion(-)
>> rename arch/arm/mach-exynos/cpuidle.c => drivers/cpuidle/cpuidle-exynos.c (100%)
>
> This driver now references platform header file (plat/cpu.h) for some
> Exynos5440 specific check
> which is not good considering multiplatform support. Any plan to get
> rid of this?
Yes. Prevent to register the platform device for this board and remove
these lines in the driver.
What is the benefit of having a single state WFI cpuidle driver ? That
pulls all the governor computation and decision for nothing.
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
WARNING: multiple messages have this Message-ID (diff)
From: daniel.lezcano@linaro.org (Daniel Lezcano)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V2 16/17] ARM: exynos: cpuidle: Move the driver to drivers/cpuidle directory
Date: Mon, 07 Apr 2014 13:53:56 +0200 [thread overview]
Message-ID: <534291D4.1010803@linaro.org> (raw)
In-Reply-To: <CAK9yfHzXk6ErtmNuT0Z-kMfUGT=GMmFugPR8J=-3SvPMagp6ZA@mail.gmail.com>
On 04/07/2014 11:51 AM, Sachin Kamat wrote:
> Hi Daniel,
>
> On 4 April 2014 19:13, Daniel Lezcano <daniel.lezcano@linaro.org> wrote:
>> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
>> Reviewed-by: Viresh Kumar <viresh.kumar@linaro.org>
>> ---
>> arch/arm/mach-exynos/Makefile | 1 -
>> drivers/cpuidle/Kconfig.arm | 7 +++++++
>> drivers/cpuidle/Makefile | 1 +
>> .../cpuidle.c => drivers/cpuidle/cpuidle-exynos.c | 0
>> 4 files changed, 8 insertions(+), 1 deletion(-)
>> rename arch/arm/mach-exynos/cpuidle.c => drivers/cpuidle/cpuidle-exynos.c (100%)
>
> This driver now references platform header file (plat/cpu.h) for some
> Exynos5440 specific check
> which is not good considering multiplatform support. Any plan to get
> rid of this?
Yes. Prevent to register the platform device for this board and remove
these lines in the driver.
What is the benefit of having a single state WFI cpuidle driver ? That
pulls all the governor computation and decision for nothing.
--
<http://www.linaro.org/> Linaro.org ? Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
next prev parent reply other threads:[~2014-04-07 11:53 UTC|newest]
Thread overview: 92+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-04 13:42 [PATCH V2 00/17] ARM: exynos: cpuidle: Move the driver to drivers/cpuidle Daniel Lezcano
2014-04-04 13:42 ` Daniel Lezcano
2014-04-04 13:42 ` [PATCH V2 01/17] ARM: exynos: cpuidle: Prevent forward declaration Daniel Lezcano
2014-04-04 13:42 ` Daniel Lezcano
2014-04-04 15:24 ` Bartlomiej Zolnierkiewicz
2014-04-04 15:24 ` Bartlomiej Zolnierkiewicz
2014-04-04 13:42 ` [PATCH V2 02/17] ARM: exynos: cpuidle: use cpuidle_register Daniel Lezcano
2014-04-04 13:42 ` Daniel Lezcano
2014-04-04 15:28 ` Bartlomiej Zolnierkiewicz
2014-04-04 15:28 ` Bartlomiej Zolnierkiewicz
2014-04-04 13:42 ` [PATCH V2 03/17] ARM: exynos: cpuidle: change function name prefix Daniel Lezcano
2014-04-04 13:42 ` Daniel Lezcano
2014-04-04 15:28 ` Bartlomiej Zolnierkiewicz
2014-04-04 15:28 ` Bartlomiej Zolnierkiewicz
2014-04-04 13:42 ` [PATCH V2 04/17] ARM: exynos: cpuidle: encapsulate register access inside a function Daniel Lezcano
2014-04-04 13:42 ` Daniel Lezcano
2014-04-04 15:28 ` Bartlomiej Zolnierkiewicz
2014-04-04 15:28 ` Bartlomiej Zolnierkiewicz
2014-04-04 13:42 ` [PATCH V2 05/17] ARM: exynos: cpuidle: Move some code inside the idle_finisher Daniel Lezcano
2014-04-04 13:42 ` Daniel Lezcano
2014-04-04 15:29 ` Bartlomiej Zolnierkiewicz
2014-04-04 15:29 ` Bartlomiej Zolnierkiewicz
2014-04-04 13:42 ` [PATCH V2 06/17] ARM: exynos: cpuidle: Fix S5P_WAKEUP_STAT call Daniel Lezcano
2014-04-04 13:42 ` Daniel Lezcano
2014-04-04 15:29 ` Bartlomiej Zolnierkiewicz
2014-04-04 15:29 ` Bartlomiej Zolnierkiewicz
2014-04-04 13:42 ` [PATCH V2 07/17] ARM: exynos: cpuidle: Use the cpu_pm notifier Daniel Lezcano
2014-04-04 13:42 ` Daniel Lezcano
2014-04-04 15:30 ` Bartlomiej Zolnierkiewicz
2014-04-04 15:30 ` Bartlomiej Zolnierkiewicz
2014-04-04 13:43 ` [PATCH V2 08/17] ARM: exynos: cpuidle: Move scu_enable in " Daniel Lezcano
2014-04-04 13:43 ` Daniel Lezcano
2014-04-04 15:30 ` Bartlomiej Zolnierkiewicz
2014-04-04 15:30 ` Bartlomiej Zolnierkiewicz
2014-04-04 13:43 ` [PATCH V2 09/17] ARM: exynos: cpuidle: Remove ifdef for scu_enable Daniel Lezcano
2014-04-04 13:43 ` Daniel Lezcano
2014-04-04 15:31 ` Bartlomiej Zolnierkiewicz
2014-04-04 15:31 ` Bartlomiej Zolnierkiewicz
2014-04-04 13:43 ` [PATCH V2 10/17] ARM: exynos: cpuidle: Move exynos_set_wakeupmask in the cpu_pm notifier Daniel Lezcano
2014-04-04 13:43 ` Daniel Lezcano
2014-04-04 15:31 ` Bartlomiej Zolnierkiewicz
2014-04-04 15:31 ` Bartlomiej Zolnierkiewicz
2014-04-04 13:43 ` [PATCH V2 11/17] ARM: exynos: cpuidle: Move the power sequence call " Daniel Lezcano
2014-04-04 13:43 ` Daniel Lezcano
2014-04-04 15:31 ` Bartlomiej Zolnierkiewicz
2014-04-04 15:31 ` Bartlomiej Zolnierkiewicz
2014-04-04 13:43 ` [PATCH V2 12/17] ARM: exynos: cpuidle: Move S5P_CHECK_AFTR in a header Daniel Lezcano
2014-04-04 13:43 ` Daniel Lezcano
2014-04-04 15:32 ` Bartlomiej Zolnierkiewicz
2014-04-04 15:32 ` Bartlomiej Zolnierkiewicz
2014-04-04 13:43 ` [PATCH V2 13/17] ARM: exynos: cpuidle: Move clock setup to pm.c Daniel Lezcano
2014-04-04 13:43 ` Daniel Lezcano
2014-04-04 15:35 ` Bartlomiej Zolnierkiewicz
2014-04-04 15:35 ` Bartlomiej Zolnierkiewicz
2014-04-04 13:43 ` [PATCH V2 14/17] ARM: exynos: cpuidle: Move the boot vector in pm.c Daniel Lezcano
2014-04-04 13:43 ` Daniel Lezcano
2014-04-04 15:35 ` Bartlomiej Zolnierkiewicz
2014-04-04 15:35 ` Bartlomiej Zolnierkiewicz
2014-04-04 13:43 ` [PATCH V2 15/17] ARM: exynos: cpuidle: Pass the AFTR callback to the platform_data Daniel Lezcano
2014-04-04 13:43 ` Daniel Lezcano
2014-04-04 15:35 ` Bartlomiej Zolnierkiewicz
2014-04-04 15:35 ` Bartlomiej Zolnierkiewicz
2014-04-04 13:43 ` [PATCH V2 16/17] ARM: exynos: cpuidle: Move the driver to drivers/cpuidle directory Daniel Lezcano
2014-04-04 13:43 ` Daniel Lezcano
2014-04-04 15:36 ` Bartlomiej Zolnierkiewicz
2014-04-04 15:36 ` Bartlomiej Zolnierkiewicz
2014-04-07 9:51 ` Sachin Kamat
2014-04-07 9:51 ` Sachin Kamat
2014-04-07 11:53 ` Daniel Lezcano [this message]
2014-04-07 11:53 ` Daniel Lezcano
2014-04-04 13:43 ` [PATCH V2 17/17] ARM: exynos: config: Enable cpuidle Daniel Lezcano
2014-04-04 13:43 ` Daniel Lezcano
2014-04-04 16:09 ` Bartlomiej Zolnierkiewicz
2014-04-04 16:09 ` Bartlomiej Zolnierkiewicz
2014-04-07 9:43 ` Daniel Lezcano
2014-04-07 9:43 ` Daniel Lezcano
2014-04-07 16:19 ` Bartlomiej Zolnierkiewicz
2014-04-07 16:19 ` Bartlomiej Zolnierkiewicz
2014-04-07 16:26 ` Olof Johansson
2014-04-07 16:26 ` Olof Johansson
2014-04-07 16:28 ` Olof Johansson
2014-04-07 16:28 ` Olof Johansson
2014-04-07 17:44 ` Bartlomiej Zolnierkiewicz
2014-04-07 17:44 ` Bartlomiej Zolnierkiewicz
2014-04-07 18:33 ` Olof Johansson
2014-04-07 18:33 ` Olof Johansson
2014-04-08 3:57 ` Sachin Kamat
2014-04-08 3:57 ` Sachin Kamat
2014-04-08 9:40 ` Bartlomiej Zolnierkiewicz
2014-04-08 9:40 ` Bartlomiej Zolnierkiewicz
2014-04-08 9:26 ` Bartlomiej Zolnierkiewicz
2014-04-08 9:26 ` Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=534291D4.1010803@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=kgene.kim@samsung.com \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=sachin.kamat@linaro.org \
--cc=t.figa@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.